From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E27E1A034F for ; Tue, 1 Mar 2022 11:43:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD83841C3B; Tue, 1 Mar 2022 11:43:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C5DA0426E7 for ; Tue, 1 Mar 2022 11:43:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646131434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQnh7KyKIo2FWJfa23euc79Saw2R9ttcAQ5JS40Itwc=; b=bVz/Xec2ViYLAhOR8kGYojC7Z+crWD86pcFiRdTYBvuga3w8IcTUOd8PRWM3i9Yv+x2Rne NcjK4GqXugjDKXGZbUSgoUU69iY2dfdBUxgx9QuxCOYtXsfODwSbLdVOAmK6SV1V4GUB8G opqpAkeLkqWruBQFR1XzNy06RC6SMck= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-17-0nMhe1meMt2WUZ-zlnSFTw-1; Tue, 01 Mar 2022 05:43:51 -0500 X-MC-Unique: 0nMhe1meMt2WUZ-zlnSFTw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B7F7B186833A; Tue, 1 Mar 2022 10:43:50 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id D9ACF75549; Tue, 1 Mar 2022 10:43:49 +0000 (UTC) From: Kevin Traynor To: Gowrishankar Muthukrishnan Cc: dpdk stable Subject: patch 'event/cnxk: fix uninitialized local variables' has been queued to stable release 21.11.1 Date: Tue, 1 Mar 2022 10:41:40 +0000 Message-Id: <20220301104300.334382-24-ktraynor@redhat.com> In-Reply-To: <20220301104300.334382-1-ktraynor@redhat.com> References: <20220301104300.334382-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/06/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/fec66e64e5a90aff71931d728cf6adb349b344a6 Thanks. Kevin --- >From fec66e64e5a90aff71931d728cf6adb349b344a6 Mon Sep 17 00:00:00 2001 From: Gowrishankar Muthukrishnan Date: Sat, 12 Feb 2022 18:09:48 +0530 Subject: [PATCH] event/cnxk: fix uninitialized local variables [ upstream commit de3f033e5462fb1a0cad3c94c51fd79b5bf1b33f ] Fix uninitialized local variable as reported in coverity scan. Coverity issue: 370578, 370579, 370587 Fixes: 300b796262a ("event/cnxk: add timer arm routine") Signed-off-by: Gowrishankar Muthukrishnan --- drivers/event/cnxk/cnxk_tim_worker.c | 2 +- drivers/event/cnxk/cnxk_tim_worker.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/event/cnxk/cnxk_tim_worker.c b/drivers/event/cnxk/cnxk_tim_worker.c index 3ce99864a6..dfcfbdc797 100644 --- a/drivers/event/cnxk/cnxk_tim_worker.c +++ b/drivers/event/cnxk/cnxk_tim_worker.c @@ -64,5 +64,5 @@ cnxk_tim_timer_arm_burst(const struct rte_event_timer_adapter *adptr, struct cnxk_tim_ent entry; uint16_t index; - int ret; + int ret = 0; cnxk_tim_sync_start_cyc(tim_ring); diff --git a/drivers/event/cnxk/cnxk_tim_worker.h b/drivers/event/cnxk/cnxk_tim_worker.h index 78e36ffafe..0c9f29cfbe 100644 --- a/drivers/event/cnxk/cnxk_tim_worker.h +++ b/drivers/event/cnxk/cnxk_tim_worker.h @@ -234,6 +234,6 @@ cnxk_tim_add_entry_sp(struct cnxk_tim_ring *const tim_ring, const uint8_t flags) { + struct cnxk_tim_ent *chunk = NULL; struct cnxk_tim_bkt *mirr_bkt; - struct cnxk_tim_ent *chunk; struct cnxk_tim_bkt *bkt; uint64_t lock_sema; @@ -317,6 +317,6 @@ cnxk_tim_add_entry_mp(struct cnxk_tim_ring *const tim_ring, const uint8_t flags) { + struct cnxk_tim_ent *chunk = NULL; struct cnxk_tim_bkt *mirr_bkt; - struct cnxk_tim_ent *chunk; struct cnxk_tim_bkt *bkt; uint64_t lock_sema; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-01 10:41:02.029368069 +0000 +++ 0024-event-cnxk-fix-uninitialized-local-variables.patch 2022-03-01 10:41:01.273244091 +0000 @@ -1 +1 @@ -From de3f033e5462fb1a0cad3c94c51fd79b5bf1b33f Mon Sep 17 00:00:00 2001 +From fec66e64e5a90aff71931d728cf6adb349b344a6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit de3f033e5462fb1a0cad3c94c51fd79b5bf1b33f ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org