From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12AE4A034F for ; Tue, 1 Mar 2022 11:43:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BCD140DF6; Tue, 1 Mar 2022 11:43:58 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7377941C3B for ; Tue, 1 Mar 2022 11:43:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646131436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MEarWgIBz70wpV9ZUzj/f9eUN+WRh43/bR2Y2Abf12M=; b=G/JqVyRGEsA2hDFbKMRZT9jOcj7vtBfgsUT+qggu+P81ZfbqSxgoI2y3lON3law5ZlLxXq ZcfYrMwHtEvFNbOfAokvI6688jUmzQ5O90ZL+sQ1I/XNN7VQm+uL/Fj7YHkB5icovCf2ds 6dFBbrnf3bNERGoNOCaudN2WpY3bhdw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-86-q0YjcrZVMUGcfb7rF6jPPQ-1; Tue, 01 Mar 2022 05:43:52 -0500 X-MC-Unique: q0YjcrZVMUGcfb7rF6jPPQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F08E5100C609; Tue, 1 Mar 2022 10:43:51 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id 192E375524; Tue, 1 Mar 2022 10:43:50 +0000 (UTC) From: Kevin Traynor To: Ciara Power Cc: dpdk stable Subject: patch 'crypto/ipsec_mb: remove useless check' has been queued to stable release 21.11.1 Date: Tue, 1 Mar 2022 10:41:41 +0000 Message-Id: <20220301104300.334382-25-ktraynor@redhat.com> In-Reply-To: <20220301104300.334382-1-ktraynor@redhat.com> References: <20220301104300.334382-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/06/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/c8bcbe8b682c1a894dc2e632a584d215e4950b7b Thanks. Kevin --- >From c8bcbe8b682c1a894dc2e632a584d215e4950b7b Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Tue, 15 Feb 2022 11:07:58 +0000 Subject: [PATCH] crypto/ipsec_mb: remove useless check [ upstream commit f819a1629b1ccc9ed74e17374e26507a490058ac ] The qp is never NULL when it reaches the qp_setup_cleanup error handling code. This is due to checks earlier in the function that return an error if qp is NULL. Coverity issue: 375013 Fixes: 581c39b1cb7d ("crypto/ipsec_mb: fix queue cleanup null pointer dereference") Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c index 1ebd23e8f0..58ea4ee476 100644 --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c @@ -286,6 +286,4 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, qp_setup_cleanup: - if (qp == NULL) - return ret; #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM if (qp->mb_mgr) -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-01 10:41:02.051013528 +0000 +++ 0025-crypto-ipsec_mb-remove-useless-check.patch 2022-03-01 10:41:01.273244091 +0000 @@ -1 +1 @@ -From f819a1629b1ccc9ed74e17374e26507a490058ac Mon Sep 17 00:00:00 2001 +From c8bcbe8b682c1a894dc2e632a584d215e4950b7b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f819a1629b1ccc9ed74e17374e26507a490058ac ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 1cf37e9836..7e8396b4a3 100644 +index 1ebd23e8f0..58ea4ee476 100644 @@ -23 +24 @@ -@@ -285,6 +285,4 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id, +@@ -286,6 +286,4 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,