From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADEA5A034F for ; Tue, 1 Mar 2022 11:44:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A89FC426E1; Tue, 1 Mar 2022 11:44:02 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D93C7426DC for ; Tue, 1 Mar 2022 11:44:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646131441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=52vteBfVV07bTUyzpg18nPDeusNfNdCDu+RykW6t+/E=; b=fH8SlLEUVmQk5oFIz2KDSUtqLPI5KmO6NYz9Uj5oxS36Q3HLA9WZ/L5hFfnIIICgtgVG8P nHN6sgTa5D+rH7xKMfiJQmvwQ8yrEpu9U1plqi28MEj0OuxtTrTEs5NtPqAiJkBGSeHof8 WgMZTcueTqhvO6ApLnEIpMVj8jWO0/Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-438-7KLOgPzdM9SH7OueAlDFMQ-1; Tue, 01 Mar 2022 05:43:58 -0500 X-MC-Unique: 7KLOgPzdM9SH7OueAlDFMQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E5540100C609; Tue, 1 Mar 2022 10:43:57 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id D6D71752D1; Tue, 1 Mar 2022 10:43:56 +0000 (UTC) From: Kevin Traynor To: Brian Dooley Cc: Akhil Goyal , dpdk stable Subject: patch 'examples/l2fwd-crypto: fix port mask overflow' has been queued to stable release 21.11.1 Date: Tue, 1 Mar 2022 10:41:45 +0000 Message-Id: <20220301104300.334382-29-ktraynor@redhat.com> In-Reply-To: <20220301104300.334382-1-ktraynor@redhat.com> References: <20220301104300.334382-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/06/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/79247ddc0dbe3789d61051fed677ed73860848ab Thanks. Kevin --- >From 79247ddc0dbe3789d61051fed677ed73860848ab Mon Sep 17 00:00:00 2001 From: Brian Dooley Date: Mon, 21 Feb 2022 18:06:58 +0000 Subject: [PATCH] examples/l2fwd-crypto: fix port mask overflow [ upstream commit aaf4ac404362752e9c8effa4641bb480187d04ec ] Coverity flags an issue with 32-bit value. If max ethports value is configured with a value larger than 32 there will be an issue. Coverity issue: 375863 Unintentional integer overflow Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application") Signed-off-by: Brian Dooley Acked-by: Akhil Goyal --- examples/l2fwd-crypto/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 4d9f8861af..bbdb263143 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -2720,5 +2720,5 @@ initialize_ports(struct l2fwd_crypto_options *options) } - l2fwd_enabled_port_mask |= (1 << portid); + l2fwd_enabled_port_mask |= (1ULL << portid); enabled_portcount++; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-01 10:41:02.143189494 +0000 +++ 0029-examples-l2fwd-crypto-fix-port-mask-overflow.patch 2022-03-01 10:41:01.280244093 +0000 @@ -1 +1 @@ -From aaf4ac404362752e9c8effa4641bb480187d04ec Mon Sep 17 00:00:00 2001 +From 79247ddc0dbe3789d61051fed677ed73860848ab Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit aaf4ac404362752e9c8effa4641bb480187d04ec ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org