From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9260A034F for ; Tue, 1 Mar 2022 11:44:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4584407FF; Tue, 1 Mar 2022 11:44:05 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AFE1A41C3B for ; Tue, 1 Mar 2022 11:44:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646131444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IevijZXFnUzJP3fiwSkOspSaxG4M/a/Dn/bZF8xmPAI=; b=cEh4ABQPkP2zG3CZqDISSA9N2YB1CCbwFeFnWra8/RJGOLODItToMlmsx1GOAJQ/O1M7Jx Jtjkd0BWRzLcbdjUc5Fg0+9Z8DDHY5OkoFZS5TlMvWVmBmCCSRhim1Hqse9psXLKGv2ex/ xZcjZ1UCLEBaTa7pHyOQQsUzgJ/76Ds= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-353-nWtzyaMKPTmt2b0ZS0vrxw-1; Tue, 01 Mar 2022 05:44:00 -0500 X-MC-Unique: nWtzyaMKPTmt2b0ZS0vrxw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 259F1807109; Tue, 1 Mar 2022 10:43:59 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C857752D1; Tue, 1 Mar 2022 10:43:58 +0000 (UTC) From: Kevin Traynor To: Nicolas Chautru Cc: dpdk stable Subject: patch 'baseband/acc100: avoid out-of-bounds access' has been queued to stable release 21.11.1 Date: Tue, 1 Mar 2022 10:41:46 +0000 Message-Id: <20220301104300.334382-30-ktraynor@redhat.com> In-Reply-To: <20220301104300.334382-1-ktraynor@redhat.com> References: <20220301104300.334382-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/06/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/301ee2f3787f4b7501fe91a33010a30316336b4b Thanks. Kevin --- >From 301ee2f3787f4b7501fe91a33010a30316336b4b Mon Sep 17 00:00:00 2001 From: Nicolas Chautru Date: Tue, 22 Feb 2022 15:43:36 -0800 Subject: [PATCH] baseband/acc100: avoid out-of-bounds access [ upstream commit fb6996eec066dc7fa0eda951e492a65c8380d930 ] The actual maximum number of gather pointers should have been limited Coverity issue: 375803, 375813, 375819, 375827, 375831 Fixes: 5ad5060f8f7a ("baseband/acc100: add LDPC processing functions") Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 3 +-- drivers/baseband/acc100/rte_acc100_pmd.h | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c index 1c6080f2f8..cc69c76d54 100644 --- a/drivers/baseband/acc100/rte_acc100_pmd.c +++ b/drivers/baseband/acc100/rte_acc100_pmd.c @@ -1461,6 +1461,5 @@ acc100_dma_fill_blk_type_in(struct acc100_dma_req_desc *desc, while (cb_len > 0) { - if (next_triplet < ACC100_DMA_MAX_NUM_POINTERS && - m->next != NULL) { + if (next_triplet < ACC100_DMA_MAX_NUM_POINTERS_IN && m->next != NULL) { m = m->next; diff --git a/drivers/baseband/acc100/rte_acc100_pmd.h b/drivers/baseband/acc100/rte_acc100_pmd.h index 03ed0b3e1a..cbcece2966 100644 --- a/drivers/baseband/acc100/rte_acc100_pmd.h +++ b/drivers/baseband/acc100/rte_acc100_pmd.h @@ -114,4 +114,5 @@ #define ACC100_MAX_QUEUE_DEPTH 1024 #define ACC100_DMA_MAX_NUM_POINTERS 14 +#define ACC100_DMA_MAX_NUM_POINTERS_IN 7 #define ACC100_DMA_DESC_PADDING 8 #define ACC100_FCW_PADDING 12 -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-01 10:41:02.166273648 +0000 +++ 0030-baseband-acc100-avoid-out-of-bounds-access.patch 2022-03-01 10:41:01.284244094 +0000 @@ -1 +1 @@ -From fb6996eec066dc7fa0eda951e492a65c8380d930 Mon Sep 17 00:00:00 2001 +From 301ee2f3787f4b7501fe91a33010a30316336b4b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fb6996eec066dc7fa0eda951e492a65c8380d930 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index f86474f7e0..de7e4bcef4 100644 +index 1c6080f2f8..cc69c76d54 100644