patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Brian Dooley <brian.dooley@intel.com>
Cc: Fan Zhang <roy.fan.zhang@intel.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'crypto/virtio: fix out-of-bounds access' has been queued to stable release 21.11.1
Date: Tue,  1 Mar 2022 10:41:47 +0000	[thread overview]
Message-ID: <20220301104300.334382-31-ktraynor@redhat.com> (raw)
In-Reply-To: <20220301104300.334382-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to stable release 21.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/06/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/9c67637c8cd498e9275572170b5595c3c824015f

Thanks.

Kevin

---
From 9c67637c8cd498e9275572170b5595c3c824015f Mon Sep 17 00:00:00 2001
From: Brian Dooley <brian.dooley@intel.com>
Date: Tue, 22 Feb 2022 09:54:51 +0000
Subject: [PATCH] crypto/virtio: fix out-of-bounds access

[ upstream commit a965e768065ae496c9a1c7a77545bc0f0f0e38e2 ]

Coverity flags an untrusted loop bound. Check length of session iv.

Coverity issue: 375802
Fixes: b063e843fa03 ("crypto/virtio: fix IV physical address")

Signed-off-by: Brian Dooley <brian.dooley@intel.com>
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 drivers/crypto/virtio/virtio_rxtx.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/crypto/virtio/virtio_rxtx.c b/drivers/crypto/virtio/virtio_rxtx.c
index a65524a306..08359b3a39 100644
--- a/drivers/crypto/virtio/virtio_rxtx.c
+++ b/drivers/crypto/virtio/virtio_rxtx.c
@@ -265,4 +265,7 @@ virtqueue_crypto_sym_enqueue_xmit(
 			desc[idx].addr = cop->phys_addr + session->iv.offset;
 		else {
+			if (session->iv.length > VIRTIO_CRYPTO_MAX_IV_SIZE)
+				return -ENOMEM;
+
 			rte_memcpy(crypto_op_cookie->iv,
 					rte_crypto_op_ctod_offset(cop,
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-03-01 10:41:02.192034135 +0000
+++ 0031-crypto-virtio-fix-out-of-bounds-access.patch	2022-03-01 10:41:01.285244094 +0000
@@ -1 +1 @@
-From a965e768065ae496c9a1c7a77545bc0f0f0e38e2 Mon Sep 17 00:00:00 2001
+From 9c67637c8cd498e9275572170b5595c3c824015f Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit a965e768065ae496c9a1c7a77545bc0f0f0e38e2 ]
+
@@ -10 +11,0 @@
-Cc: stable@dpdk.org


  parent reply	other threads:[~2022-03-01 10:44 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 10:41 patch 'dmadev: add missing header include' " Kevin Traynor
2022-03-01 10:41 ` patch 'eal: add missing C++ guards' " Kevin Traynor
2022-03-01 10:41 ` patch 'telemetry: " Kevin Traynor
2022-03-01 10:41 ` patch 'ethdev: " Kevin Traynor
2022-03-01 10:41 ` patch 'metrics: " Kevin Traynor
2022-03-01 10:41 ` patch 'acl: " Kevin Traynor
2022-03-01 10:41 ` patch 'compressdev: " Kevin Traynor
2022-03-01 10:41 ` patch 'eventdev: " Kevin Traynor
2022-03-01 10:41 ` patch 'kni: " Kevin Traynor
2022-03-01 10:41 ` patch 'vhost: " Kevin Traynor
2022-03-01 10:41 ` patch 'bpf: " Kevin Traynor
2022-03-01 10:41 ` patch 'cryptodev: " Kevin Traynor
2022-03-01 10:41 ` patch 'ethdev: fix cast for C++ compatibility' " Kevin Traynor
2022-03-01 10:41 ` patch 'dma/hisilicon: use common PCI device naming' " Kevin Traynor
2022-03-01 10:41 ` patch 'test/dma: fix missing checks for device capacity' " Kevin Traynor
2022-03-01 10:41 ` patch 'dma/idxd: configure maximum batch size to high value' " Kevin Traynor
2022-03-01 10:41 ` patch 'doc: improve configuration examples in idxd guide' " Kevin Traynor
2022-03-01 10:41 ` patch 'examples/qos_sched: fix core mask overflow' " Kevin Traynor
2022-03-01 18:28   ` Ajmera, Megha
2022-03-01 10:41 ` patch 'eventdev/eth_rx: fix parameters parsing memory leak' " Kevin Traynor
2022-03-01 10:41 ` patch 'eventdev/eth_rx: fix queue config query' " Kevin Traynor
2022-03-01 10:41 ` patch 'event/dlb2: update rolling mask used for dequeue' " Kevin Traynor
2022-03-01 10:41 ` patch 'event/dlb2: poll HW CQ inflights before mapping queue' " Kevin Traynor
2022-03-01 10:41 ` patch 'event/cnxk: fix variables casting' " Kevin Traynor
2022-03-01 10:41 ` patch 'event/cnxk: fix uninitialized local variables' " Kevin Traynor
2022-03-01 10:41 ` patch 'crypto/ipsec_mb: remove useless check' " Kevin Traynor
2022-03-01 10:41 ` patch 'cryptodev: fix RSA key type name' " Kevin Traynor
2022-03-01 10:41 ` patch 'examples/ipsec-secgw: fix buffer freeing in vector mode' " Kevin Traynor
2022-03-01 10:41 ` patch 'doc: fix FIPS guide' " Kevin Traynor
2022-03-01 10:41 ` patch 'examples/l2fwd-crypto: fix port mask overflow' " Kevin Traynor
2022-03-01 10:41 ` patch 'baseband/acc100: avoid out-of-bounds access' " Kevin Traynor
2022-03-01 10:41 ` Kevin Traynor [this message]
2022-03-01 10:41 ` patch 'crypto/ipsec_mb: check missing operation types' " Kevin Traynor
2022-03-01 10:41 ` patch 'crypto/ipsec_mb: fix ZUC authentication verify' " Kevin Traynor
2022-03-01 10:41 ` patch 'crypto/ipsec_mb: fix ZUC operation overwrite' " Kevin Traynor
2022-03-01 10:41 ` patch 'crypto/ipsec_mb: fix length and offset settings' " Kevin Traynor
2022-03-01 10:41 ` patch 'net/nfb: fix array indexes in deinit functions' " Kevin Traynor
2022-03-01 10:41 ` patch 'net/nfb: fix multicast/promiscuous mode switching' " Kevin Traynor
2022-03-01 10:41 ` patch 'net/ixgbe: reset security context pointer on close' " Kevin Traynor
2022-03-01 10:41 ` patch 'net/txgbe: " Kevin Traynor
2022-03-01 10:41 ` patch 'net/iavf: reset security context pointer on stop' " Kevin Traynor
2022-03-01 10:41 ` patch 'ethdev: fix MAC address in telemetry device info' " Kevin Traynor
2022-03-01 10:41 ` patch 'net/cnxk: fix mbuf data length' " Kevin Traynor
2022-03-01 10:41 ` patch 'net/bonding: fix slaves initializing on MTU setting' " Kevin Traynor
2022-03-01 10:42 ` patch 'app/testpmd: check starting port is not in bonding' " Kevin Traynor
2022-03-01 10:42 ` patch 'common/cnxk: fix flow deletion' " Kevin Traynor
2022-03-01 10:42 ` patch 'common/cnxk: fix log level during MCAM allocation' " Kevin Traynor
2022-03-01 10:42 ` patch 'common/cnxk: fix base rule merge' " Kevin Traynor
2022-03-01 10:42 ` patch 'vhost: fix field naming in guest page struct' " Kevin Traynor
2022-03-01 10:42 ` patch 'vhost: fix unsafe vring addresses modifications' " Kevin Traynor
2022-03-01 10:42 ` patch 'common/cnxk: fix NPC key extraction validation' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/af_xdp: add missing trailing newline in logs' " Kevin Traynor
2022-03-01 10:42 ` patch 'common/cnxk: add missing checks of return values' " Kevin Traynor
2022-03-01 10:42 ` patch 'common/cnxk fix unintended sign extension' " Kevin Traynor
2022-03-01 10:42 ` patch 'common/cnxk: fix uninitialized pointer read' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/cnxk: fix uninitialized local variable' " Kevin Traynor
2022-03-01 10:42 ` patch 'common/sfc_efx/base: fix recirculation ID set in outer rules' " Kevin Traynor
2022-03-01 10:42 ` patch 'common/sfc_efx/base: add missing handler for 1-byte fields' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/sfc: fix flow tunnel support detection' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/sfc: fix memory allocation size for cache' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/af_xdp: ensure socket is deleted on Rx queue setup error' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/ice: fix overwriting of LSE bit by DCF' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/iavf: fix segmentation offload condition' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/iavf: fix segmentation offload buffer size' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/i40e: enable maximum frame size at port level' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/mlx5: fix sibling device config check' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/mlx5: fix ineffective metadata argument adjustment' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/mlx5: fix ASO CT object release' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/mlx5: fix errno update in shared context creation' " Kevin Traynor
2022-03-01 10:42 ` patch 'app/testpmd: fix GENEVE parsing in checksum mode' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/ngbe: fix debug logs' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/txgbe: " Kevin Traynor
2022-03-01 10:42 ` patch 'net/ena: remove unused enumeration' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/ena: remove unused offload variables' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/ena: skip timer if reset is triggered' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/ena: fix reset reason being overwritten' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/ena: fix meta descriptor DF flag setup' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/ena: check memory BAR before initializing LLQ' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/ena: fix checksum flag for L4' " Kevin Traynor
2022-03-01 10:42 ` patch 'common/mlx5: fix queue pair ack timeout configuration' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/mlx5: set flow error for hash list create' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/mlx5: remove unused function' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/mlx5: fix meter sub-policy creation' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/mlx5: fix entry in shared Rx queues list' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/mlx5: fix E-Switch manager vport ID' " Kevin Traynor
2022-03-01 10:42 ` patch 'doc: remove obsolete vector Tx explanations from mlx5 guide' " Kevin Traynor
2022-03-01 10:42 ` patch 'doc: replace broken links in mlx guides' " Kevin Traynor
2022-03-01 10:42 ` patch 'doc: correct name of BlueField-2 in mlx5 guide' " Kevin Traynor
2022-03-01 10:42 ` patch 'mempool/cnxk: fix batch allocation failure path' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/cnxk: fix inline device RQ tag mask' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/cnxk: register callback early to handle initial packets' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/cnxk: fix inline IPsec security error handling' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/cnxk: fix build with GCC 12' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/cnxk: fix RSS RETA table update' " Kevin Traynor
2022-03-01 10:42 ` patch 'net/i40e: fix unintentional integer overflow' " Kevin Traynor
2022-03-01 10:42 ` patch 'app/testpmd: fix raw encap of GENEVE option' " Kevin Traynor
2022-03-01 10:42 ` patch 'app/testpmd: fix build without drivers' " Kevin Traynor
2022-03-01 10:42 ` patch 'doc: add CUDA driver features' " Kevin Traynor
2022-03-01 10:42 ` patch 'test/efd: fix sockets mask size' " Kevin Traynor
2022-03-01 10:42 ` patch 'efd: fix uninitialized structure' " Kevin Traynor
2022-03-01 10:42 ` patch 'distributor: fix potential overflow' " Kevin Traynor
2022-03-01 10:42 ` patch 'eal/linux: fix illegal memory access in uevent handler' " Kevin Traynor
2022-03-01 10:42 ` patch 'devargs: fix crash with uninitialized parsing' " Kevin Traynor
2022-03-01 10:42 ` patch 'bus/pci: assign driver pointer before mapping' " Kevin Traynor
2022-03-01 10:43 ` patch 'kni: fix freeing order in device release' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220301104300.334382-31-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=brian.dooley@intel.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).