From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8FBFA034F for ; Tue, 1 Mar 2022 11:44:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2F0C426DC; Tue, 1 Mar 2022 11:44:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B1D4A40DF6 for ; Tue, 1 Mar 2022 11:44:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646131454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y2fHStt3Sye3kM8z1MYMwxJ5xljHHGvDGtfY5bKZvNs=; b=izYKOPodCXTxtVcCd4wP1RtSbosciY+2d1DlMjZqfjJf1i7Fy7M3PUALEqRX9FdZwultq9 OW1AZQrvVyGmVoYFPxcmkwJYDobGL6XpJTG1Lr6jdQG4n+HCzD+0AEwjUQnjfsewDCFwvU wc9y7Hd26hpIRNaGHdTFl5D4ZHbage4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-380-iu1aHRK6PgWBeV-fKcBUlg-1; Tue, 01 Mar 2022 05:44:11 -0500 X-MC-Unique: iu1aHRK6PgWBeV-fKcBUlg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33E3051DF; Tue, 1 Mar 2022 10:44:10 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id EB2766FB02; Tue, 1 Mar 2022 10:44:08 +0000 (UTC) From: Kevin Traynor To: Yunjian Wang Cc: Haiyue Wang , dpdk stable Subject: patch 'net/ixgbe: reset security context pointer on close' has been queued to stable release 21.11.1 Date: Tue, 1 Mar 2022 10:41:54 +0000 Message-Id: <20220301104300.334382-38-ktraynor@redhat.com> In-Reply-To: <20220301104300.334382-1-ktraynor@redhat.com> References: <20220301104300.334382-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/06/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/223010f1da4421945201d5fe2119097dc6411b01 Thanks. Kevin --- >From 223010f1da4421945201d5fe2119097dc6411b01 Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Tue, 15 Feb 2022 21:01:51 +0800 Subject: [PATCH] net/ixgbe: reset security context pointer on close [ upstream commit 848a37cead7bd604d51b5f04507fea3e59e9088e ] When ixgbe_dev_close() is cleaning up, it does not correctly set the security_ctx variable to NULL, which will lead to wild pointer. Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec") Signed-off-by: Yunjian Wang Acked-by: Haiyue Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 2f4ebb4e59..d1d0bd13df 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -3043,4 +3043,5 @@ ixgbe_dev_close(struct rte_eth_dev *dev) #ifdef RTE_LIB_SECURITY rte_free(dev->security_ctx); + dev->security_ctx = NULL; #endif -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-01 10:41:02.347297343 +0000 +++ 0038-net-ixgbe-reset-security-context-pointer-on-close.patch 2022-03-01 10:41:01.297244097 +0000 @@ -1 +1 @@ -From 848a37cead7bd604d51b5f04507fea3e59e9088e Mon Sep 17 00:00:00 2001 +From 223010f1da4421945201d5fe2119097dc6411b01 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 848a37cead7bd604d51b5f04507fea3e59e9088e ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 3d799d2187..7643842560 100644 +index 2f4ebb4e59..d1d0bd13df 100644 @@ -22 +23 @@ -@@ -3039,4 +3039,5 @@ ixgbe_dev_close(struct rte_eth_dev *dev) +@@ -3043,4 +3043,5 @@ ixgbe_dev_close(struct rte_eth_dev *dev)