From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C119A034F for ; Tue, 1 Mar 2022 11:45:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46E97426E1; Tue, 1 Mar 2022 11:45:46 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 43613426E4 for ; Tue, 1 Mar 2022 11:45:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646131544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wt0RYqIHsYMKIVUThTjA73Us/WBPZZw+r8Lg7YyqYGI=; b=guNboRGwPl59UxLlA/xMdEiXnewbMkhtPk5owP0U7mnWacaL7Xt7bWKAXPt7/4HfqoH4UA xlsbWTNnXA/Lb1eOeF6+HNTYw2g9JH7Pd6QZAcXaRSJ1S2f+ZgokZmCazAP5NHdF4My0Y2 uw59E1OhggKu6HFlxPPNzeSNcbp59jw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-61-LbebW5RVMEC-CItyXsCWqw-1; Tue, 01 Mar 2022 05:45:41 -0500 X-MC-Unique: LbebW5RVMEC-CItyXsCWqw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 51142814600; Tue, 1 Mar 2022 10:45:40 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id 120A3752D2; Tue, 1 Mar 2022 10:45:38 +0000 (UTC) From: Kevin Traynor To: Michal Krawczyk Cc: Dawid Gorecki , Shai Brandes , dpdk stable Subject: patch 'net/ena: fix meta descriptor DF flag setup' has been queued to stable release 21.11.1 Date: Tue, 1 Mar 2022 10:42:32 +0000 Message-Id: <20220301104300.334382-76-ktraynor@redhat.com> In-Reply-To: <20220301104300.334382-1-ktraynor@redhat.com> References: <20220301104300.334382-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/06/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/762277232c6cfef28380ce48630e94225a9f25e3 Thanks. Kevin --- >From 762277232c6cfef28380ce48630e94225a9f25e3 Mon Sep 17 00:00:00 2001 From: Michal Krawczyk Date: Wed, 23 Feb 2022 13:19:40 +0100 Subject: [PATCH] net/ena: fix meta descriptor DF flag setup [ upstream commit 022fb61b62623868db2ec9dbe5b1ee43a4d6cbfb ] Whenever Tx checksum offload is being used, the meta descriptor content is taken into consideration. Setting DF field properly in the meta descriptor may have huge impact on the performance both for the IPv4 and IPv6 packets. The requirements for the df field are as below: * No offload used - value doesn't matter * IPv4 - 0 or 1, depending on the DF flag in the IPv4 header * IPv6 - 1 Setting DF to 0 causes the packet to enter the slow-path in the HW and as a result can noticeable impact the performance. Moreover, as 'true' may not always be mapped to 1 depending on it's definition for the given platform/compiler, for safety DF field is being set explicitly to 1. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index a3c073a95e..87eef882db 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -349,4 +349,6 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, if (mbuf->ol_flags & RTE_MBUF_F_TX_IPV6) { ena_tx_ctx->l3_proto = ENA_ETH_IO_L3_PROTO_IPV6; + /* For the IPv6 packets, DF always needs to be true. */ + ena_tx_ctx->df = 1; } else { ena_tx_ctx->l3_proto = ENA_ETH_IO_L3_PROTO_IPV4; @@ -356,5 +358,5 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, (RTE_PTYPE_L4_NONFRAG | RTE_PTYPE_INNER_L4_NONFRAG)) - ena_tx_ctx->df = true; + ena_tx_ctx->df = 1; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-01 10:41:03.502431727 +0000 +++ 0076-net-ena-fix-meta-descriptor-DF-flag-setup.patch 2022-03-01 10:41:01.395244117 +0000 @@ -1 +1 @@ -From 022fb61b62623868db2ec9dbe5b1ee43a4d6cbfb Mon Sep 17 00:00:00 2001 +From 762277232c6cfef28380ce48630e94225a9f25e3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 022fb61b62623868db2ec9dbe5b1ee43a4d6cbfb ] + @@ -24 +25,0 @@ -Cc: stable@dpdk.org @@ -34 +35 @@ -index 0ca4269522..53a8071968 100644 +index a3c073a95e..87eef882db 100644 @@ -37 +38 @@ -@@ -625,4 +625,6 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, +@@ -349,4 +349,6 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, @@ -44 +45 @@ -@@ -632,5 +634,5 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, +@@ -356,5 +358,5 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf,