From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BF88A034F for ; Tue, 1 Mar 2022 11:45:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97205407FF; Tue, 1 Mar 2022 11:45:50 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 48D10407FF for ; Tue, 1 Mar 2022 11:45:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646131548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VwSZJ7++05OslyEuPH3zMgnDbf9PA5jkYa0d/g4FPLA=; b=Y2tjD3FO3cR9wrIa6OowqkQHSnGnWqFPJ/RDnyyYgikJ1gElyPKOYylQirTdqXXVUnxUcv lbwyVe6pyi9eAQpCmzeborVbjFPTqdrivYCrCuwBLMe/3zhT5BiUIqajnjbSvwQI3navmQ M6Esv/tAtyPS6LJezdxI0Vi6PJb+EMs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-299-2PAAqIoSPYCSla8HYXzJZg-1; Tue, 01 Mar 2022 05:45:45 -0500 X-MC-Unique: 2PAAqIoSPYCSla8HYXzJZg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 91EFB51E0; Tue, 1 Mar 2022 10:45:44 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8DD0A6FB02; Tue, 1 Mar 2022 10:45:43 +0000 (UTC) From: Kevin Traynor To: Yajun Wu Cc: Matan Azrad , dpdk stable Subject: patch 'common/mlx5: fix queue pair ack timeout configuration' has been queued to stable release 21.11.1 Date: Tue, 1 Mar 2022 10:42:35 +0000 Message-Id: <20220301104300.334382-79-ktraynor@redhat.com> In-Reply-To: <20220301104300.334382-1-ktraynor@redhat.com> References: <20220301104300.334382-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/06/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b8bc6f4256a25a01c7ac787b68823c6e95a9e7b9 Thanks. Kevin --- >From b8bc6f4256a25a01c7ac787b68823c6e95a9e7b9 Mon Sep 17 00:00:00 2001 From: Yajun Wu Date: Mon, 14 Feb 2022 08:03:19 +0200 Subject: [PATCH] common/mlx5: fix queue pair ack timeout configuration MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 05b54bf0892dcd1e3698ba86a297722b7566cc10 ] VDPA driver creates two QPs(1 queue pair include 1 send queue and 1 receive queue) per virtio queue to get traffic events from NIC to SW. Two QPs(called FW QP and SW QP) are created as loopback QP and FW QP'SQ is connected to SW QP'RQ internally. When packet receive or send out, HW will send WQE by FW QP'SQ, then SW will get CQE from the CQ of SW QP. With large scale and heavy traffic, the SQ's request may fail to get ACK from RQ HW, because HW is busy. SQ will retry the request with qpc.retry_count times and each time wait for 4.096 uS *2^(ack_timeout) for the response. If still can’t get RQ’s HW response, SQ will go to an error state. 16 is experienced value. It should not be too high or too low. Too high will make QP waits too long in case it’s packet drop. Too low will cause QP to go to an error state(retry-exceeded) easily. Fixes: 15c3807e86ab ("common/mlx5: support DevX QP operations") Signed-off-by: Yajun Wu Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index 2e807a0829..7732613c69 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -2280,5 +2280,5 @@ mlx5_devx_cmd_modify_qp_state(struct mlx5_devx_obj *qp, uint32_t qp_st_mod_op, qpc = MLX5_ADDR_OF(rtr2rts_qp_in, &in, qpc); MLX5_SET(rtr2rts_qp_in, &in, qpn, qp->id); - MLX5_SET(qpc, qpc, primary_address_path.ack_timeout, 14); + MLX5_SET(qpc, qpc, primary_address_path.ack_timeout, 16); MLX5_SET(qpc, qpc, log_ack_req_freq, 0); MLX5_SET(qpc, qpc, retry_count, 7); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-01 10:41:03.588435064 +0000 +++ 0079-common-mlx5-fix-queue-pair-ack-timeout-configuration.patch 2022-03-01 10:41:01.401244118 +0000 @@ -1 +1 @@ -From 05b54bf0892dcd1e3698ba86a297722b7566cc10 Mon Sep 17 00:00:00 2001 +From b8bc6f4256a25a01c7ac787b68823c6e95a9e7b9 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 05b54bf0892dcd1e3698ba86a297722b7566cc10 ] + @@ -29 +30,0 @@ -Cc: stable@dpdk.org