From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CE1CA034F for ; Tue, 1 Mar 2022 11:46:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79BC0426DE; Tue, 1 Mar 2022 11:46:12 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A6A20407FF for ; Tue, 1 Mar 2022 11:46:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646131571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j+zjvudrVjuPXWwCIvsNEFhpqUHzI1J127XZOzdMS4c=; b=FOJVnIiszPQM8yaROb0ARJtcEjYfAQODCnCgD3xmEQB/IMYofABFIKMP4GcHSUXsRqSiv/ HJvWvfBaR78SrKnq5hqjxQ+ABfezJmCCccMN+CKKkQ1ZSJIIjQ7vrcd7DVsRq6Y4NsOrkV RpBRclyQDNWTfJqpkFvs6MVvA7rcmVM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-139-UrB6ZxPuOjyYu3Xf3BB7RA-1; Tue, 01 Mar 2022 05:46:08 -0500 X-MC-Unique: UrB6ZxPuOjyYu3Xf3BB7RA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EC9B5801AB2; Tue, 1 Mar 2022 10:46:06 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id BF0B0721DF; Tue, 1 Mar 2022 10:46:05 +0000 (UTC) From: Kevin Traynor To: Steve Yang Cc: Ferruh Yigit , dpdk stable Subject: patch 'net/i40e: fix unintentional integer overflow' has been queued to stable release 21.11.1 Date: Tue, 1 Mar 2022 10:42:50 +0000 Message-Id: <20220301104300.334382-94-ktraynor@redhat.com> In-Reply-To: <20220301104300.334382-1-ktraynor@redhat.com> References: <20220301104300.334382-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/06/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/7565e1a51fdb4940e70d7f8ab15fac6ab048e192 Thanks. Kevin --- >From 7565e1a51fdb4940e70d7f8ab15fac6ab048e192 Mon Sep 17 00:00:00 2001 From: Steve Yang Date: Fri, 25 Feb 2022 02:39:47 +0000 Subject: [PATCH] net/i40e: fix unintentional integer overflow [ upstream commit df5807658026e7b18493a6c8ebf0e47adee26b4d ] Cast 1 to type uint64_t to avoid overflow. CID 375812 (#1 of 1): Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) overflow_before_widen: Potentially overflowing expression 1 << 2 * i + 1 with type int (32 bits, signed) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type uint64_t (64 bits, unsigned). Coverity issue: 375812 Fixes: 5fec01c35c49 ("net/i40e: support Linux VF to configure IRQ link list") Signed-off-by: Steve Yang Reviewed-by: Ferruh Yigit --- drivers/net/i40e/i40e_pf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 2435a8a070..15d9ff868f 100644 --- a/drivers/net/i40e/i40e_pf.c +++ b/drivers/net/i40e/i40e_pf.c @@ -598,5 +598,5 @@ i40e_pf_config_irq_link_list(struct i40e_pf_vf *vf, for (i = 0; i < sizeof(vvm->rxq_map) * BITS_PER_CHAR; i++) { if (tempmap & 0x1) - linklistmap |= (1 << (2 * i)); + linklistmap |= RTE_BIT64(2 * i); tempmap >>= 1; } @@ -605,5 +605,5 @@ i40e_pf_config_irq_link_list(struct i40e_pf_vf *vf, for (i = 0; i < sizeof(vvm->txq_map) * BITS_PER_CHAR; i++) { if (tempmap & 0x1) - linklistmap |= (1 << (2 * i + 1)); + linklistmap |= RTE_BIT64(2 * i + 1); tempmap >>= 1; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-01 10:41:03.966377531 +0000 +++ 0094-net-i40e-fix-unintentional-integer-overflow.patch 2022-03-01 10:41:01.462244130 +0000 @@ -1 +1 @@ -From df5807658026e7b18493a6c8ebf0e47adee26b4d Mon Sep 17 00:00:00 2001 +From 7565e1a51fdb4940e70d7f8ab15fac6ab048e192 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit df5807658026e7b18493a6c8ebf0e47adee26b4d ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org