From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED880A034F for ; Tue, 1 Mar 2022 11:46:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E3561426E4; Tue, 1 Mar 2022 11:46:17 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2511840DF6 for ; Tue, 1 Mar 2022 11:46:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646131576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SzowQG42iJkabHP17BnciU0lCAAR3rBI6wWPxRrrtVw=; b=hSwJ57CSnqHHgKtxrte0yRUDbpxM6vXLUvqfCN/m+IdWEcsUT4unxNtO51NXniXf38jkgm NWnVQYvyBdaxrJmibIyvo7W32snA11uj/kVGuPH6NMf/8FVaP9BsnVdSYB285oRkt7l1YC GmtJKREqxop2y1n6w5KH0SfQAnTau20= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-556-A53LA3oLM9Sunp7bZw-QmA-1; Tue, 01 Mar 2022 05:46:13 -0500 X-MC-Unique: A53LA3oLM9Sunp7bZw-QmA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 851E61868335; Tue, 1 Mar 2022 10:46:12 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8294F721DF; Tue, 1 Mar 2022 10:46:11 +0000 (UTC) From: Kevin Traynor To: Pablo de Lara Cc: Yipeng Wang , dpdk stable Subject: patch 'test/efd: fix sockets mask size' has been queued to stable release 21.11.1 Date: Tue, 1 Mar 2022 10:42:54 +0000 Message-Id: <20220301104300.334382-98-ktraynor@redhat.com> In-Reply-To: <20220301104300.334382-1-ktraynor@redhat.com> References: <20220301104300.334382-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/06/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/8fdb8b8a7d8a0bba1c1ee57e6253f5b64b0b3af2 Thanks. Kevin --- >From 8fdb8b8a7d8a0bba1c1ee57e6253f5b64b0b3af2 Mon Sep 17 00:00:00 2001 From: Pablo de Lara Date: Fri, 25 Feb 2022 09:27:44 +0000 Subject: [PATCH] test/efd: fix sockets mask size [ upstream commit 3b0e34e80b55bbd683f4aa8257e25cbea029489b ] Constant value 1 has a size of 32 bits, and shifting it more than 32 bits to the left overflows. 1ULL is needed to be able to get a 64-bit value. Coverity ID: 375846 Fixes: 8751a7e9832b ("efd: allow more CPU sockets in table creation") Signed-off-by: Pablo de Lara Acked-by: Yipeng Wang --- app/test/test_efd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_efd.c b/app/test/test_efd.c index 1b249e0447..c10c48cf37 100644 --- a/app/test/test_efd.c +++ b/app/test/test_efd.c @@ -99,5 +99,5 @@ static inline uint64_t efd_get_all_sockets_bitmask(void) const int val_true = 1, val_false = 0; for (i = 0; i < rte_lcore_count(); i++) { - all_cpu_sockets_bitmask |= 1 << rte_lcore_to_socket_id(next_lcore); + all_cpu_sockets_bitmask |= 1ULL << rte_lcore_to_socket_id(next_lcore); next_lcore = rte_get_next_lcore(next_lcore, val_false, val_true); } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-01 10:41:04.060784594 +0000 +++ 0098-test-efd-fix-sockets-mask-size.patch 2022-03-01 10:41:01.482244134 +0000 @@ -1 +1 @@ -From 3b0e34e80b55bbd683f4aa8257e25cbea029489b Mon Sep 17 00:00:00 2001 +From 8fdb8b8a7d8a0bba1c1ee57e6253f5b64b0b3af2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3b0e34e80b55bbd683f4aa8257e25cbea029489b ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 7bea674086..fa29e8f97a 100644 +index 1b249e0447..c10c48cf37 100644 @@ -23 +24 @@ -@@ -108,5 +108,5 @@ static inline uint64_t efd_get_all_sockets_bitmask(void) +@@ -99,5 +99,5 @@ static inline uint64_t efd_get_all_sockets_bitmask(void)