From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 121B2A034F for ; Tue, 1 Mar 2022 11:46:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D49F407FF; Tue, 1 Mar 2022 11:46:20 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 501E7426E8 for ; Tue, 1 Mar 2022 11:46:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646131577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XdEqJT/22XMLRAod4zTJFTuI2XRdioG0Q1YX0uXzCjg=; b=ej1kd22PgUlgygD1V4frUuHMV7DFfwZNStT4SqaJs7Qborq1nl3ue0er77oH0RReW3WXJB rOnzYouliQUVNN4O4wzXgtUIF2ZSg2n6GwETeMfSolOqBNd5wrNrDW6yGNeso85mxtBjlj hAIZGV5JXQwVAei3IJkf/AK7N7ktSu0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-562-QRmNyx2oN2GNfYaiG3jj0A-1; Tue, 01 Mar 2022 05:46:14 -0500 X-MC-Unique: QRmNyx2oN2GNfYaiG3jj0A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EF50951DC; Tue, 1 Mar 2022 10:46:13 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC77F721DF; Tue, 1 Mar 2022 10:46:12 +0000 (UTC) From: Kevin Traynor To: Pablo de Lara Cc: Yipeng Wang , dpdk stable Subject: patch 'efd: fix uninitialized structure' has been queued to stable release 21.11.1 Date: Tue, 1 Mar 2022 10:42:55 +0000 Message-Id: <20220301104300.334382-99-ktraynor@redhat.com> In-Reply-To: <20220301104300.334382-1-ktraynor@redhat.com> References: <20220301104300.334382-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/06/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/30b5a4b8889977dc4adf1f5bd906a530634f0db4 Thanks. Kevin --- >From 30b5a4b8889977dc4adf1f5bd906a530634f0db4 Mon Sep 17 00:00:00 2001 From: Pablo de Lara Date: Fri, 25 Feb 2022 09:27:45 +0000 Subject: [PATCH] efd: fix uninitialized structure [ upstream commit ecda2c40ac549f2ebd1e8be6bf0a96c4aba6bf36 ] Coverity flags that both elements of efd_online_group_entry are used uninitialized. This is OK because this structure is initially used for starting values, so any value is OK. Coverity ID: 375868 Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Signed-off-by: Pablo de Lara Acked-by: Yipeng Wang --- lib/efd/rte_efd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c index 86ef46863c..6c794d7750 100644 --- a/lib/efd/rte_efd.c +++ b/lib/efd/rte_efd.c @@ -1166,5 +1166,5 @@ rte_efd_update(struct rte_efd_table * const table, const unsigned int socket_id, uint32_t chunk_id = 0, group_id = 0, bin_id = 0; uint8_t new_bin_choice = 0; - struct efd_online_group_entry entry; + struct efd_online_group_entry entry = {{0}}; int status = efd_compute_update(table, socket_id, key, value, -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-01 10:41:04.080055199 +0000 +++ 0099-efd-fix-uninitialized-structure.patch 2022-03-01 10:41:01.483244134 +0000 @@ -1 +1 @@ -From ecda2c40ac549f2ebd1e8be6bf0a96c4aba6bf36 Mon Sep 17 00:00:00 2001 +From 30b5a4b8889977dc4adf1f5bd906a530634f0db4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ecda2c40ac549f2ebd1e8be6bf0a96c4aba6bf36 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 560cd78961..bbc6fc585d 100644 +index 86ef46863c..6c794d7750 100644 @@ -24 +25 @@ -@@ -1163,5 +1163,5 @@ rte_efd_update(struct rte_efd_table * const table, const unsigned int socket_id, +@@ -1166,5 +1166,5 @@ rte_efd_update(struct rte_efd_table * const table, const unsigned int socket_id,