From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 938ECA04A4 for ; Tue, 1 Mar 2022 13:28:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87A8A426F6; Tue, 1 Mar 2022 13:28:47 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2080.outbound.protection.outlook.com [40.107.237.80]) by mails.dpdk.org (Postfix) with ESMTP id BFE9140DF6; Tue, 1 Mar 2022 13:28:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HR1VCOu3tRJKVg4cWOYRspKHz7L0gRIo/2IV87Nyua1QkdVX0uNQtW1u1GLdwcOu8c2TNXa+ZeXh/dBD+EWN0BTw/QFNzRe/SGjWHuf4SgJKq0W5kFitdIGiapjCgwyG2p+C7/5mOUV6x0vCBtKzoJx3jG+UCZY2miWDsNkXck0KxyzSFHLx/6Cu79klu1eBJcwhiPD4ilWY5n1s8u0JRlZLXHJdP7vgTPMFLOeqDQRUF0Gfp1JFwsx4SwXMOYTL5SB5pjADLRDeF0EKm9P4YgpGlmugG4FdkxU0FlGJIzSui0xS1WvlB08UJ4tW77mV8lcsf4Jmy7PM7v98joCsmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gik3Nba/NLrvdiZ3hMzJ4/usQObk0Di4St2HTCWaIac=; b=Tz3dYECtqqNiUwq+gPULx2um9yniLkI46bKWp3XZwsupQfe0uXc7FIB6JQAJPELBe/AIdgD9e5N/HEymNLCIZYs+loyG1iT7HPldM2Jtnt1Uy6mihbK8y+wwUK7m5Qh5ByVH3eaJ4MrbjynVdBGL3hZ9ord666WRHpc0N1tB5nLZk7iwuSdd9+5VYuCpxXLAR3VQy0OB+6nue864JEZfH2h2gg0P3+ELoSe4TRN7nkV8ObMeutVO0EvqwO6qF3awS9umEF9d2EazVQ+td0mI+4PizCAsNpaavS3mP6uZQkub5tRiCNy34P+FpWAGMTidSqaPTg4SJDYqu9ju07mCmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.238) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gik3Nba/NLrvdiZ3hMzJ4/usQObk0Di4St2HTCWaIac=; b=qysQckbCpkfX/NXomTjGL8JLK7AvIpgom+nhooaP0muytTGVElKFVtn7ImgT7Y3bOTa9/80piYqtDpExSOfkURAAEYJNnzJnsTxy6np+f4JRa+NPs+PIyOTtu070rpKUGNSVDDplgp3Dd1xm5fwiHF14KoVYPacvcf6uxVF3tk8VxrpBQEhten4UfTkyVsPSfjM5WNqx3XxYMXwiJN5QLjfszM0Fw+FBGCb41xIV6IwQyPB76Cmvr1m7vdUbW5KpNaXaBzq7vnOCvJcccb85g6KYhxpPDo8wlaPKFUEB8PJcHVyg1B2f3F599cDL40ZOJPdMDkEtOmgEGM/U6NG2IQ== Received: from DM5PR18CA0068.namprd18.prod.outlook.com (2603:10b6:3:22::30) by DM6PR12MB4811.namprd12.prod.outlook.com (2603:10b6:5:1fb::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Tue, 1 Mar 2022 12:28:43 +0000 Received: from DM6NAM11FT062.eop-nam11.prod.protection.outlook.com (2603:10b6:3:22:cafe::b1) by DM5PR18CA0068.outlook.office365.com (2603:10b6:3:22::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26 via Frontend Transport; Tue, 1 Mar 2022 12:28:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.238) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.238 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.238; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.238) by DM6NAM11FT062.mail.protection.outlook.com (10.13.173.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5017.22 via Frontend Transport; Tue, 1 Mar 2022 12:28:42 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL105.nvidia.com (10.27.9.14) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 1 Mar 2022 12:28:42 +0000 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9; Tue, 1 Mar 2022 04:28:38 -0800 From: Gregory Etelson To: CC: , , , , Viacheslav Ovsiienko Subject: [PATCH] net/mlx5: fix flex item header length translation Date: Tue, 1 Mar 2022 14:28:24 +0200 Message-ID: <20220301122825.32056-1-getelson@nvidia.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 13b8ba76-1a55-425f-9e64-08d9fb7f05f7 X-MS-TrafficTypeDiagnostic: DM6PR12MB4811:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: meC1wDBZD5JcTl0K+pRBzeQ8RElDCQW60R3b1fnZFz8EKX9gqh+7BDG/4U/wYy5uu+dIh2lRRCE9nDynj3w2CXcPbSeCjhB5HCrfXBGiHQUDOLDa59VqPG7HJu+yzTEhDa7SP/O3RJ0X7/TO6ZZJIdSIO+t3F5+DhyVe70kPpF0TOsoRcfoNbUR8nATNST1bMtFM40wqdjepoDOWcuzjtlF3syoRvb565cb6Mvy6DqK4jUK0+EIETL5LBfpJTvj1u8Ys3oE5P6FKLQrpFtSJiKZyK5rdTvMPa/k+QvSt7QXn9CzLj3GDAfDHr7ZnxGUMyy9iub0jbgDrPiqSrj1v/Vz2NKaYdIHI744Z6eF6lx2uaZ3ilQCzqKX6/FmsA+88T8RBoHlNiDIFzQtwQTzSE7xAjd1mk2wJUl0ERFLYZPFE9OL0eI+JRUkeI5xjBfkzvrxnVHdV5JLBtw9hXVHOu6TeEFZHQz/xkvCu/XyUr8VCQtKkeNVYT54jE+21gGSPRbHdgaJbVCh8rq2e25QgX8qVcj2jsBnsWrDhmzFz4MJ9y9sjvDeRE/NcfGucpN6TifdsjHwpxutGIzdjx51A9Uc0mZ1qhdvGj/1h2M/LUGanXl2K0d6aPrdhO6Izy0XPxQa5m05MpLcVNU+/rPvdrOh1k2nVk/3pbl4iB+QQe9c31U4pg/ojNxYVfBhil4oBEEa8UlR17qfF0XLA50+nMA== X-Forefront-Antispam-Report: CIP:12.22.5.238; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(81166007)(356005)(6666004)(36756003)(7696005)(36860700001)(40460700003)(8936002)(2616005)(47076005)(83380400001)(508600001)(55016003)(54906003)(426003)(336012)(6916009)(1076003)(86362001)(107886003)(316002)(5660300002)(16526019)(6286002)(26005)(186003)(8676002)(70586007)(70206006)(82310400004)(2906002)(4326008)(450100002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 12:28:42.7918 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 13b8ba76-1a55-425f-9e64-08d9fb7f05f7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.238]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT062.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4811 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Flex item API provides support for network header with a fixed and variable lengths. When PMD compiles a new flex item object configuration it converts RTE parameters into matching PMD PARSE_GRAPH parameters and checks the parameter values against port capabilities. Current implementation mismatched PARSE_GRAPH configuration fields for the fixed size header. Cc: stable@dpdk.org Fixes: b293e8e49d78 ("net/mlx5: translate flex item configuration") Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_flex.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_flex.c b/drivers/net/mlx5/mlx5_flow_flex.c index 26f0dfa36f..fb08910ddb 100644 --- a/drivers/net/mlx5/mlx5_flow_flex.c +++ b/drivers/net/mlx5/mlx5_flow_flex.c @@ -382,15 +382,11 @@ mlx5_flex_translate_length(struct mlx5_hca_flex_attr *attr, return rte_flow_error_set (error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, NULL, "unsupported header length field mode (FIXED)"); - if (attr->header_length_mask_width < field->field_size) - return rte_flow_error_set - (error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, NULL, - "header length field width exceeds limit"); - if (field->offset_shift < 0 || - field->offset_shift > attr->header_length_mask_width) + if (field->field_size || + field->offset_mask || field->offset_shift) return rte_flow_error_set (error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, NULL, - "invalid header length field shift (FIXED"); + "invalid fields for fixed mode"); if (field->field_base < 0) return rte_flow_error_set (error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, NULL, -- 2.34.1