From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F910A04A4 for ; Wed, 2 Mar 2022 12:19:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7FEDB40141; Wed, 2 Mar 2022 12:19:58 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2081.outbound.protection.outlook.com [40.107.220.81]) by mails.dpdk.org (Postfix) with ESMTP id B39A040141; Wed, 2 Mar 2022 12:19:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TO6Z33uNdyVaZkBBRhV37kgqx5bHQJxM+9biQB05uOnzgpGYvryl491fzi78gRq7TGB9AEB+pWJi/VpabFXBV509RHawed8FJkF0hajJDqEYaNNLl5Y5e6pJxjtwK/qlD92j543t/uYRLUkQQNoz0AKCe47J9jWt/cdnD67aeqywKNT2KOEzjMDN2+oljBMjAMfaUnAZX1uV08dsgtkCy+WwjjnHt22lw7CJcYD5ocC42Or86n72ptFRBpqE2dmhOpsLd6ihUFyp9i0TRwOrgnBvlLzP9LgeWh3nbcJ8ix3Anwhz4YTEY28yUkyaJqxv0jCnbiIBOPrMYFUtK/G1tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fBAJ7G5bBiQzQMr6UquCucv84WmDFwjJXAkFh3ECWow=; b=j1JQ6PnbV8/CD3Ow++6mFbsKy3+RBg3dr4tFh5AZ9SaS6oPA0pP7dG48jAAwa9++xTiMzGlU7QfCyipugxmFHHcqBbuMFq+IiAY9e+2FBDx4gKdzd3uqKqlSHxBv7spd0pRPn0ZmeKULbyiVygJDlmHgYqDigDIFOqLQNLOI2UTyHDCC9qL13fsYlsvu19BqcV/SI/+5EZ4IwcL4AYzm8X1GAxFht5Y/EOHq2Zc7T6NloU2+X6Cz9u+FqfD5Cvp/n2WNUrdFi6FeEfctJaQMgTxLxYcpM53tpqtHcxkTWVw/Mg7ixl8kYmWIHsXVdOEhoE0VE5od1UF3jqInsFtzYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.236) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fBAJ7G5bBiQzQMr6UquCucv84WmDFwjJXAkFh3ECWow=; b=cgxd2GxTXGrASH9ipHS4dCptMUkK5laVw2gqwmSHXeuk9Uh0S+DxyYG7/Mo/ZBTRSAAfwH1zCP5Nxd6zwfkuznYfDg0Nynenr6xSp4OFLazllH1YKfr9bVbObuzYQA44ke97Dj4piEDoRcsAHmS40pMRdcSYKIt7jpCXQjSqxwnwtKm3vbcPoExdxyj7J93mzKLHWYyglAsPblRNW5nM70oye/J2/N2SCtfqEhse44r9ESNjmHQ2Fq2gRv5ewD7GBM6ufxpKu5HSTdmc50zyJhR2uRYkfEXGcR24y3Q6uMTnLuwZSby/vBZXpJyEV7Ta0XcF4C5/L/dUqzFn3nMzsw== Received: from DM5PR07CA0153.namprd07.prod.outlook.com (2603:10b6:3:ee::19) by BY5PR12MB4886.namprd12.prod.outlook.com (2603:10b6:a03:1c5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Wed, 2 Mar 2022 11:19:55 +0000 Received: from DM6NAM11FT050.eop-nam11.prod.protection.outlook.com (2603:10b6:3:ee:cafe::67) by DM5PR07CA0153.outlook.office365.com (2603:10b6:3:ee::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14 via Frontend Transport; Wed, 2 Mar 2022 11:19:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.236) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.236 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.236; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.236) by DM6NAM11FT050.mail.protection.outlook.com (10.13.173.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5038.14 via Frontend Transport; Wed, 2 Mar 2022 11:19:54 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL109.nvidia.com (10.27.9.19) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 2 Mar 2022 11:19:53 +0000 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9; Wed, 2 Mar 2022 03:19:50 -0800 From: Rongwei Liu To: , , , , Suanming Mou CC: , , Subject: [PATCH v2] net/mlx5: fix shared RSS destroy failure Date: Wed, 2 Mar 2022 13:19:38 +0200 Message-ID: <20220302111938.839522-1-rongweil@nvidia.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5c1d945-c50d-43bb-8833-08d9fc3e93ab X-MS-TrafficTypeDiagnostic: BY5PR12MB4886:EE_ X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pulf3/zHASdM7ndOXjvRAxuXTQ9HMtux1SEhz1NMHPNCiIRDcIkZ8vObV37QMZ+HXCJ22AR0QZzitsBwPFnqImN3M03Y4ghwOLqMNrplSoL1c/QlW4QZ2g7JEi33JWzH7DMG2nRiGTJyLhtN2Hp3Cg95Xy+A37RleyUpCo8mynMqP5adhAycDpXZivWs3PZnbZXqq1OITZhJzWyvCs1CRkg5MKfqS2wN7LkvWOsEXjURbBp92KDWddMLknji30yE7qN45J++/94k8zUr16ZZ3rWxzzjH5mXyKCqbo/VgM0NhykvADSa/EaSp0EBHFKfRGTivBYPpoWPrerGK86eUbfyHMjESWxEFjasWT2GbE1WfsOUxFMpCJqST2Ir1qjeFz5SwQgRdWiyPDbiVOJ+RPXakqIWAuNa/JS01Z3byl2BX+oiiZkeJyD+lSm92WjXmKuFuxOkoOW5EjlU9YBb5v/ZYRihJLRnCiPM/ahbHnyalNsV+2k5H5HtUvVcg/Acvs9QhbfCE56QDJvS0GPcvCVLr/XeITpcX1ouqDSzXOxKP4kNJZmLF2NoCGtpplw5cCpgpuQ5S5srO1i0SrWPUFdBblDA/QMhFMw6K3GPgr0LFlw938kifopeP7yCtlTMKfxYca3RGuYD72VNLyqqqpFyrCPaNA9/7RxY4iTb4D0SkPtznPqFZZyR41Yvzx1y3C1eQbIB2SUYBlfdCYYle5g== X-Forefront-Antispam-Report: CIP:12.22.5.236; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(7696005)(6666004)(40460700003)(54906003)(6636002)(110136005)(6286002)(316002)(508600001)(47076005)(55016003)(36756003)(8936002)(356005)(36860700001)(81166007)(16526019)(26005)(426003)(8676002)(2906002)(186003)(5660300002)(1076003)(336012)(4326008)(82310400004)(86362001)(70206006)(70586007)(2616005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 11:19:54.4050 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c5c1d945-c50d-43bb-8833-08d9fc3e93ab X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.236]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT050.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4886 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org When both shared and non-shared RSS actions are present in single flow rule shared RSS index is unset by mistake. For example: 1. flow indirect_action 0 create action_id 3 ingress action RSS ... 2. set sample_actions 0 mark id 43690 / queue index 0 / end 3. flow create 0 ingress group 107 pattern eth / sample ratio 2 index 0 / indirect 3 / end PMD translates the indirect action to a shared RSS description at first. In the split prefix flow, RSS->shared_RSS is unset when translating sample queue action, the subfix flow will treat the RSS as non-shared. Fixes: 8e61555657b2 ("net/mlx5: fix shared RSS and mark actions combination") Cc: stable@dpdk.org Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 0b9df5f6f1..daaa104da9 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -11206,6 +11206,7 @@ flow_dv_hrxq_prepare(struct rte_eth_dev *dev, uint32_t *hrxq_idx) { struct mlx5_flow_handle *dh = dev_flow->handle; + uint32_t shared_rss = rss_desc->shared_rss; struct mlx5_hrxq *hrxq; MLX5_ASSERT(rss_desc->queue_num); @@ -11217,6 +11218,7 @@ flow_dv_hrxq_prepare(struct rte_eth_dev *dev, rss_desc->queue_num = 1; hrxq = mlx5_hrxq_get(dev, rss_desc); *hrxq_idx = hrxq ? hrxq->idx : 0; + rss_desc->shared_rss = shared_rss; return hrxq; } -- 2.27.0