From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9919FA00C2 for ; Tue, 8 Mar 2022 15:16:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 948A0407FF; Tue, 8 Mar 2022 15:16:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3AAEC4068B for ; Tue, 8 Mar 2022 15:16:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646748959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ChEiChbFnKkyHWZLdBiil5A58SoW3EwL7RnHOAcX6w0=; b=HrVeHkwu3+S9n/+6aa6ozopJ3eaW7us0AeOojlkNhkakP6HMXcGaqkqBZnbz36rlLR4kfF GMR+75qJ2Tg9g1j4sPXolLJE9f33KYBffqNbGcShmD1LMD/snIHAMlPAhWhxQWRvjeAr/5 SZpfctzaiF5iblLwTPIhL0hpqA4hTLE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-350-O8O8pkq9PzK-IxGWFZlYlQ-1; Tue, 08 Mar 2022 09:15:57 -0500 X-MC-Unique: O8O8pkq9PzK-IxGWFZlYlQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DDCD21091DA1; Tue, 8 Mar 2022 14:15:55 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.190]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91E1384629; Tue, 8 Mar 2022 14:15:54 +0000 (UTC) From: Kevin Traynor To: Weiguo Li Cc: Jiawen Wu , dpdk stable Subject: patch 'net/txgbe: fix queue statistics mapping' has been queued to stable release 21.11.1 Date: Tue, 8 Mar 2022 14:14:36 +0000 Message-Id: <20220308141500.286915-21-ktraynor@redhat.com> In-Reply-To: <20220308141500.286915-1-ktraynor@redhat.com> References: <20220308141500.286915-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/14/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/0316ab01179c34b97d760a32a82975b2960ef117 Thanks. Kevin --- >From 0316ab01179c34b97d760a32a82975b2960ef117 Mon Sep 17 00:00:00 2001 From: Weiguo Li Date: Tue, 1 Mar 2022 14:08:30 +0800 Subject: [PATCH] net/txgbe: fix queue statistics mapping [ upstream commit f69467177fa34afaeeeae81ad83142121ee1bc98 ] Since boolean value is in 0 and 1, it's strange to combines a boolean value with a bit operator. Thus it's highly possible a typo error with "if (A & !B)", and more probably to use "if (A & ~B)" instead. Fixes: c1d4e9d37abd ("net/txgbe: add queue stats mapping") Signed-off-by: Weiguo Li Acked-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 1d1dd430dc..49948e62bc 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -377,5 +377,5 @@ txgbe_dev_queue_stats_mapping_set(struct rte_eth_dev *eth_dev, return -ENOSYS; - if (stat_idx & !QMAP_FIELD_RESERVED_BITS_MASK) + if (stat_idx & ~QMAP_FIELD_RESERVED_BITS_MASK) return -EIO; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-08 13:55:28.966163873 +0000 +++ 0021-net-txgbe-fix-queue-statistics-mapping.patch 2022-03-08 13:55:28.461315067 +0000 @@ -1 +1 @@ -From f69467177fa34afaeeeae81ad83142121ee1bc98 Mon Sep 17 00:00:00 2001 +From 0316ab01179c34b97d760a32a82975b2960ef117 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f69467177fa34afaeeeae81ad83142121ee1bc98 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 19d4444748..f0994f028d 100644 +index 1d1dd430dc..49948e62bc 100644