From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B26AFA00C2 for ; Tue, 8 Mar 2022 15:16:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD2264068E; Tue, 8 Mar 2022 15:16:02 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1ABD5407FF for ; Tue, 8 Mar 2022 15:16:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646748960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/hMliUTCjq8P2gDBrnqOZk4P4RLjFOYL1ttwOWJrUew=; b=e5EUtLLUjUcBT10qXscGjdBlNsI+N1wEX4gxl5FT4+gj7/mx/xh7F2Naz1v3kHeFsp7p1n hC2aByifuN+IXJHyzOWmsjK974Ee641y0vnf0ss8s2RAC/p0QtGSxGFJ60m1zm8V6gNoes wRTXWMfcf5d314/UYBdIi3ALKj1hMMg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-219-pw1IE1zDPAqz2j8ffQBZYw-1; Tue, 08 Mar 2022 09:15:58 -0500 X-MC-Unique: pw1IE1zDPAqz2j8ffQBZYw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 841D71854E21; Tue, 8 Mar 2022 14:15:57 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.190]) by smtp.corp.redhat.com (Postfix) with ESMTP id 47CDE865A5; Tue, 8 Mar 2022 14:15:56 +0000 (UTC) From: Kevin Traynor To: Harold Huang Cc: Ferruh Yigit , dpdk stable Subject: patch 'net/kni: fix config initialization' has been queued to stable release 21.11.1 Date: Tue, 8 Mar 2022 14:14:37 +0000 Message-Id: <20220308141500.286915-22-ktraynor@redhat.com> In-Reply-To: <20220308141500.286915-1-ktraynor@redhat.com> References: <20220308141500.286915-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/14/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a6025189d23ece5b16198364c0c75726a55d9181 Thanks. Kevin --- >From a6025189d23ece5b16198364c0c75726a55d9181 Mon Sep 17 00:00:00 2001 From: Harold Huang Date: Thu, 3 Mar 2022 10:18:03 +0800 Subject: [PATCH] net/kni: fix config initialization [ upstream commit dcd398f9466fc42f09e5c725c3188d8c41bd3fbf ] When kni driver calls eth_kni_start to start device, some fields such as min_mtu and max_mtu of rte_kni_conf are not initialized. It will cause kni_ioctl_create create a kni netdevice with a random min_mtu and max_mtu value. This is unexpected and sometimes we could not change the kni device mtu with ip link command. Fixes: ff1e35fb5f83 ("kni: calculate MTU from mbuf size") Signed-off-by: Harold Huang Reviewed-by: Ferruh Yigit --- drivers/net/kni/rte_eth_kni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c index c428caf441..0532de5315 100644 --- a/drivers/net/kni/rte_eth_kni.c +++ b/drivers/net/kni/rte_eth_kni.c @@ -125,5 +125,5 @@ eth_kni_start(struct rte_eth_dev *dev) uint16_t port_id = dev->data->port_id; struct rte_mempool *mb_pool; - struct rte_kni_conf conf; + struct rte_kni_conf conf = {{0}}; const char *name = dev->device->name + 4; /* remove net_ */ -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-08 13:55:28.988071350 +0000 +++ 0022-net-kni-fix-config-initialization.patch 2022-03-08 13:55:28.461315067 +0000 @@ -1 +1 @@ -From dcd398f9466fc42f09e5c725c3188d8c41bd3fbf Mon Sep 17 00:00:00 2001 +From a6025189d23ece5b16198364c0c75726a55d9181 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit dcd398f9466fc42f09e5c725c3188d8c41bd3fbf ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org