From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45514A00C2 for ; Tue, 8 Mar 2022 15:16:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 411E740E03; Tue, 8 Mar 2022 15:16:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C2D5040696 for ; Tue, 8 Mar 2022 15:16:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646748968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EGFdDqq99wB4OUs7j5tlFer7bvf3wdasML8eKarnAo0=; b=FrQKL1Np5VvAtWV5giKAFq8MoO2CIwNrotSysItgxuxt/yId5AJZl8TzTYimZaLfKuYtJD iTrUqUzMBIyI8G6abqvm61C2ALEcTDnx8p8aQVimf6vdG5hFOUB/Yilv2Q1aUE0baboUfJ TFVpz20EX8bwiOyS8Th1I5FV9Fosvnw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-618-ylQqP_0TO4eO5RHNljzUNA-1; Tue, 08 Mar 2022 09:16:03 -0500 X-MC-Unique: ylQqP_0TO4eO5RHNljzUNA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B52C1091DA6; Tue, 8 Mar 2022 14:16:02 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.190]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0109084034; Tue, 8 Mar 2022 14:16:00 +0000 (UTC) From: Kevin Traynor To: Gregory Etelson Cc: Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: reduce flex item flow handle size' has been queued to stable release 21.11.1 Date: Tue, 8 Mar 2022 14:14:40 +0000 Message-Id: <20220308141500.286915-25-ktraynor@redhat.com> In-Reply-To: <20220308141500.286915-1-ktraynor@redhat.com> References: <20220308141500.286915-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/14/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/949a09c9ba237e3820eed2595738ef69a721075a Thanks. Kevin --- >From 949a09c9ba237e3820eed2595738ef69a721075a Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Mon, 28 Feb 2022 12:01:24 +0200 Subject: [PATCH] net/mlx5: reduce flex item flow handle size [ upstream commit cfe337e7157e7b8f9e3d136f5a1882d2af8a1dc0 ] Reduce flex item flow handle size from 32 bits to 8 bits for each flow. The patch will save memory in setups with millions of flows. Fixes: a23e9b6e3ee9 ("net/mlx5: handle flex item in flows") Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.h | 2 +- drivers/net/mlx5/mlx5_flow_dv.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h index 7fec79afb3..f8bce92e9f 100644 --- a/drivers/net/mlx5/mlx5_flow.h +++ b/drivers/net/mlx5/mlx5_flow.h @@ -699,5 +699,4 @@ struct mlx5_flow_handle { uint32_t is_meter_flow_id:1; /**< Indicate if flow_id is for meter. */ uint32_t fate_action:3; /**< Fate action type. */ - uint32_t flex_item; /**< referenced Flex Item bitmask. */ union { uint32_t rix_hrxq; /**< Hash Rx queue object index. */ @@ -715,4 +714,5 @@ struct mlx5_flow_handle { struct mlx5_flow_handle_dv dvh; #endif + uint8_t flex_item; /**< referenced Flex Item bitmask. */ } __rte_packed; diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 7d22ac388e..ce0d5b1e37 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -10197,5 +10197,5 @@ flow_dv_translate_item_flex(struct rte_eth_dev *dev, void *matcher, void *key, if (mlx5_flex_acquire_index(dev, spec->handle, true) != index) MLX5_ASSERT(false); - dev_flow->handle->flex_item |= RTE_BIT32(index); + dev_flow->handle->flex_item |= (uint8_t)RTE_BIT32(index); } mlx5_flex_flow_translate_item(dev, matcher, key, item, is_inner); @@ -14536,5 +14536,5 @@ flow_dv_destroy(struct rte_eth_dev *dev, struct rte_flow *flow) mlx5_flex_release_index(dev, index); - dev_handle->flex_item &= ~RTE_BIT32(index); + dev_handle->flex_item &= ~(uint8_t)RTE_BIT32(index); } if (dev_handle->dvh.matcher) -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-08 13:55:29.049126827 +0000 +++ 0025-net-mlx5-reduce-flex-item-flow-handle-size.patch 2022-03-08 13:55:28.481315122 +0000 @@ -1 +1 @@ -From cfe337e7157e7b8f9e3d136f5a1882d2af8a1dc0 Mon Sep 17 00:00:00 2001 +From 949a09c9ba237e3820eed2595738ef69a721075a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit cfe337e7157e7b8f9e3d136f5a1882d2af8a1dc0 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index e510921a3f..484ce5791e 100644 +index 7fec79afb3..f8bce92e9f 100644 @@ -24 +25 @@ -@@ -701,5 +701,4 @@ struct mlx5_flow_handle { +@@ -699,5 +699,4 @@ struct mlx5_flow_handle { @@ -30 +31 @@ -@@ -717,4 +716,5 @@ struct mlx5_flow_handle { +@@ -715,4 +714,5 @@ struct mlx5_flow_handle { @@ -37 +38 @@ -index 0b9df5f6f1..c4a9b022b7 100644 +index 7d22ac388e..ce0d5b1e37 100644 @@ -40 +41 @@ -@@ -10299,5 +10299,5 @@ flow_dv_translate_item_flex(struct rte_eth_dev *dev, void *matcher, void *key, +@@ -10197,5 +10197,5 @@ flow_dv_translate_item_flex(struct rte_eth_dev *dev, void *matcher, void *key, @@ -47 +48 @@ -@@ -14650,5 +14650,5 @@ flow_dv_destroy(struct rte_eth_dev *dev, struct rte_flow *flow) +@@ -14536,5 +14536,5 @@ flow_dv_destroy(struct rte_eth_dev *dev, struct rte_flow *flow)