From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA4F7A00C2 for ; Tue, 8 Mar 2022 15:16:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AC4D410E6; Tue, 8 Mar 2022 15:16:19 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B40964068B for ; Tue, 8 Mar 2022 15:16:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646748978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0Xy5a01R8AhG8k60Wbk83DSWEa+SnFYbQ41hLb2Yhuc=; b=LSf1SZosxYg5pp/78bu9K0faq2FtkcfbnwykBsOGtIt6y5ZaySUyDxZIDHH8xjDF1AmWln vSjpHDiEY0ivzv55FAPqpr0FSbt1dwhlms2WCBqslTLcdufZpx8OUsZSFUHIAhW5D2SfJ8 5zkvtvKTezG8exG+wm24eL2XBZZDtlo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-150-lJPw53elNpSLTf7WBiaHRg-1; Tue, 08 Mar 2022 09:16:16 -0500 X-MC-Unique: lJPw53elNpSLTf7WBiaHRg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 61A521091DA3; Tue, 8 Mar 2022 14:16:15 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.190]) by smtp.corp.redhat.com (Postfix) with ESMTP id 979728659F; Tue, 8 Mar 2022 14:16:14 +0000 (UTC) From: Kevin Traynor To: Wenxuan Wu Cc: dpdk stable Subject: patch 'eal/linux: fix device monitor stop return' has been queued to stable release 21.11.1 Date: Tue, 8 Mar 2022 14:14:49 +0000 Message-Id: <20220308141500.286915-34-ktraynor@redhat.com> In-Reply-To: <20220308141500.286915-1-ktraynor@redhat.com> References: <20220308141500.286915-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/14/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b399994654309a9d38da071079c0e0e0633ed2a4 Thanks. Kevin --- >From b399994654309a9d38da071079c0e0e0633ed2a4 Mon Sep 17 00:00:00 2001 From: Wenxuan Wu Date: Fri, 11 Feb 2022 08:41:31 +0000 Subject: [PATCH] eal/linux: fix device monitor stop return [ upstream commit 4e3582ab5b49aeace3949ea4b9c6b0fddf5097a5 ] The ret value in rte_dev_event_monitor_stop stands for whether the monitor has been successfully closed, and should not bind with rte_intr_callback_unregister, so once it goes to the right exit point of rte_dev_event_monitor, the ret value should be set to 0. Also, the refmonitor count has been carefully evaluated, the value change from 1 to 0, so there is no potential memory leak failure. Fixes: 1fef6ced07f3 ("eal/linux: allow multiple starts of event monitor") Signed-off-by: Wenxuan Wu --- lib/eal/linux/eal_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c index 851789e85c..52fe336572 100644 --- a/lib/eal/linux/eal_dev.c +++ b/lib/eal/linux/eal_dev.c @@ -385,4 +385,5 @@ rte_dev_event_monitor_stop(void) rte_intr_instance_free(intr_handle); intr_handle = NULL; + ret = 0; monitor_refcount--; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-08 13:55:29.250879038 +0000 +++ 0034-eal-linux-fix-device-monitor-stop-return.patch 2022-03-08 13:55:28.506315191 +0000 @@ -1 +1 @@ -From 4e3582ab5b49aeace3949ea4b9c6b0fddf5097a5 Mon Sep 17 00:00:00 2001 +From b399994654309a9d38da071079c0e0e0633ed2a4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4e3582ab5b49aeace3949ea4b9c6b0fddf5097a5 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index e6f509bcff..02ae1cde29 100644 +index 851789e85c..52fe336572 100644 @@ -26 +27 @@ -@@ -381,4 +381,5 @@ rte_dev_event_monitor_stop(void) +@@ -385,4 +385,5 @@ rte_dev_event_monitor_stop(void)