From: christian.ehrhardt@canonical.com
To: Brian Dooley <brian.dooley@intel.com>
Cc: Akhil Goyal <gakhil@marvell.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'examples/l2fwd-crypto: fix port mask overflow' has been queued to stable release 19.11.12
Date: Wed, 9 Mar 2022 12:00:41 +0100 [thread overview]
Message-ID: <20220309110116.1295395-10-christian.ehrhardt@canonical.com> (raw)
In-Reply-To: <20220309110116.1295395-1-christian.ehrhardt@canonical.com>
Hi,
FYI, your patch has been queued to stable release 19.11.12
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/11/22. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue
This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/081049177036eeaeda700a4c8c6daf2368266016
Thanks.
Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
From 081049177036eeaeda700a4c8c6daf2368266016 Mon Sep 17 00:00:00 2001
From: Brian Dooley <brian.dooley@intel.com>
Date: Mon, 21 Feb 2022 18:06:58 +0000
Subject: [PATCH] examples/l2fwd-crypto: fix port mask overflow
[ upstream commit aaf4ac404362752e9c8effa4641bb480187d04ec ]
Coverity flags an issue with 32-bit value. If max ethports value is
configured with a value larger than 32 there will be an issue.
Coverity issue: 375863 Unintentional integer overflow
Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application")
Signed-off-by: Brian Dooley <brian.dooley@intel.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
---
examples/l2fwd-crypto/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
index 063db823bd..5d41e6cb91 100644
--- a/examples/l2fwd-crypto/main.c
+++ b/examples/l2fwd-crypto/main.c
@@ -2639,7 +2639,7 @@ initialize_ports(struct l2fwd_crypto_options *options)
last_portid = portid;
}
- l2fwd_enabled_port_mask |= (1 << portid);
+ l2fwd_enabled_port_mask |= (1ULL << portid);
enabled_portcount++;
}
--
2.35.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2022-03-09 11:57:43.908922644 +0100
+++ 0010-examples-l2fwd-crypto-fix-port-mask-overflow.patch 2022-03-09 11:57:43.332938004 +0100
@@ -1 +1 @@
-From aaf4ac404362752e9c8effa4641bb480187d04ec Mon Sep 17 00:00:00 2001
+From 081049177036eeaeda700a4c8c6daf2368266016 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit aaf4ac404362752e9c8effa4641bb480187d04ec ]
+
@@ -11 +12,0 @@
-Cc: stable@dpdk.org
@@ -20 +21 @@
-index 4d9f8861af..bbdb263143 100644
+index 063db823bd..5d41e6cb91 100644
@@ -23 +24 @@
-@@ -2719,7 +2719,7 @@ initialize_ports(struct l2fwd_crypto_options *options)
+@@ -2639,7 +2639,7 @@ initialize_ports(struct l2fwd_crypto_options *options)
next prev parent reply other threads:[~2022-03-09 11:02 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 11:00 patch 'eventdev/eth_tx: fix queue add error code' " christian.ehrhardt
2022-03-09 11:00 ` patch 'telemetry: add missing C++ guards' " christian.ehrhardt
2022-03-09 11:00 ` patch 'acl: " christian.ehrhardt
2022-03-09 11:00 ` patch 'compressdev: " christian.ehrhardt
2022-03-09 11:00 ` patch 'eventdev: " christian.ehrhardt
2022-03-09 11:00 ` patch 'kni: " christian.ehrhardt
2022-03-09 11:00 ` patch 'ethdev: fix cast for C++ compatibility' " christian.ehrhardt
2022-03-09 11:00 ` patch 'cryptodev: fix RSA key type name' " christian.ehrhardt
2022-03-09 11:00 ` patch 'doc: fix FIPS guide' " christian.ehrhardt
2022-03-09 11:00 ` christian.ehrhardt [this message]
2022-03-09 11:00 ` patch 'crypto/virtio: fix out-of-bounds access' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/nfb: fix array indexes in deinit functions' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/nfb: fix multicast/promiscuous mode switching' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/ixgbe: reset security context pointer on close' " christian.ehrhardt
2022-03-09 11:00 ` patch 'app/testpmd: check starting port is not in bonding' " christian.ehrhardt
2022-03-09 11:00 ` patch 'vhost: fix unsafe vring addresses modifications' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/af_xdp: add missing trailing newline in logs' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/ena: remove unused enumeration' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/ena: remove unused offload variables' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/ena: skip timer if reset is triggered' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/ena: fix meta descriptor DF flag setup' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/ena: fix checksum flag for L4' " christian.ehrhardt
2022-03-09 11:00 ` patch 'doc: remove obsolete vector Tx explanations from mlx5 guide' " christian.ehrhardt
2022-03-09 11:00 ` patch 'doc: replace broken links in mlx guides' " christian.ehrhardt
2022-03-09 11:00 ` patch 'app/testpmd: fix build without drivers' " christian.ehrhardt
2022-03-09 11:00 ` patch 'test/efd: fix sockets mask size' " christian.ehrhardt
2022-03-09 11:00 ` patch 'distributor: fix potential overflow' " christian.ehrhardt
2022-03-09 11:00 ` patch 'eal/linux: fix illegal memory access in uevent handler' " christian.ehrhardt
2022-03-09 11:01 ` patch 'kni: fix freeing order in device release' " christian.ehrhardt
2022-03-09 11:01 ` patch 'app/compress-perf: fix socket ID type during init' " christian.ehrhardt
2022-03-09 11:01 ` patch 'app/compress-perf: fix number of queue pairs to setup' " christian.ehrhardt
2022-03-09 11:01 ` patch 'compressdev: fix socket ID type' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/hns3: remove duplicate macro definition' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/hns3: fix RSS TC mode entry' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/hns3: fix VF " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/hns3: increase time waiting for PF reset completion' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/ixgbe: fix FSP check for X550EM devices' " christian.ehrhardt
2022-03-09 11:01 ` patch 'doc: fix typos and punctuation in flow API guide' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/mlx5: fix matcher priority with ICMP or ICMPv6' " christian.ehrhardt
2022-03-09 11:01 ` patch 'raw/ifpga: fix variable initialization in probing' " christian.ehrhardt
2022-03-09 11:01 ` patch 'app/pdump: abort on multi-core capture limit' " christian.ehrhardt
2022-03-09 11:01 ` patch 'examples/distributor: reduce Tx queue number to 1' " christian.ehrhardt
2022-03-09 11:01 ` patch 'examples/flow_classify: fix failure message' " christian.ehrhardt
2022-03-09 11:01 ` patch 'ethdev: fix doxygen comments for device info struct' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/mlx5: fix modify port action validation' " christian.ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220309110116.1295395-10-christian.ehrhardt@canonical.com \
--to=christian.ehrhardt@canonical.com \
--cc=brian.dooley@intel.com \
--cc=gakhil@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).