From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88D9BA0093 for ; Wed, 9 Mar 2022 12:02:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84433410E8; Wed, 9 Mar 2022 12:02:02 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 65BE840687 for ; Wed, 9 Mar 2022 12:02:01 +0100 (CET) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 3C26D3F1FC for ; Wed, 9 Mar 2022 11:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646823720; bh=AX+A7gX5Fxv8T9+wTQogqbFs+ax1StNiImDmmW/b1yY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gwV7ovcipJ4i954g0le0jkBI3TuJMesP892Ed7ujOR2+xPQSEcZIEMuqy6OE8LaSH f4gnsE1JQKfttYwieWa0PJsU1qYqlB2ilac9Od1Sr3bemcRp1ruB46zP7MfIbuD6pY Jb0ugw4mVqUOC19iIc7FL2MZ4xSCj1xf0U+vCznGDDjczoApb4hrquvE35gMd118ua abdvhPpvQulgZqMVfZxJ+cIWB+k/gRCTaarftBjrIHoQ+bekyjGLOWk+tJI7wTbk4j b4Lx6lPBkLXnAUw9MHIxICzhaae/eqsXof4fyA/3rQzHUurVG/BgX7xye6u8s7HoQi 6cGi6/llYIxjw== Received: by mail-wm1-f70.google.com with SMTP id h206-20020a1c21d7000000b003552c13626cso2451603wmh.3 for ; Wed, 09 Mar 2022 03:02:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AX+A7gX5Fxv8T9+wTQogqbFs+ax1StNiImDmmW/b1yY=; b=gPHnnqw/J3e6o3LkduW9ckIi5q64GQUmcDZHZ27JX0r9QZnzwixJydKyfMt1cjB8PE N1cctpQqFR5bdk37ZIMTLwSH7R9TSU4lvVrYVKVlzNeD4xX3VaLQ3icy3iQWg6zKJ0m+ zdfr54y7DaSQzkcGeFDhUDD0ojZaGqQ7gx2f7kOBu/8rijAX+7JBLW8lN2Bg8r54OZUe YL3IH0xt1ZWll1vTDkNOmJUy6i2gkqrvjTcOBQ12KVeh5OaxNYsba2Xy8XiWXvgBTmKR E6okR2yUqaW2Ivr/5WFSlZVd5AVvPKLlewSeOR5a5HBsb2D6ZdHSUinVyxB7fACWa508 x9Xw== X-Gm-Message-State: AOAM530ZOPdJvgC5RQkw8kXe8MKo/IzmQBRQ45+Yh2lysys4zALUKgW6 kHlpZn6R1d1cpN74o20HU2tDsKcTIQ/DMTH20pMjGaHrw47lUCyfhzN8FVoWs99MU1JSUUiDJHm OggLUQc/YjoUdzScUz1KzwhfN X-Received: by 2002:a05:600c:4f55:b0:381:7e8d:e4a8 with SMTP id m21-20020a05600c4f5500b003817e8de4a8mr2856683wmq.16.1646823717843; Wed, 09 Mar 2022 03:01:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJz8KKoa9TVwpY04R9H7DVzif4YUiB92cyFT6v/xD5IyZCTIK2y0J7QanV1oYsuupYmiHps9Aw== X-Received: by 2002:a05:600c:4f55:b0:381:7e8d:e4a8 with SMTP id m21-20020a05600c4f5500b003817e8de4a8mr2856670wmq.16.1646823717636; Wed, 09 Mar 2022 03:01:57 -0800 (PST) Received: from localhost.localdomain (068-133-067-156.ip-addr.inexio.net. [156.67.133.68]) by smtp.gmail.com with ESMTPSA id v14-20020adfd18e000000b0020373e5319asm1467247wrc.103.2022.03.09.03.01.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 03:01:56 -0800 (PST) From: christian.ehrhardt@canonical.com To: Brian Dooley Cc: Akhil Goyal , dpdk stable Subject: patch 'examples/l2fwd-crypto: fix port mask overflow' has been queued to stable release 19.11.12 Date: Wed, 9 Mar 2022 12:00:41 +0100 Message-Id: <20220309110116.1295395-10-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220309110116.1295395-1-christian.ehrhardt@canonical.com> References: <20220309110116.1295395-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.12 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/11/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/081049177036eeaeda700a4c8c6daf2368266016 Thanks. Christian Ehrhardt --- >From 081049177036eeaeda700a4c8c6daf2368266016 Mon Sep 17 00:00:00 2001 From: Brian Dooley Date: Mon, 21 Feb 2022 18:06:58 +0000 Subject: [PATCH] examples/l2fwd-crypto: fix port mask overflow [ upstream commit aaf4ac404362752e9c8effa4641bb480187d04ec ] Coverity flags an issue with 32-bit value. If max ethports value is configured with a value larger than 32 there will be an issue. Coverity issue: 375863 Unintentional integer overflow Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application") Signed-off-by: Brian Dooley Acked-by: Akhil Goyal --- examples/l2fwd-crypto/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 063db823bd..5d41e6cb91 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -2639,7 +2639,7 @@ initialize_ports(struct l2fwd_crypto_options *options) last_portid = portid; } - l2fwd_enabled_port_mask |= (1 << portid); + l2fwd_enabled_port_mask |= (1ULL << portid); enabled_portcount++; } -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-09 11:57:43.908922644 +0100 +++ 0010-examples-l2fwd-crypto-fix-port-mask-overflow.patch 2022-03-09 11:57:43.332938004 +0100 @@ -1 +1 @@ -From aaf4ac404362752e9c8effa4641bb480187d04ec Mon Sep 17 00:00:00 2001 +From 081049177036eeaeda700a4c8c6daf2368266016 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit aaf4ac404362752e9c8effa4641bb480187d04ec ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 4d9f8861af..bbdb263143 100644 +index 063db823bd..5d41e6cb91 100644 @@ -23 +24 @@ -@@ -2719,7 +2719,7 @@ initialize_ports(struct l2fwd_crypto_options *options) +@@ -2639,7 +2639,7 @@ initialize_ports(struct l2fwd_crypto_options *options)