From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AC1FA0093 for ; Wed, 9 Mar 2022 12:02:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2EBA40150; Wed, 9 Mar 2022 12:02:13 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id D6EC8410E8 for ; Wed, 9 Mar 2022 12:02:12 +0100 (CET) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 110C43F79C for ; Wed, 9 Mar 2022 11:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646823732; bh=H/go++586MsjL8dqY+GXMsXsjilfU56NHJ64Rz2751M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YXS82i255Ztrj5bvLxyGbqwTsB9V3yJaY1yXm6/1fIL8qf8ppFFQLM0aQ5eyH3+1O Wp8gfpY4E19X0/CnxYY4wkxk3e4jbVofk++g9JAMp72fxUA/scjX+Q12o4UEauU0hq 8fa6J8nemODee7yHbSZ+r+i3Otv5TfBGWKwTVc6b559KAkoezK34xpV6GcBR0W2uvq vg2ewZUkUfA26OMp62SQ78Mrkapa7XJwyqNBYFGRpYf971ff7X2Y3LnZwsnIEVIMh4 QSHx5snssBHlnGpXJ+96havPlEY3d8cXIHmoQvThh09AvJ7N/6q1d6dPjHTPGi41Pf qt4sf/M6TTdyg== Received: by mail-wr1-f70.google.com with SMTP id m18-20020a5d4a12000000b00203731460e6so638283wrq.3 for ; Wed, 09 Mar 2022 03:02:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H/go++586MsjL8dqY+GXMsXsjilfU56NHJ64Rz2751M=; b=ojSKbm7XfcaZskXcdFzcA0RiVWEZ3ukRgnpYK0B0X3iagtte/mc10FItIcyCqAaSf7 LmpoIYlwqVmsteJbxhZuc7SI2gRO+o4VJ+FgWdZ7wKZV/65obWX27+USrvf8LUTjD+jI sMo9W7yLDvQZw35EG2CytHa217Sr2nPHKadWCFRqcvTqXZzCxTyW2wGI2Vm6bDb2lfRW Sn0FVm1dOwcvbrtXj5e8mzCkb7a1iOQgtW/0LuizJs8vWQyheB1YzPTJxIuBbniurljS hlaIJSezEfv4K7Tqme44tcUMLm8NPVGpncO7e2oZCgiFcJYpoUp2Cx1pjpNaxRb0/qyq htBw== X-Gm-Message-State: AOAM530d9ZwmW3RyO1++8p8MScaegc2pQ5nm6LBcpsdNyhDsjp7MQ8lj E2ZkEYWvLXtN9ml0xBDBk1LM49ctdda8OsoaVOhHCsEteXaSOdy8y5RnRVIT136j+P4IVeTCERp lJUNV7Zq4Gl4DdMkZiYvrVvtD X-Received: by 2002:a1c:7919:0:b0:389:79c5:fe83 with SMTP id l25-20020a1c7919000000b0038979c5fe83mr6947746wme.173.1646823731108; Wed, 09 Mar 2022 03:02:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJwEa04t9e8e87RGQ9PWALKryQ2wv8x4jK3ytRHuK2BEP++wwYHNn3z7j9lxnGIKaNwdGzjUfA== X-Received: by 2002:a1c:7919:0:b0:389:79c5:fe83 with SMTP id l25-20020a1c7919000000b0038979c5fe83mr6947727wme.173.1646823730856; Wed, 09 Mar 2022 03:02:10 -0800 (PST) Received: from localhost.localdomain (068-133-067-156.ip-addr.inexio.net. [156.67.133.68]) by smtp.gmail.com with ESMTPSA id l12-20020a05600012cc00b001f059bcbd7asm1332253wrx.31.2022.03.09.03.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 03:02:10 -0800 (PST) From: christian.ehrhardt@canonical.com To: Yunjian Wang Cc: Haiyue Wang , dpdk stable Subject: patch 'net/ixgbe: reset security context pointer on close' has been queued to stable release 19.11.12 Date: Wed, 9 Mar 2022 12:00:45 +0100 Message-Id: <20220309110116.1295395-14-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220309110116.1295395-1-christian.ehrhardt@canonical.com> References: <20220309110116.1295395-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.12 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/11/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/8c4cc35028802e1db59a7ea84df1fd0ddaf06abd Thanks. Christian Ehrhardt --- >From 8c4cc35028802e1db59a7ea84df1fd0ddaf06abd Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Tue, 15 Feb 2022 21:01:51 +0800 Subject: [PATCH] net/ixgbe: reset security context pointer on close [ upstream commit 848a37cead7bd604d51b5f04507fea3e59e9088e ] When ixgbe_dev_close() is cleaning up, it does not correctly set the security_ctx variable to NULL, which will lead to wild pointer. Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec") Signed-off-by: Yunjian Wang Acked-by: Haiyue Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index bd2a684941..0c4eb682bc 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -3102,6 +3102,7 @@ ixgbe_dev_close(struct rte_eth_dev *dev) #ifdef RTE_LIBRTE_SECURITY rte_free(dev->security_ctx); + dev->security_ctx = NULL; #endif } -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-09 11:57:44.101316178 +0100 +++ 0014-net-ixgbe-reset-security-context-pointer-on-close.patch 2022-03-09 11:57:43.348938104 +0100 @@ -1 +1 @@ -From 848a37cead7bd604d51b5f04507fea3e59e9088e Mon Sep 17 00:00:00 2001 +From 8c4cc35028802e1db59a7ea84df1fd0ddaf06abd Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 848a37cead7bd604d51b5f04507fea3e59e9088e ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 3d799d2187..7643842560 100644 +index bd2a684941..0c4eb682bc 100644 @@ -22 +23 @@ -@@ -3038,6 +3038,7 @@ ixgbe_dev_close(struct rte_eth_dev *dev) +@@ -3102,6 +3102,7 @@ ixgbe_dev_close(struct rte_eth_dev *dev) @@ -24 +25 @@ - #ifdef RTE_LIB_SECURITY + #ifdef RTE_LIBRTE_SECURITY @@ -29 +30 @@ - return ret; + }