From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BC3DA0093 for ; Wed, 9 Mar 2022 12:02:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15F02410DC; Wed, 9 Mar 2022 12:02:15 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 3DBD0410DC for ; Wed, 9 Mar 2022 12:02:14 +0100 (CET) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 045933F1C5 for ; Wed, 9 Mar 2022 11:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646823733; bh=LnKqcgMY3DpIK/XhU2/Yjcg52M21IsKB41JzXXVA5mI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZyVIR9sYHe4QxeDZbjrjbgwt32ZsG/VuBSSzVjXGkYqT1+eWOi9QEZayopSRPL4I8 AMkBKMFK7a7jJFmxe3BIRjPEpKzhpjQqRKXmeliH3YU/P02ru3ZgE0l6NsuefWaZMR XulvJlH1/emBkwQ0CoiUecZSzSnORUO12ndNHSPGeJ/L/rr5NLtufpllwV1RgSTgzP ngxo71fWCuRZFhe8qr7pt5fz1cr/WsElPqkapgBsurSlWXkbZOdFdw3E1N6k7G8M4x gwM2g0NDZ7qBKIxPXhV7ncz/30sj7ks983tRrkmLisCoqBhTmQU0pK1JvuiD4cwrgw ZW88DTD+A0x9A== Received: by mail-wm1-f70.google.com with SMTP id l13-20020a7bcf0d000000b0038982c6bf8fso820839wmg.7 for ; Wed, 09 Mar 2022 03:02:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LnKqcgMY3DpIK/XhU2/Yjcg52M21IsKB41JzXXVA5mI=; b=y/OHPZSSFHbFvpEONuM0pyaHzvl+sYswTqsNksOi8RV+JFJibzy3vkkTh3+b7e2nLu NJkUs1KYtTrSoLxnDa3z6UlZXTuBGHMDqEoiDDiymujwV/VFM/a9TZijd3AdeVkTvSES giOUAOzJmUb8YktCf0UesWy6nHx6dNqOPgq/PoLPy0kAXNFG2jI/7KfRmKRuVuZF6HBM NWSWxjNkOXm2Yx4l8t+l2kLlaOJZchaCc/CTVyOKPr9LsZ+97qpedmgoq1d48cvBvtYj bQy862QMMIEo/o2YuUyH2ePWZhNg3eQg+3VbhiAa7M1pyUKnLrUHLT5AUNhuWSXKhQpy JgCg== X-Gm-Message-State: AOAM532BHG3pv1IHRFqAjeXWeE2TF3AtlXnApj/0mmuuKvh4YKUEFPg3 bg00USSw0rgaQaPUn6xJRa60qW7aWOFKaAR8vS/LuLXYOPM+B41KS4fK2I+A3s9sZcYUo3zJ97m ZGe8KJ73/l7hWUQY4xN7xjgZH X-Received: by 2002:a5d:424e:0:b0:1f0:3430:ffc8 with SMTP id s14-20020a5d424e000000b001f03430ffc8mr14994808wrr.672.1646823732372; Wed, 09 Mar 2022 03:02:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJzsMSuVWaUf/+yArFMzIKzdH38xVxWmT66xyQMZbUwIFflLuF87SA7YqU6/SN/eLPMgN31dmw== X-Received: by 2002:a5d:424e:0:b0:1f0:3430:ffc8 with SMTP id s14-20020a5d424e000000b001f03430ffc8mr14994793wrr.672.1646823732149; Wed, 09 Mar 2022 03:02:12 -0800 (PST) Received: from localhost.localdomain (068-133-067-156.ip-addr.inexio.net. [156.67.133.68]) by smtp.gmail.com with ESMTPSA id l12-20020a05600012cc00b001f059bcbd7asm1332253wrx.31.2022.03.09.03.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 03:02:11 -0800 (PST) From: christian.ehrhardt@canonical.com To: "Min Hu (Connor)" Cc: Ferruh Yigit , dpdk stable Subject: patch 'app/testpmd: check starting port is not in bonding' has been queued to stable release 19.11.12 Date: Wed, 9 Mar 2022 12:00:46 +0100 Message-Id: <20220309110116.1295395-15-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220309110116.1295395-1-christian.ehrhardt@canonical.com> References: <20220309110116.1295395-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.12 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/11/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/5748cf43bb906648021eb4d7f164557888cf27e6 Thanks. Christian Ehrhardt --- >From 5748cf43bb906648021eb4d7f164557888cf27e6 Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Thu, 17 Feb 2022 19:36:55 +0800 Subject: [PATCH] app/testpmd: check starting port is not in bonding [ upstream commit d8c079a572f3b76ca22fbfe665fb2e5e578ba881 ] In bond, start or stop slave port should be operated by bonding port. This patch add port_is_bonding_slave in start_port function. Fixes: 0e545d3047fe ("app/testpmd: check stopping port is not in bonding") Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh Yigit --- app/test-pmd/testpmd.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index a4782d1132..2a182eda20 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2311,6 +2311,13 @@ start_port(portid_t pid) if (pid != pi && pid != (portid_t)RTE_PORT_ALL) continue; + if (port_is_bonding_slave(pi)) { + fprintf(stderr, + "Please remove port %d from bonded device.\n", + pi); + continue; + } + need_check_link_status = 0; port = &ports[pi]; if (rte_atomic16_cmpset(&(port->port_status), RTE_PORT_STOPPED, -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-09 11:57:44.157285745 +0100 +++ 0015-app-testpmd-check-starting-port-is-not-in-bonding.patch 2022-03-09 11:57:43.352938131 +0100 @@ -1 +1 @@ -From d8c079a572f3b76ca22fbfe665fb2e5e578ba881 Mon Sep 17 00:00:00 2001 +From 5748cf43bb906648021eb4d7f164557888cf27e6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d8c079a572f3b76ca22fbfe665fb2e5e578ba881 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 6d2e52c790..fe2ce19f99 100644 +index a4782d1132..2a182eda20 100644 @@ -22 +23 @@ -@@ -2726,6 +2726,13 @@ start_port(portid_t pid) +@@ -2311,6 +2311,13 @@ start_port(portid_t pid) @@ -35 +36 @@ - if (port->port_status == RTE_PORT_STOPPED) + if (rte_atomic16_cmpset(&(port->port_status), RTE_PORT_STOPPED,