patches for DPDK stable branches
 help / color / mirror / Atom feed
From: christian.ehrhardt@canonical.com
To: Michal Krawczyk <mk@semihalf.com>
Cc: Artur Rojek <ar@semihalf.com>, Dawid Gorecki <dgr@semihalf.com>,
	Igor Chauskin <igorch@semihalf.com>,
	Shai Brandes <shaibran@amazon.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'net/ena: remove unused offload variables' has been queued to stable release 19.11.12
Date: Wed,  9 Mar 2022 12:00:50 +0100	[thread overview]
Message-ID: <20220309110116.1295395-19-christian.ehrhardt@canonical.com> (raw)
In-Reply-To: <20220309110116.1295395-1-christian.ehrhardt@canonical.com>

Hi,

FYI, your patch has been queued to stable release 19.11.12

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/11/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/2ffbbf4e57eab0bfa5fe2717ced057479a2f5bea

Thanks.

Christian Ehrhardt <christian.ehrhardt@canonical.com>

---
From 2ffbbf4e57eab0bfa5fe2717ced057479a2f5bea Mon Sep 17 00:00:00 2001
From: Michal Krawczyk <mk@semihalf.com>
Date: Wed, 23 Feb 2022 13:19:27 +0100
Subject: [PATCH] net/ena: remove unused offload variables

[ upstream commit fa11980449c225a217bf6923e79924edf991cb27 ]

Those variables are being set, but never read. As they seem to be
leftover from the old offloads API and don't have any purpose right
now, they are simply being removed.

Fixes: a4996bd89c42 ("ethdev: new Rx/Tx offloads API")

Signed-off-by: Michal Krawczyk <mk@semihalf.com>
Reviewed-by: Artur Rojek <ar@semihalf.com>
Reviewed-by: Dawid Gorecki <dgr@semihalf.com>
Reviewed-by: Igor Chauskin <igorch@semihalf.com>
Reviewed-by: Shai Brandes <shaibran@amazon.com>
---
 drivers/net/ena/ena_ethdev.c | 3 ---
 drivers/net/ena/ena_ethdev.h | 5 -----
 2 files changed, 8 deletions(-)

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 60b8e6aa64..f7eadd3bc8 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -1937,9 +1937,6 @@ static int ena_dev_configure(struct rte_eth_dev *dev)
 	 */
 	dev->data->scattered_rx = 1;
 
-	adapter->tx_selected_offloads = dev->data->dev_conf.txmode.offloads;
-	adapter->rx_selected_offloads = dev->data->dev_conf.rxmode.offloads;
-
 	return 0;
 }
 
diff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h
index a5b41b30f3..308e59cae7 100644
--- a/drivers/net/ena/ena_ethdev.h
+++ b/drivers/net/ena/ena_ethdev.h
@@ -179,11 +179,6 @@ struct ena_adapter {
 	struct ena_driver_stats *drv_stats;
 	enum ena_adapter_state state;
 
-	uint64_t tx_supported_offloads;
-	uint64_t tx_selected_offloads;
-	uint64_t rx_supported_offloads;
-	uint64_t rx_selected_offloads;
-
 	bool link_status;
 
 	enum ena_regs_reset_reason_types reset_reason;
-- 
2.35.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-03-09 11:57:44.382069450 +0100
+++ 0019-net-ena-remove-unused-offload-variables.patch	2022-03-09 11:57:43.364938205 +0100
@@ -1 +1 @@
-From fa11980449c225a217bf6923e79924edf991cb27 Mon Sep 17 00:00:00 2001
+From 2ffbbf4e57eab0bfa5fe2717ced057479a2f5bea Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit fa11980449c225a217bf6923e79924edf991cb27 ]
+
@@ -11 +12,0 @@
-Cc: stable@dpdk.org
@@ -24 +25 @@
-index 2de2dcf12f..de5fdb8f1d 100644
+index 60b8e6aa64..f7eadd3bc8 100644
@@ -27 +28 @@
-@@ -2015,9 +2015,6 @@ static int ena_dev_configure(struct rte_eth_dev *dev)
+@@ -1937,9 +1937,6 @@ static int ena_dev_configure(struct rte_eth_dev *dev)
@@ -29 +30 @@
- 	adapter->tx_cleanup_stall_delay = adapter->missing_tx_completion_to / 2;
+ 	dev->data->scattered_rx = 1;
@@ -38 +39 @@
-index f47ba3fb02..4dfa604d51 100644
+index a5b41b30f3..308e59cae7 100644
@@ -41 +42 @@
-@@ -278,11 +278,6 @@ struct ena_adapter {
+@@ -179,11 +179,6 @@ struct ena_adapter {

  parent reply	other threads:[~2022-03-09 11:02 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-09 11:00 patch 'eventdev/eth_tx: fix queue add error code' " christian.ehrhardt
2022-03-09 11:00 ` patch 'telemetry: add missing C++ guards' " christian.ehrhardt
2022-03-09 11:00 ` patch 'acl: " christian.ehrhardt
2022-03-09 11:00 ` patch 'compressdev: " christian.ehrhardt
2022-03-09 11:00 ` patch 'eventdev: " christian.ehrhardt
2022-03-09 11:00 ` patch 'kni: " christian.ehrhardt
2022-03-09 11:00 ` patch 'ethdev: fix cast for C++ compatibility' " christian.ehrhardt
2022-03-09 11:00 ` patch 'cryptodev: fix RSA key type name' " christian.ehrhardt
2022-03-09 11:00 ` patch 'doc: fix FIPS guide' " christian.ehrhardt
2022-03-09 11:00 ` patch 'examples/l2fwd-crypto: fix port mask overflow' " christian.ehrhardt
2022-03-09 11:00 ` patch 'crypto/virtio: fix out-of-bounds access' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/nfb: fix array indexes in deinit functions' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/nfb: fix multicast/promiscuous mode switching' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/ixgbe: reset security context pointer on close' " christian.ehrhardt
2022-03-09 11:00 ` patch 'app/testpmd: check starting port is not in bonding' " christian.ehrhardt
2022-03-09 11:00 ` patch 'vhost: fix unsafe vring addresses modifications' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/af_xdp: add missing trailing newline in logs' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/ena: remove unused enumeration' " christian.ehrhardt
2022-03-09 11:00 ` christian.ehrhardt [this message]
2022-03-09 11:00 ` patch 'net/ena: skip timer if reset is triggered' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/ena: fix meta descriptor DF flag setup' " christian.ehrhardt
2022-03-09 11:00 ` patch 'net/ena: fix checksum flag for L4' " christian.ehrhardt
2022-03-09 11:00 ` patch 'doc: remove obsolete vector Tx explanations from mlx5 guide' " christian.ehrhardt
2022-03-09 11:00 ` patch 'doc: replace broken links in mlx guides' " christian.ehrhardt
2022-03-09 11:00 ` patch 'app/testpmd: fix build without drivers' " christian.ehrhardt
2022-03-09 11:00 ` patch 'test/efd: fix sockets mask size' " christian.ehrhardt
2022-03-09 11:00 ` patch 'distributor: fix potential overflow' " christian.ehrhardt
2022-03-09 11:00 ` patch 'eal/linux: fix illegal memory access in uevent handler' " christian.ehrhardt
2022-03-09 11:01 ` patch 'kni: fix freeing order in device release' " christian.ehrhardt
2022-03-09 11:01 ` patch 'app/compress-perf: fix socket ID type during init' " christian.ehrhardt
2022-03-09 11:01 ` patch 'app/compress-perf: fix number of queue pairs to setup' " christian.ehrhardt
2022-03-09 11:01 ` patch 'compressdev: fix socket ID type' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/hns3: remove duplicate macro definition' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/hns3: fix RSS TC mode entry' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/hns3: fix VF " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/hns3: increase time waiting for PF reset completion' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/ixgbe: fix FSP check for X550EM devices' " christian.ehrhardt
2022-03-09 11:01 ` patch 'doc: fix typos and punctuation in flow API guide' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/mlx5: fix matcher priority with ICMP or ICMPv6' " christian.ehrhardt
2022-03-09 11:01 ` patch 'raw/ifpga: fix variable initialization in probing' " christian.ehrhardt
2022-03-09 11:01 ` patch 'app/pdump: abort on multi-core capture limit' " christian.ehrhardt
2022-03-09 11:01 ` patch 'examples/distributor: reduce Tx queue number to 1' " christian.ehrhardt
2022-03-09 11:01 ` patch 'examples/flow_classify: fix failure message' " christian.ehrhardt
2022-03-09 11:01 ` patch 'ethdev: fix doxygen comments for device info struct' " christian.ehrhardt
2022-03-09 11:01 ` patch 'net/mlx5: fix modify port action validation' " christian.ehrhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220309110116.1295395-19-christian.ehrhardt@canonical.com \
    --to=christian.ehrhardt@canonical.com \
    --cc=ar@semihalf.com \
    --cc=dgr@semihalf.com \
    --cc=igorch@semihalf.com \
    --cc=mk@semihalf.com \
    --cc=shaibran@amazon.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).