From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C89A0A0093 for ; Wed, 9 Mar 2022 12:02:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BFC6E410E6; Wed, 9 Mar 2022 12:02:31 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 8B49640150 for ; Wed, 9 Mar 2022 12:02:30 +0100 (CET) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 5AE3C3F499 for ; Wed, 9 Mar 2022 11:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646823748; bh=N9EbnPFVRDmIedKUnq64Y3wqpMC8MoSbUmD9+lBCPuQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PmceW/ofe6jfOp1LCPhLye5l6FroppabAFCEmVEZS6OHhruh43VVMoS1wq0JcCu+B 2cX8pfcaLI3+YYqNaE26U5MJSdFYyPry14ejzwlqFKe5wQr3JB8icgRoOYI52PfEBK 8zuLvQat0o4+bA9EACuCZ0244cbjIIvYf+WKRY4aXXiIlTDrtBaSithcJLvxrodcMv DEtt1DeLrDfDw197um4jeNVJdYVBuMUOungSpygHNKwohhYj07q0qal+HmTk4Fssln 4wrDAgJ7zE1siTo8/a61tpRhT1zlJa1SPJQkAkVmitovXZEmYPkziG+DA7NWjbpXsm nxcZ2cPT/EmJA== Received: by mail-wm1-f70.google.com with SMTP id f24-20020a1c6a18000000b00388874b17a8so834201wmc.3 for ; Wed, 09 Mar 2022 03:02:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N9EbnPFVRDmIedKUnq64Y3wqpMC8MoSbUmD9+lBCPuQ=; b=bfwLs3D3WNKvhi+RIizVxqssngaV6I3F78SXVOSphTnHMyZMgXvz4m/UMNFvdv+Toe l+X6KxjOTsUtVu9LkIQiWa1p+2Iu2RNmPTGxKKolSA9eEo2y0l1tdPO1Yvad62fIpNFl +Keh1+74zHYZAVzIGCmR33g6qS7DjL+SxfHdxWs35+Qw8E++L5CIgH9v7JylzIjCaZSr n4XelGIfzZzls3dLF9aObAO0F/iPcdyIEhnRLT2E224qU0/Gqs7jtB4CzR2xncF6PfQt j0VgNWTT2ieCw7LqZkcLziQSLd2ygzppgpzBLVFcK/4TVts2WPbpI9ZAiOpkMppRghSX 2rng== X-Gm-Message-State: AOAM530I2DnUrcSIiK//MQiknnoxe/imI1pxYTebW7GUmJ67b3OxeVLh Z0aM4sKTkDc5G2Aa5Z7nAB2baaE56dGzVaRAo/bCWNJ11fX3QDKnLg55hlPcsgaJoP0hGw2oWbp rxZwUoOVkiC8cu8NsolJKjBVc X-Received: by 2002:adf:cd02:0:b0:1f0:767d:b39a with SMTP id w2-20020adfcd02000000b001f0767db39amr15257235wrm.529.1646823746624; Wed, 09 Mar 2022 03:02:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJx3mOqZHzJtiMTSJk5Whts624LXx4wpf0Yb7e1jU2kPfvgGpXBfc5lt0Hfnbg07J7CcM1pzBA== X-Received: by 2002:adf:cd02:0:b0:1f0:767d:b39a with SMTP id w2-20020adfcd02000000b001f0767db39amr15257218wrm.529.1646823746414; Wed, 09 Mar 2022 03:02:26 -0800 (PST) Received: from localhost.localdomain (068-133-067-156.ip-addr.inexio.net. [156.67.133.68]) by smtp.gmail.com with ESMTPSA id bg42-20020a05600c3caa00b00380deeaae72sm4955385wmb.1.2022.03.09.03.02.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 03:02:25 -0800 (PST) From: christian.ehrhardt@canonical.com To: Michal Krawczyk Cc: Artur Rojek , Dawid Gorecki , Igor Chauskin , Shai Brandes , dpdk stable Subject: patch 'net/ena: remove unused offload variables' has been queued to stable release 19.11.12 Date: Wed, 9 Mar 2022 12:00:50 +0100 Message-Id: <20220309110116.1295395-19-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220309110116.1295395-1-christian.ehrhardt@canonical.com> References: <20220309110116.1295395-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.12 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/11/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/2ffbbf4e57eab0bfa5fe2717ced057479a2f5bea Thanks. Christian Ehrhardt --- >From 2ffbbf4e57eab0bfa5fe2717ced057479a2f5bea Mon Sep 17 00:00:00 2001 From: Michal Krawczyk Date: Wed, 23 Feb 2022 13:19:27 +0100 Subject: [PATCH] net/ena: remove unused offload variables [ upstream commit fa11980449c225a217bf6923e79924edf991cb27 ] Those variables are being set, but never read. As they seem to be leftover from the old offloads API and don't have any purpose right now, they are simply being removed. Fixes: a4996bd89c42 ("ethdev: new Rx/Tx offloads API") Signed-off-by: Michal Krawczyk Reviewed-by: Artur Rojek Reviewed-by: Dawid Gorecki Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 3 --- drivers/net/ena/ena_ethdev.h | 5 ----- 2 files changed, 8 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 60b8e6aa64..f7eadd3bc8 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1937,9 +1937,6 @@ static int ena_dev_configure(struct rte_eth_dev *dev) */ dev->data->scattered_rx = 1; - adapter->tx_selected_offloads = dev->data->dev_conf.txmode.offloads; - adapter->rx_selected_offloads = dev->data->dev_conf.rxmode.offloads; - return 0; } diff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h index a5b41b30f3..308e59cae7 100644 --- a/drivers/net/ena/ena_ethdev.h +++ b/drivers/net/ena/ena_ethdev.h @@ -179,11 +179,6 @@ struct ena_adapter { struct ena_driver_stats *drv_stats; enum ena_adapter_state state; - uint64_t tx_supported_offloads; - uint64_t tx_selected_offloads; - uint64_t rx_supported_offloads; - uint64_t rx_selected_offloads; - bool link_status; enum ena_regs_reset_reason_types reset_reason; -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-09 11:57:44.382069450 +0100 +++ 0019-net-ena-remove-unused-offload-variables.patch 2022-03-09 11:57:43.364938205 +0100 @@ -1 +1 @@ -From fa11980449c225a217bf6923e79924edf991cb27 Mon Sep 17 00:00:00 2001 +From 2ffbbf4e57eab0bfa5fe2717ced057479a2f5bea Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fa11980449c225a217bf6923e79924edf991cb27 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 2de2dcf12f..de5fdb8f1d 100644 +index 60b8e6aa64..f7eadd3bc8 100644 @@ -27 +28 @@ -@@ -2015,9 +2015,6 @@ static int ena_dev_configure(struct rte_eth_dev *dev) +@@ -1937,9 +1937,6 @@ static int ena_dev_configure(struct rte_eth_dev *dev) @@ -29 +30 @@ - adapter->tx_cleanup_stall_delay = adapter->missing_tx_completion_to / 2; + dev->data->scattered_rx = 1; @@ -38 +39 @@ -index f47ba3fb02..4dfa604d51 100644 +index a5b41b30f3..308e59cae7 100644 @@ -41 +42 @@ -@@ -278,11 +278,6 @@ struct ena_adapter { +@@ -179,11 +179,6 @@ struct ena_adapter {