From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E514FA0093 for ; Wed, 9 Mar 2022 12:02:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDDBF40150; Wed, 9 Mar 2022 12:02:40 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 5019140150 for ; Wed, 9 Mar 2022 12:02:40 +0100 (CET) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id F20813F79C for ; Wed, 9 Mar 2022 11:02:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646823758; bh=uptxranWeeDo2GWDg/KA1Npr4MasWfa+zRDQrQCkxdE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rKRHMq7dgUyPEuSvAk3oWj/SnrbFJuO/bqei27Y2PoO5mYXq5j9zmVX+GDkJMlUzC JE2OilA8lclKJ4sMTeuTI374CZun7jh5TKMkKPTn22h+NpbvDNrIV+eVWlBJCgWZER Q9MNeL/nR/zc50TfYbKl7MUVLjuQ/c0rAZFPUDs4YVqb1IXIfFfLpNfJnDFofyyVl8 nsx/Qkr18Zr55EVh1o6LfeIveRAqfmtqMZT91uMNTB//MpOoz0d2vAaGy/Gaz76sbb 92YdvWX4VL9xHM053aPGa7aeDmfJz8XsM1jabk11Exea7SptHPW+NrcEtJKdb7xsA+ xHfbWUcAPQ3ww== Received: by mail-wm1-f70.google.com with SMTP id h131-20020a1c2189000000b003898de01de4so653029wmh.7 for ; Wed, 09 Mar 2022 03:02:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uptxranWeeDo2GWDg/KA1Npr4MasWfa+zRDQrQCkxdE=; b=DRFj5bXQ77IA6uGbROIJjHMwRSHYhHtlVaS8cMEwXVFpuRZPllgOclHlTglrxm4X07 xDAAn0nryE6rExTGRMDqFdKqtf7QtYgOXy9IRiurMfK20Ab7+yX0V0a4BeipeggAUN2m JUzKVWwueep84j7y+g/W03woKMFSDjb6TsEjwVkElVXWyIhKUa33nBf4nryq7mkbwiPb OueXvEpwjtX8H81X0eKKyYwjtG7LRvdSIzzQNa0YfaiLg0+FqcdKky4Pbr6104R3cgeY OM3fGjK/dTLh+ITVFUJSp6vPxMcnCTkQn1nGybvPQpsFvqIQt79+7rkiKbGfaHpkiZJi 0G9g== X-Gm-Message-State: AOAM531brTqNeX7YVSaZFjrb7ABGn/0Tz7Z6kxL5U6+yt2k/n8Ev3TYS BIZUEQXm0YaFC8sDa/RrTg/ukQT9YZwfhGSZpMV54LWk2mozFJxV98Lo5mTfaCAEhjaU5jHJPak t+JVYUJxTcCqrvt1zrqpKSxCF X-Received: by 2002:adf:e8ca:0:b0:1f1:d8be:e20c with SMTP id k10-20020adfe8ca000000b001f1d8bee20cmr15939034wrn.373.1646823758333; Wed, 09 Mar 2022 03:02:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJzyazKDIDe++zMc4nLSQ09ZmT3Vpal6eNbzSHJIWCDTXcSv2KYxflbjEtKhASROcSvDU6XdzA== X-Received: by 2002:adf:e8ca:0:b0:1f1:d8be:e20c with SMTP id k10-20020adfe8ca000000b001f1d8bee20cmr15939027wrn.373.1646823758129; Wed, 09 Mar 2022 03:02:38 -0800 (PST) Received: from localhost.localdomain (068-133-067-156.ip-addr.inexio.net. [156.67.133.68]) by smtp.gmail.com with ESMTPSA id a8-20020a05600c068800b00389bdc8c8c2sm1361092wmn.12.2022.03.09.03.02.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 03:02:37 -0800 (PST) From: christian.ehrhardt@canonical.com To: Michal Krawczyk Cc: Dawid Gorecki , Shai Brandes , dpdk stable Subject: patch 'net/ena: fix meta descriptor DF flag setup' has been queued to stable release 19.11.12 Date: Wed, 9 Mar 2022 12:00:52 +0100 Message-Id: <20220309110116.1295395-21-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220309110116.1295395-1-christian.ehrhardt@canonical.com> References: <20220309110116.1295395-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.12 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/11/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/d1492dfd828d1afd2e6150c25d1e314d0a7527c2 Thanks. Christian Ehrhardt --- >From d1492dfd828d1afd2e6150c25d1e314d0a7527c2 Mon Sep 17 00:00:00 2001 From: Michal Krawczyk Date: Wed, 23 Feb 2022 13:19:40 +0100 Subject: [PATCH] net/ena: fix meta descriptor DF flag setup [ upstream commit 022fb61b62623868db2ec9dbe5b1ee43a4d6cbfb ] Whenever Tx checksum offload is being used, the meta descriptor content is taken into consideration. Setting DF field properly in the meta descriptor may have huge impact on the performance both for the IPv4 and IPv6 packets. The requirements for the df field are as below: * No offload used - value doesn't matter * IPv4 - 0 or 1, depending on the DF flag in the IPv4 header * IPv6 - 1 Setting DF to 0 causes the packet to enter the slow-path in the HW and as a result can noticeable impact the performance. Moreover, as 'true' may not always be mapped to 1 depending on it's definition for the given platform/compiler, for safety DF field is being set explicitly to 1. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index c73234f838..5d5111e2c7 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -328,6 +328,8 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, if (mbuf->ol_flags & PKT_TX_IPV6) { ena_tx_ctx->l3_proto = ENA_ETH_IO_L3_PROTO_IPV6; + /* For the IPv6 packets, DF always needs to be true. */ + ena_tx_ctx->df = 1; } else { ena_tx_ctx->l3_proto = ENA_ETH_IO_L3_PROTO_IPV4; @@ -335,7 +337,7 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, if (mbuf->packet_type & (RTE_PTYPE_L4_NONFRAG | RTE_PTYPE_INNER_L4_NONFRAG)) - ena_tx_ctx->df = true; + ena_tx_ctx->df = 1; } /* check if L4 checksum is needed */ -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-09 11:57:44.472135883 +0100 +++ 0021-net-ena-fix-meta-descriptor-DF-flag-setup.patch 2022-03-09 11:57:43.368938231 +0100 @@ -1 +1 @@ -From 022fb61b62623868db2ec9dbe5b1ee43a4d6cbfb Mon Sep 17 00:00:00 2001 +From d1492dfd828d1afd2e6150c25d1e314d0a7527c2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 022fb61b62623868db2ec9dbe5b1ee43a4d6cbfb ] + @@ -24 +25,0 @@ -Cc: stable@dpdk.org @@ -34 +35 @@ -index 0ca4269522..53a8071968 100644 +index c73234f838..5d5111e2c7 100644 @@ -37 +38 @@ -@@ -624,6 +624,8 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, +@@ -328,6 +328,8 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, @@ -39 +40 @@ - if (mbuf->ol_flags & RTE_MBUF_F_TX_IPV6) { + if (mbuf->ol_flags & PKT_TX_IPV6) { @@ -46 +47 @@ -@@ -631,7 +633,7 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf, +@@ -335,7 +337,7 @@ static inline void ena_tx_mbuf_prepare(struct rte_mbuf *mbuf,