From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96F64A0093 for ; Wed, 9 Mar 2022 12:03:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92B87410DC; Wed, 9 Mar 2022 12:03:12 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id EEA2D410E6 for ; Wed, 9 Mar 2022 12:03:10 +0100 (CET) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id BFF313F1AF for ; Wed, 9 Mar 2022 11:03:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646823789; bh=L9omjUSTs1q+MA9LXmCyhvhThUumd9PbSu/qXrddAYE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rEWw3krEjbWkEbN8kXIbDYLuLvxCQZiqbaeZTLbBZNiBlUObfAaS1RNoG/MTLjtSd hml56dMkTLFhD2SVf+knCNH/+OsgTOetbP7lVJ+8c0zmTrvMJOMLelZSiZD+n6MP70 B50GE4JyJ6mRTC1wV3Wkviw1mohEitJohoNMitaMbYWWsmX8aK/c7Zg1GbTZ9FW9JY 9BIzeA5aRAeR7Rb9JeLwgRcpCEGtCukP2FMZGz+z0gjOW+ExJyj1bUkThsarluC9HY CWWLwde/OHaveof6lkGnVPNCBmhx+hlXTsbut02+eFLoRJcHEmq5YNc1bH3Bj+jIyk c0wDPbYG+UX8Q== Received: by mail-wr1-f69.google.com with SMTP id x15-20020a5d6b4f000000b001ee6c0aa287so637598wrw.9 for ; Wed, 09 Mar 2022 03:03:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L9omjUSTs1q+MA9LXmCyhvhThUumd9PbSu/qXrddAYE=; b=cI4JJeWERMrqE7OwMGQ9gJqrKgbeyQh5QbWfVOHVSZZQ3LKFKnHBZ2tsQNRzsbYrAX XbTw2+yBT6+l+VkRx+yVXj04gfQ2dLo2KVoTU4QKDwka30DwRtC8RRqurzhXHSmX/1R9 N3H7y3+J2DUBsfnpMDzdFQw80vyyYEiCUp10DgZM533ltd8luW1dulwdhzrCkXPDthuH CfeLQXKfp0yaOl5DDYyml/AKaERpZPT0gdLlohlmY6NSN3UK9U2bf5jU2CsLorqvQCx6 dsKGKqNo4/XhmpbAn5W3GnxpFEAviOkk6e0Vgp3ikmePm5Cmi2rYF3A2zQW1UnigWdka wBcQ== X-Gm-Message-State: AOAM5315TieK5JROUL8cki7HkO7mN0PbBWfKFPHcyFJut5vAJ1/BAK+9 ER6rT7OKPkeYRDejhGxigR4oG3k9W+dv6w0bKYuu+FM6tkKzGuOCJvJTs39YdZovyD0jbfsJY9k LGVbfty5Q9ybQg5ves1sfKENd X-Received: by 2002:adf:fecf:0:b0:1f0:62e0:bcd8 with SMTP id q15-20020adffecf000000b001f062e0bcd8mr15942462wrs.61.1646823788914; Wed, 09 Mar 2022 03:03:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJxRVSlLF+2xleI5ZjIJqp0otbxW1yan39EdQ8HppC4dlxr1VMSqAFhmBtXGUDEiM6xGpSEfyA== X-Received: by 2002:adf:fecf:0:b0:1f0:62e0:bcd8 with SMTP id q15-20020adffecf000000b001f062e0bcd8mr15942448wrs.61.1646823788717; Wed, 09 Mar 2022 03:03:08 -0800 (PST) Received: from localhost.localdomain (068-133-067-156.ip-addr.inexio.net. [156.67.133.68]) by smtp.gmail.com with ESMTPSA id 9-20020a05600c268900b00381394d74a1sm1509439wmt.9.2022.03.09.03.03.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 03:03:08 -0800 (PST) From: christian.ehrhardt@canonical.com To: Raja Zidane Cc: Matan Azrad , dpdk stable Subject: patch 'compressdev: fix socket ID type' has been queued to stable release 19.11.12 Date: Wed, 9 Mar 2022 12:01:03 +0100 Message-Id: <20220309110116.1295395-32-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220309110116.1295395-1-christian.ehrhardt@canonical.com> References: <20220309110116.1295395-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.12 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/11/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/166408ae9867573eb1ef76ab4717443a36530b78 Thanks. Christian Ehrhardt --- >From 166408ae9867573eb1ef76ab4717443a36530b78 Mon Sep 17 00:00:00 2001 From: Raja Zidane Date: Tue, 1 Mar 2022 16:15:02 +0200 Subject: [PATCH] compressdev: fix socket ID type [ upstream commit c0941508b30618b9dd335fb4b533d451f8686f3b ] Socket ID is used and interpreted as integer, one of the possible values for socket id is -1 (SOCKET_ID_ANY). here socket_id is defined as unsigned 8 bit integer, so when putting -1, it is interpreted as 255, which causes allocation errors when trying to allocate from socket_id (255). change socket_id from unsigned 8 bit integer to integer. Fixes: ed7dd94f7f66 ("compressdev: add basic device management") Signed-off-by: Raja Zidane Acked-by: Matan Azrad --- lib/librte_compressdev/rte_compressdev_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_compressdev/rte_compressdev_internal.h b/lib/librte_compressdev/rte_compressdev_internal.h index 888c8f5c5c..25d8afbfb9 100644 --- a/lib/librte_compressdev/rte_compressdev_internal.h +++ b/lib/librte_compressdev/rte_compressdev_internal.h @@ -98,7 +98,7 @@ struct rte_compressdev { struct rte_compressdev_data { uint8_t dev_id; /**< Compress device identifier */ - uint8_t socket_id; + int socket_id; /**< Socket identifier where memory is allocated */ char name[RTE_COMPRESSDEV_NAME_MAX_LEN]; /**< Unique identifier name */ -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-09 11:57:45.040606792 +0100 +++ 0032-compressdev-fix-socket-ID-type.patch 2022-03-09 11:57:43.396938405 +0100 @@ -1 +1 @@ -From c0941508b30618b9dd335fb4b533d451f8686f3b Mon Sep 17 00:00:00 2001 +From 166408ae9867573eb1ef76ab4717443a36530b78 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c0941508b30618b9dd335fb4b533d451f8686f3b ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ - lib/compressdev/rte_compressdev_internal.h | 2 +- + lib/librte_compressdev/rte_compressdev_internal.h | 2 +- @@ -23 +24 @@ -diff --git a/lib/compressdev/rte_compressdev_internal.h b/lib/compressdev/rte_compressdev_internal.h +diff --git a/lib/librte_compressdev/rte_compressdev_internal.h b/lib/librte_compressdev/rte_compressdev_internal.h @@ -25,2 +26,2 @@ ---- a/lib/compressdev/rte_compressdev_internal.h -+++ b/lib/compressdev/rte_compressdev_internal.h +--- a/lib/librte_compressdev/rte_compressdev_internal.h ++++ b/lib/librte_compressdev/rte_compressdev_internal.h