From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66094A0093 for ; Wed, 9 Mar 2022 17:31:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 607FE4013F; Wed, 9 Mar 2022 17:31:36 +0100 (CET) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mails.dpdk.org (Postfix) with ESMTP id B14AF410E8 for ; Wed, 9 Mar 2022 17:31:34 +0100 (CET) Received: by mail-wr1-f47.google.com with SMTP id p9so3885130wra.12 for ; Wed, 09 Mar 2022 08:31:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cDEBNyic3w7WeUmwY/NyFcz6lVY/y8v/Mcpx5Y5LuYQ=; b=leDda0dNpT1cqwWKyFQRZEgBMp5eAi3V4u/ziMSZcMveg+2TqWVLKtYQzA6vN3BFsw 8uRftvPwIBM6nKIzWL2Fh8dQSNqI6pVwK9saj2f+h38GIkf0hJtAx4vykqCB8FohenGo KJXnD8qq/k7+b3cQpSkejkyNG46z3oD5qkM0wnljvqqw914qm/8RvBXJ7Vr1bAcvD9IL pbwQBtbyae3v5XZfeq549pwxAYUzvZTThzOWDvjbcka3VLthWn+cLXscJ8TDs0dXNkWJ jgkr0Qi9t+6p6RTHFdml4O5EEesSCPWTzerZ235o+/9ueM9YzIrMZ0JAWZmu7xPh0+KV CFJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cDEBNyic3w7WeUmwY/NyFcz6lVY/y8v/Mcpx5Y5LuYQ=; b=ToJtvJitNFvcAU+JgD+pcaATk8yEafYEJ/4RP4WEf+sINPAGenb5yoBRC51C5uAJIf UHE2Ac//LFmbST1sdH8b0FQirTrv6TFjJIo9J0hZgi2ac+us0cub1YOxcA1iG7gtu7qc Zw3Ujtdw+j0XjUINXEn29JwHu3Io89kVJibS36J3xDDuCLxOypGW2LzTewj04/zGeJxT ib+jOZGFyItGsSnFemKcTvOyk+yJrhY1wg00v6fHPsxC7+HRf0t+x3poWj9x0VA5x+J2 ruNS+ZTS/pkRJvdzA7ubQ3YhNRZ3bGQ+HGUuLcAHqycfR9LBEJX11qaY1Sx4O8hUEAb9 EeGQ== X-Gm-Message-State: AOAM5328DuHa7hctnFoCxEPdnRXT/y6w7/7e2pdZdvxz6dMhU36Zt5yZ DUmNW3BcdVAgw//J45oeMGM= X-Google-Smtp-Source: ABdhPJytE3gQHnm+ufmBoZ/2DWVQUDC0Y2QHnQxz8H2SA3Wl899mTyMsP1zP//87PCBkZh83w978hA== X-Received: by 2002:a5d:680f:0:b0:1f0:5550:ffa with SMTP id w15-20020a5d680f000000b001f055500ffamr349935wru.648.1646843494449; Wed, 09 Mar 2022 08:31:34 -0800 (PST) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id b5-20020a5d40c5000000b001f07ab4f2d7sm2065274wrq.17.2022.03.09.08.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 08:31:33 -0800 (PST) From: luca.boccassi@gmail.com To: Harold Huang Cc: Ferruh Yigit , dpdk stable Subject: patch 'net/kni: fix config initialization' has been queued to stable release 20.11.5 Date: Wed, 9 Mar 2022 16:30:30 +0000 Message-Id: <20220309163053.245754-14-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220309163053.245754-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-1-luca.boccassi@gmail.com> <20220309163053.245754-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/11/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/2de6a2e6269d3b04ff4e6cfd1d6b1bae3cb3b739 Thanks. Luca Boccassi --- >From 2de6a2e6269d3b04ff4e6cfd1d6b1bae3cb3b739 Mon Sep 17 00:00:00 2001 From: Harold Huang Date: Thu, 3 Mar 2022 10:18:03 +0800 Subject: [PATCH] net/kni: fix config initialization [ upstream commit dcd398f9466fc42f09e5c725c3188d8c41bd3fbf ] When kni driver calls eth_kni_start to start device, some fields such as min_mtu and max_mtu of rte_kni_conf are not initialized. It will cause kni_ioctl_create create a kni netdevice with a random min_mtu and max_mtu value. This is unexpected and sometimes we could not change the kni device mtu with ip link command. Fixes: ff1e35fb5f83 ("kni: calculate MTU from mbuf size") Signed-off-by: Harold Huang Reviewed-by: Ferruh Yigit --- drivers/net/kni/rte_eth_kni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c index 5d8fb1451a..5e8d0b722e 100644 --- a/drivers/net/kni/rte_eth_kni.c +++ b/drivers/net/kni/rte_eth_kni.c @@ -124,7 +124,7 @@ eth_kni_start(struct rte_eth_dev *dev) struct pmd_internals *internals = dev->data->dev_private; uint16_t port_id = dev->data->port_id; struct rte_mempool *mb_pool; - struct rte_kni_conf conf; + struct rte_kni_conf conf = {{0}}; const char *name = dev->device->name + 4; /* remove net_ */ mb_pool = internals->rx_queues[0].mb_pool; -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-09 16:30:09.059491129 +0000 +++ 0014-net-kni-fix-config-initialization.patch 2022-03-09 16:30:08.523024617 +0000 @@ -1 +1 @@ -From dcd398f9466fc42f09e5c725c3188d8c41bd3fbf Mon Sep 17 00:00:00 2001 +From 2de6a2e6269d3b04ff4e6cfd1d6b1bae3cb3b739 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit dcd398f9466fc42f09e5c725c3188d8c41bd3fbf ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index c428caf441..0532de5315 100644 +index 5d8fb1451a..5e8d0b722e 100644