From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB47BA0093 for ; Wed, 9 Mar 2022 17:30:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D613E4068E; Wed, 9 Mar 2022 17:30:59 +0100 (CET) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mails.dpdk.org (Postfix) with ESMTP id D7D4D4068E for ; Wed, 9 Mar 2022 17:30:58 +0100 (CET) Received: by mail-wr1-f46.google.com with SMTP id h15so3908089wrc.6 for ; Wed, 09 Mar 2022 08:30:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iFtZGSjT/n777fQlEQPfdIUSA49SX82Ovpav7GEjc9s=; b=ZuyWuYbOUghuvhzzMrwlvVP9NQVQzHyTe97u11dFKNz7Zir9ZVLlRZaexn+jyXKvaS 0dwSYj1UVoxuV3PAwC5+tswmXdnIos9fbv51BCu12ugf76PsEApwYqA/KhQCGdABcCtc U4EP/Sw1sU9M9BeA4yTJNJcjPKOEI/K7CPPzahd9xgEGL/PZMbQOwGN6L1wR7cb8x9hf e4CSt9Jifz/7udRRs9HRgzGRC0NeYmVALdZwq9TcFQSeOcU1qiDEepnefyUoFavmBXCw hy0LllS2tEd1Y3vFWkX03F9LB1j/yybYB7hDgHZpFrJfyPu44y6HQC9heoZXnOWS4OLX FH2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iFtZGSjT/n777fQlEQPfdIUSA49SX82Ovpav7GEjc9s=; b=ln6tzadrvaQHF9XHx61l9mLx9QR2ET0qp1Feq5HHdIffjvhG+1lRu3Ub4Htf1AVlVY /W2yoZqXIUhUD3UC1tGSDjhGq+44teOYitVzDFOHw7p1NhzPrzTWcIxEd5FEHndzRIKr 5WtsNUa9DFp6GjfsYt3EfumijV4/pnVTlf0DXw13YG2UGoc5KbciLuONxkZI9vT0BqoZ WMJlIaGTQjzy/uPfCkVGSuYd9QMKRPwloSE42hsyxtHTIT5yFjMH+N2jH+9oW7NmhVkX rQYg74hKW1ky7qK/8/oDt1fsXxyGu9cZzrTjtpotILh2fM8QWrzytBuHY6y/9c9qvmL4 TTxQ== X-Gm-Message-State: AOAM5334EwX0VetWx1sNMjFqbFQCo6Xwto9mBfeAtBEYavbcCeDUCLCF evsS36R6oHkx75JRmYtTz2k= X-Google-Smtp-Source: ABdhPJwJo/wHuf/Nczy/budJ+O8/yxhnJ8Y/UnN9uuqKBu6xT0WWBW0XDGpgOZHEAnxnV6OmkNrYAg== X-Received: by 2002:a05:6000:1acf:b0:1f0:5e59:6c40 with SMTP id i15-20020a0560001acf00b001f05e596c40mr377533wry.42.1646843458585; Wed, 09 Mar 2022 08:30:58 -0800 (PST) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id n20-20020a05600c501400b0038995ede299sm2100629wmr.17.2022.03.09.08.30.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 08:30:57 -0800 (PST) From: luca.boccassi@gmail.com To: Raja Zidane Cc: Matan Azrad , Fan Zhang , dpdk stable Subject: patch 'app/compress-perf: optimize operations pool allocation' has been queued to stable release 20.11.5 Date: Wed, 9 Mar 2022 16:30:18 +0000 Message-Id: <20220309163053.245754-2-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220309163053.245754-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-1-luca.boccassi@gmail.com> <20220309163053.245754-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/11/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/c30254b5da1b5033462ab40450cce4fc7cb18088 Thanks. Luca Boccassi --- >From c30254b5da1b5033462ab40450cce4fc7cb18088 Mon Sep 17 00:00:00 2001 From: Raja Zidane Date: Wed, 23 Feb 2022 15:33:07 +0200 Subject: [PATCH] app/compress-perf: optimize operations pool allocation [ upstream commit 68d3287f4ef43318728e4a134b7aa33d5c52b12d ] An array of the size of total operations needed for the de/compression is reserved for ops while enqueueing, although only first burst_size entries of the array are used. Reduce the size of the array allocated. Fixes: b68a82425da4 ("app/compress-perf: add performance measurement") Signed-off-by: Raja Zidane Acked-by: Matan Azrad Acked-by: Fan Zhang --- app/test-compress-perf/comp_perf_test_cyclecount.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-compress-perf/comp_perf_test_cyclecount.c b/app/test-compress-perf/comp_perf_test_cyclecount.c index 9ade89fc8e..4a6e7aa094 100644 --- a/app/test-compress-perf/comp_perf_test_cyclecount.c +++ b/app/test-compress-perf/comp_perf_test_cyclecount.c @@ -175,7 +175,8 @@ main_loop(struct cperf_cyclecount_ctx *ctx, enum rte_comp_xform_type type) /* one array for both enqueue and dequeue */ ops = rte_zmalloc_socket(NULL, - 2 * mem->total_bufs * sizeof(struct rte_comp_op *), + (test_data->burst_sz + mem->total_bufs) * + sizeof(struct rte_comp_op *), 0, rte_socket_id()); if (ops == NULL) { @@ -184,7 +185,7 @@ main_loop(struct cperf_cyclecount_ctx *ctx, enum rte_comp_xform_type type) return -1; } - deq_ops = &ops[mem->total_bufs]; + deq_ops = &ops[test_data->burst_sz]; if (type == RTE_COMP_COMPRESS) { xform = (struct rte_comp_xform) { -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-09 16:30:08.657693009 +0000 +++ 0002-app-compress-perf-optimize-operations-pool-allocatio.patch 2022-03-09 16:30:08.483023722 +0000 @@ -1 +1 @@ -From 68d3287f4ef43318728e4a134b7aa33d5c52b12d Mon Sep 17 00:00:00 2001 +From c30254b5da1b5033462ab40450cce4fc7cb18088 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 68d3287f4ef43318728e4a134b7aa33d5c52b12d ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index c215547291..a3f6404eb2 100644 +index 9ade89fc8e..4a6e7aa094 100644