From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC546A0093 for ; Wed, 9 Mar 2022 17:32:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6F224013F; Wed, 9 Mar 2022 17:32:43 +0100 (CET) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mails.dpdk.org (Postfix) with ESMTP id 990D94013F for ; Wed, 9 Mar 2022 17:32:42 +0100 (CET) Received: by mail-wr1-f54.google.com with SMTP id i8so3915930wrr.8 for ; Wed, 09 Mar 2022 08:32:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y9nRN1qrSQrAlVEkDUnED3Gxaj/Gjk6ZPkBb3svVj+Y=; b=lYlnPWRITPxcIyz1vXjj8x4B07+jT/1JHXZcR0vGk/l6/FXn5bAVM0MuU7+DSxpyUo r1mXBQH+ebw6XeujPVRs+LhSVxtxHxiJUWKSBhw8iM56FGBKMtV2L11lMqyQQcMa50bw U3UpHYyqmRneAwyGudgimtgx2MpUyyjyYRFwMDtGEhy/Um+DJJnE83FDGtQWb4l5eMMC ER5x4hZA/xw4YR36awM6SnRYLc4sXBwKjmiHrEh9SNHXD3PRuiY7talSUNs02O1vqqNn iEeaCKqtgBgYteAcJZ4Gs7gLVd3QivqkB9mSuEO3Kni4kWaxZBzYVJRKvrGGrGPb+i7v Eg3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y9nRN1qrSQrAlVEkDUnED3Gxaj/Gjk6ZPkBb3svVj+Y=; b=Kn6vISwmxAS/hDa5zXxTkVeAuNUQHViklh+7gbBkZHO7MPIhLtHf4PoBmEpNvj8ThO FjkYfMBYKs0f27a2ArVEfmep1QxjQbIuo4oI5JVdY8PJY8GlasuKWT9b1aW848GlfZSc GEAN/AFti0L28R1OpGYTdQGADoRMW+ZfyPYufpJUA6UH160bE8KJADrIDG0F0zqLbjy/ Hm41T4ighHYOFdl4WMdIomP6g3ZlKJBy3lPQv85lyUcPOYjrckPAzBsloTuwiz+4kidb fAndT2Avpid3ocEcDmJ97OKsJHNH8xRougH1AXddHRyJMTzFp0vrnKOLuH7ksnWkeG4l DBSw== X-Gm-Message-State: AOAM533hby/xTMQKbSMOXs9wwyWajbi8w1BHPvQtyhxvJAt0Nx/l+jRF 0eIZqhMq1BO2bP/HQKkTu7nZkzJ3hWM= X-Google-Smtp-Source: ABdhPJzgf6Vr+ZDdtvRRlvyKUcj7Vix6gpqrYjf81JiojRd0lChd6O7IpeP1KT1JTPlRvuGO4FKlyw== X-Received: by 2002:a5d:4bcc:0:b0:1f1:d6f8:89f5 with SMTP id l12-20020a5d4bcc000000b001f1d6f889f5mr317661wrt.713.1646843562362; Wed, 09 Mar 2022 08:32:42 -0800 (PST) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id n20-20020a05600c501400b0038995ede299sm2103774wmr.17.2022.03.09.08.32.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 08:32:41 -0800 (PST) From: luca.boccassi@gmail.com To: Bing Zhao Cc: Matan Azrad , dpdk stable Subject: patch 'net/mlx5: remove unused reference counter' has been queued to stable release 20.11.5 Date: Wed, 9 Mar 2022 16:30:50 +0000 Message-Id: <20220309163053.245754-34-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220309163053.245754-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-1-luca.boccassi@gmail.com> <20220309163053.245754-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/11/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/b4de25642a7eb5c0f9111e1e5ad84935fa88e988 Thanks. Luca Boccassi --- >From b4de25642a7eb5c0f9111e1e5ad84935fa88e988 Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Wed, 2 Mar 2022 09:57:35 +0200 Subject: [PATCH] net/mlx5: remove unused reference counter [ upstream commit cff6aad7af61da8d31e146610f9b4a4875301ef4 ] In the previous implementation, a count was used to record the number of the references to a table resource, including the creation of the table, the jumping to the table and the matchers created on the table. Before releasing the table resource via the driver, it needed to ensure that there is no reference to this table. After the optimization of the resources management, the reference count now is in the hash list entry as a unified solution for all the resources management. There is no need to keep the "refcnt" in the table resource structure. It is removed in case that there is some unnecessary memory overhead. Fixes: afd7a62514ad ("net/mlx5: make flow table cache thread safe") Signed-off-by: Bing Zhao Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 00713d6647..b18fffea52 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -585,7 +585,6 @@ union mlx5_flow_tbl_key { /* Table structure. */ struct mlx5_flow_tbl_resource { void *obj; /**< Pointer to DR table object. */ - uint32_t refcnt; /**< Reference counter. */ }; #define MLX5_MAX_TABLES UINT16_MAX -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-09 16:30:09.798729457 +0000 +++ 0034-net-mlx5-remove-unused-reference-counter.patch 2022-03-09 16:30:08.603026407 +0000 @@ -1 +1 @@ -From cff6aad7af61da8d31e146610f9b4a4875301ef4 Mon Sep 17 00:00:00 2001 +From b4de25642a7eb5c0f9111e1e5ad84935fa88e988 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit cff6aad7af61da8d31e146610f9b4a4875301ef4 ] + @@ -21 +22,0 @@ -Cc: stable@dpdk.org @@ -30 +31 @@ -index 0f0045a2b5..dd5cd9209f 100644 +index 00713d6647..b18fffea52 100644 @@ -33 +34 @@ -@@ -993,7 +993,6 @@ union mlx5_flow_tbl_key { +@@ -585,7 +585,6 @@ union mlx5_flow_tbl_key {