From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16C32A0093 for ; Wed, 9 Mar 2022 17:32:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11F4D4013F; Wed, 9 Mar 2022 17:32:56 +0100 (CET) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mails.dpdk.org (Postfix) with ESMTP id 226C74013F for ; Wed, 9 Mar 2022 17:32:55 +0100 (CET) Received: by mail-wr1-f47.google.com with SMTP id t11so3925192wrm.5 for ; Wed, 09 Mar 2022 08:32:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6rnelmWc649auOjK0UM/rbg20VQVV1LHWOuWQsUr2oE=; b=OMOtPYYvSWvL11K4Svbo+V638AUovPIa2NUwUx2QLQq4dzWL0yFJdTgbiHZ6RWdGyF dfyLuxLbEv92/gHwr98xisCp7kEkSFwoPaaiKH9sKHU0wKvcmMh2XdZfV5Dncp4qdNjA Wdx+4mNslKcvrGlnv258ANw+7UA61brCLtlcklzOGMR9WiuHiqrP2IdFl4RRuYxd7f+I j2Z8CDZeBxwTfseXQSOusR0clcP6EqY7eTAcbtNZSoMX6zzkVa8KeoZIusgdspV4A2fC qauNmSeuIEs3Cp/ZauwN034LlOI1//1PIV9SC/cODxEPjwX1lgBgZw/uH61vQ1xVbVnj 3V3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6rnelmWc649auOjK0UM/rbg20VQVV1LHWOuWQsUr2oE=; b=m1Yh+z+5IAWO/g3ju0Uh2rCXKUcnRBGHYn0GEGKYeggHPCa6D4DtKn9Q2LnvhT6g3c zz9fVgbr+EbmxzfM3BXRLIQ3voI5CmQ89gx8HlJaGyWVSfE+U2RYn0fZ17uHzUilSoL8 r1Tt2NHSUOPewShwLOcoX1nSGRrQIJ705yt02LLHOJ0AXEnNHFaOXKvsoqWM4NDTJ24R V5STNc8oFupweiTVH1ZoPfP1pF+lEy5jcRtwiSQTaJQ38he7YJKCggCODOH4mwx/UoxC U5mWX8P1kV6/xYXIQlTTYhF6YQp9yqqi8rjvb9DPnP4HnUvRvX6p1vr6fqlx1OC8px/+ 8T7Q== X-Gm-Message-State: AOAM5306P2f022XHXzb9FSbLxrZPh+RvdCLqHcRtZbXKEKSHO709wt47 KB9cY78Amu+jgjkDVWxHlFo= X-Google-Smtp-Source: ABdhPJyoMFAKpMxbht9sm6dCx921MJUASJOWACQq3x0RPsHS/G13xEYsuSRMlH3EjoAVtSd4rbL6fg== X-Received: by 2002:adf:e70e:0:b0:1f0:6588:1688 with SMTP id c14-20020adfe70e000000b001f065881688mr353222wrm.73.1646843574866; Wed, 09 Mar 2022 08:32:54 -0800 (PST) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id f4-20020a5d4dc4000000b001d8e67e5214sm2088235wru.48.2022.03.09.08.32.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 08:32:54 -0800 (PST) From: luca.boccassi@gmail.com To: Leyi Rong Cc: Ferruh Yigit , dpdk stable Subject: patch 'net/iavf: fix potential out-of-bounds access' has been queued to stable release 20.11.5 Date: Wed, 9 Mar 2022 16:30:52 +0000 Message-Id: <20220309163053.245754-36-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220309163053.245754-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-1-luca.boccassi@gmail.com> <20220309163053.245754-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/11/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/0c41b6164a61495b57976c5b26f240785e7eebc4 Thanks. Luca Boccassi --- >From 0c41b6164a61495b57976c5b26f240785e7eebc4 Mon Sep 17 00:00:00 2001 From: Leyi Rong Date: Tue, 8 Mar 2022 13:56:17 +0800 Subject: [PATCH] net/iavf: fix potential out-of-bounds access [ upstream commit d78d21b983f215d1425422f955cbd934e48360d3 ] Fix potential out-of-bounds access as overrunning callee's array of size 26 by passing argument rxq->rxdid(which evaluates to 63) in call to iavf_rx_scan_hw_ring_flex_rxd. Coverity issue: 376616 Fixes: 0ed16e01313e ("net/iavf: fix function pointer in multi-process") Signed-off-by: Leyi Rong Reviewed-by: Ferruh Yigit --- drivers/net/iavf/iavf_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 6243199f2a..c8fa912b99 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -440,7 +440,7 @@ iavf_rxd_to_pkt_fields_by_comms_aux_v2(struct iavf_rx_queue *rxq, } static const -iavf_rxd_to_pkt_fields_t rxd_to_pkt_fields_ops[] = { +iavf_rxd_to_pkt_fields_t rxd_to_pkt_fields_ops[IAVF_RXDID_LAST + 1] = { [IAVF_RXDID_COMMS_AUX_VLAN] = iavf_rxd_to_pkt_fields_by_comms_aux_v1, [IAVF_RXDID_COMMS_AUX_IPV4] = iavf_rxd_to_pkt_fields_by_comms_aux_v1, [IAVF_RXDID_COMMS_AUX_IPV6] = iavf_rxd_to_pkt_fields_by_comms_aux_v1, -- 2.30.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-09 16:30:09.863355704 +0000 +++ 0036-net-iavf-fix-potential-out-of-bounds-access.patch 2022-03-09 16:30:08.607026496 +0000 @@ -1 +1 @@ -From d78d21b983f215d1425422f955cbd934e48360d3 Mon Sep 17 00:00:00 2001 +From 0c41b6164a61495b57976c5b26f240785e7eebc4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d78d21b983f215d1425422f955cbd934e48360d3 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index cb779879cb..16e8d021f9 100644 +index 6243199f2a..c8fa912b99 100644 @@ -24 +25 @@ -@@ -476,7 +476,7 @@ iavf_rxd_to_pkt_fields_by_comms_aux_v2(struct iavf_rx_queue *rxq, +@@ -440,7 +440,7 @@ iavf_rxd_to_pkt_fields_by_comms_aux_v2(struct iavf_rx_queue *rxq,