From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2ECCAA0093 for ; Thu, 10 Mar 2022 13:12:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29A1B4113E; Thu, 10 Mar 2022 13:12:19 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 69DBC4114F for ; Thu, 10 Mar 2022 13:12:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646914336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=91n+FXjtf/t+2NgHJ/vhDQtxV4CmGRReKrjN0q/0HrQ=; b=YWa2lJ0yvegY7r2s/eCqWlp+cNh5nbk4xsPsq4xJrzVJqUd9A3D40+N0id9ZQpj0tyOo5I iSFcWTHYNUxN9oolNz5LSmNJ0xaKPy2L4EcYBF+dACX9rj/ohQLwLZN3uCDTb11GmH27NA qidevJrCSCn+NT2fQ0U787UG2Z+XpcA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-425-KDaWUK9XPgmJcSpRJe-PfA-1; Thu, 10 Mar 2022 07:12:12 -0500 X-MC-Unique: KDaWUK9XPgmJcSpRJe-PfA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2C5BE801AB2; Thu, 10 Mar 2022 12:12:11 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.75]) by smtp.corp.redhat.com (Postfix) with ESMTP id 21C722D1F8; Thu, 10 Mar 2022 12:12:09 +0000 (UTC) From: Kevin Traynor To: Gregory Etelson Cc: Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix flex item availability' has been queued to stable release 21.11.1 Date: Thu, 10 Mar 2022 12:11:18 +0000 Message-Id: <20220310121127.1324802-12-ktraynor@redhat.com> In-Reply-To: <20220310121127.1324802-1-ktraynor@redhat.com> References: <20220310121127.1324802-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/14/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/48fe9efaf2fb974e3f805eb7c54440ec3818a4b6 Thanks. Kevin --- >From 48fe9efaf2fb974e3f805eb7c54440ec3818a4b6 Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Wed, 2 Mar 2022 13:06:42 +0200 Subject: [PATCH] net/mlx5: fix flex item availability [ upstream commit 71adf25dbfb3a60731bd922342cc0f171714db81 ] Flex item availability is restricted to BlueField-2 and BlueField-3 PF ports. The patch validates port type compliance before proceeding to flex item creation. Fixes: db25cadc0887 ("net/mlx5: add flex item operations") Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/linux/mlx5_common_os.h | 1 + drivers/net/mlx5/mlx5_flow.c | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/drivers/common/mlx5/linux/mlx5_common_os.h b/drivers/common/mlx5/linux/mlx5_common_os.h index 83066e752d..2e4ac09bbf 100644 --- a/drivers/common/mlx5/linux/mlx5_common_os.h +++ b/drivers/common/mlx5/linux/mlx5_common_os.h @@ -10,4 +10,5 @@ #include +#include #include #include diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 5b36cfa042..41a648ff3f 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -9854,8 +9854,25 @@ mlx5_flow_flex_item_create(struct rte_eth_dev *dev, { static const char err_msg[] = "flex item creation unsupported"; + struct mlx5_priv *priv = dev->data->dev_private; struct rte_flow_attr attr = { .transfer = 0 }; const struct mlx5_flow_driver_ops *fops = flow_get_drv_ops(flow_get_drv_type(dev, &attr)); + if (!priv->pci_dev) { + rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, + "create flex item on PF only"); + return NULL; + } + switch (priv->pci_dev->id.device_id) { + case PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF: + case PCI_DEVICE_ID_MELLANOX_CONNECTX7BF: + break; + default: + rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, + "flex item available on BlueField ports only"); + return NULL; + } if (!fops->item_create) { DRV_LOG(ERR, "port %u %s.", dev->data->port_id, err_msg); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-10 12:05:31.815513907 +0000 +++ 0019-net-mlx5-fix-flex-item-availability.patch 2022-03-10 12:05:31.314630891 +0000 @@ -1 +1 @@ -From 71adf25dbfb3a60731bd922342cc0f171714db81 Mon Sep 17 00:00:00 2001 +From 48fe9efaf2fb974e3f805eb7c54440ec3818a4b6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 71adf25dbfb3a60731bd922342cc0f171714db81 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index a85f3b5f3c..27f1192205 100644 +index 83066e752d..2e4ac09bbf 100644 @@ -33 +34 @@ -index 15a4a8cd98..ffcaef0baa 100644 +index 5b36cfa042..41a648ff3f 100644 @@ -36 +37 @@ -@@ -10631,8 +10631,25 @@ mlx5_flow_flex_item_create(struct rte_eth_dev *dev, +@@ -9854,8 +9854,25 @@ mlx5_flow_flex_item_create(struct rte_eth_dev *dev,