From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 653D2A0093 for ; Thu, 10 Mar 2022 13:12:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FD8641140; Thu, 10 Mar 2022 13:12:20 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AE66F4113E for ; Thu, 10 Mar 2022 13:12:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646914338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tFeW6Zvl6LLaitINvuMmFCl37OvYg+iO2RROwOvYlB0=; b=MNKCRAq2o5GhBaPTN0FMjOJvUwpqaBTsdSlb+ZoXDd99rR03VjMF76lM9zZumMSda/lK79 gKe5axi0zs5ZKpxrLbZppLcPCQQTLGDyDcbTap3L7TekjnNMUULJ4/xiZBEuGzsVBxVlEk 2o62DjpflZXyy0brPK5E90HL8xpBO4I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-262-NPPHQFt7Ni-KCkJcfQKVww-1; Thu, 10 Mar 2022 07:12:15 -0500 X-MC-Unique: NPPHQFt7Ni-KCkJcfQKVww-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0D91CC28E; Thu, 10 Mar 2022 12:12:14 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.75]) by smtp.corp.redhat.com (Postfix) with ESMTP id 03FD52D1F8; Thu, 10 Mar 2022 12:12:12 +0000 (UTC) From: Kevin Traynor To: Bing Zhao Cc: Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix configuration without Rx queue' has been queued to stable release 21.11.1 Date: Thu, 10 Mar 2022 12:11:20 +0000 Message-Id: <20220310121127.1324802-14-ktraynor@redhat.com> In-Reply-To: <20220310121127.1324802-1-ktraynor@redhat.com> References: <20220310121127.1324802-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/14/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a17cea76b791059e9489a7892349fdce89c48bd8 Thanks. Kevin --- >From a17cea76b791059e9489a7892349fdce89c48bd8 Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Thu, 3 Mar 2022 17:26:58 +0200 Subject: [PATCH] net/mlx5: fix configuration without Rx queue [ upstream commit 3ef18940ef13fe8cb307aba0dba2bc316fb873a2 ] None Rx queue configured in a DPDK application should be supported. In this mode, the NIC can be used to generate packets without receiving any ingress traffic. In the current implementation, once there is no Rx queue specified, the array to store the queues' pointers is NULL after allocation. Then the checking of the array allocation prevents the application from starting up. By adding another condition checking of the Rx queue number, the application with none Rx queue can start up successfully. Fixes: 4cda06c3c35e ("net/mlx5: split Rx queue into shareable and private") Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index dc647d5580..9c44471c42 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -110,5 +110,5 @@ mlx5_dev_configure(struct rte_eth_dev *dev) sizeof(void *) * rxqs_n, 0, SOCKET_ID_ANY); - if (priv->rxq_privs == NULL) { + if (rxqs_n && priv->rxq_privs == NULL) { DRV_LOG(ERR, "port %u cannot allocate rxq private data", dev->data->port_id); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-10 12:05:31.861525946 +0000 +++ 0021-net-mlx5-fix-configuration-without-Rx-queue.patch 2022-03-10 12:05:31.316630896 +0000 @@ -1 +1 @@ -From 3ef18940ef13fe8cb307aba0dba2bc316fb873a2 Mon Sep 17 00:00:00 2001 +From a17cea76b791059e9489a7892349fdce89c48bd8 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3ef18940ef13fe8cb307aba0dba2bc316fb873a2 ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index de0ba2b1ff..05c919ed39 100644 +index dc647d5580..9c44471c42 100644 @@ -31 +32 @@ -@@ -112,5 +112,5 @@ mlx5_dev_configure(struct rte_eth_dev *dev) +@@ -110,5 +110,5 @@ mlx5_dev_configure(struct rte_eth_dev *dev)