From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E29EA0093 for ; Thu, 10 Mar 2022 13:12:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28A564113E; Thu, 10 Mar 2022 13:12:30 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 965434113F for ; Thu, 10 Mar 2022 13:12:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646914348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G1E+P/7xzM+Yoto0zxKeG158dFOduiTseGa2rlTsIuY=; b=U3RcG+qK2eZWlcDOClLymSQM9x6TFNWaATlqNNkBty4daJV2wp+HXcjLfZphSrGRvtgM3h uXjOvUtlK2WAnEu5fkmKKRvO0OD2mdsgcKe8IbKsUd65m+Wv2uB6PTAlPljJklqjDhLjE1 6sy25Mtzvhyi06kW26uJIRleLpka+vA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-403-4OnpC6pdNq6hFy4krD2l7Q-1; Thu, 10 Mar 2022 07:12:26 -0500 X-MC-Unique: 4OnpC6pdNq6hFy4krD2l7Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 346B9C292; Thu, 10 Mar 2022 12:12:25 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.75]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0FE112D1F8; Thu, 10 Mar 2022 12:12:23 +0000 (UTC) From: Kevin Traynor To: Thomas Monjalon Cc: Usama Arif , dpdk stable Subject: patch 'devtools: fix symbols check' has been queued to stable release 21.11.1 Date: Thu, 10 Mar 2022 12:11:27 +0000 Message-Id: <20220310121127.1324802-21-ktraynor@redhat.com> In-Reply-To: <20220310121127.1324802-1-ktraynor@redhat.com> References: <20220310121127.1324802-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/14/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/efd091d5417b702cd63845ab99bd66da39dcdd1d Thanks. Kevin --- >From efd091d5417b702cd63845ab99bd66da39dcdd1d Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Tue, 8 Mar 2022 22:02:48 +0100 Subject: [PATCH] devtools: fix symbols check [ upstream commit 272f94e58b01a904b5d8cf66649512b0d62f1a8c ] In some environments, the check of local symbols catch-all was failing. Note: this script is called during the build. The reason is that grep returns an error if nothing is found. The option -e of the shell script makes this error fatal. It is not always fatal because the grep is in a command substitution. Fixes: b403498e1422 ("build: hide local symbols in shared libraries") Reported-by: Usama Arif Signed-off-by: Thomas Monjalon --- devtools/check-symbol-maps.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh index 8266fdf9ea..32e1fa5c8f 100755 --- a/devtools/check-symbol-maps.sh +++ b/devtools/check-symbol-maps.sh @@ -54,5 +54,5 @@ if [ -n "$duplicate_symbols" ] ; then fi -local_miss_maps=$(grep -L 'local: \*;' $@) +local_miss_maps=$(grep -L 'local: \*;' $@ || true) if [ -n "$local_miss_maps" ] ; then echo "Found maps without local catch-all:" -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-10 12:05:32.004827182 +0000 +++ 0028-devtools-fix-symbols-check.patch 2022-03-10 12:05:31.323630914 +0000 @@ -1 +1 @@ -From 272f94e58b01a904b5d8cf66649512b0d62f1a8c Mon Sep 17 00:00:00 2001 +From efd091d5417b702cd63845ab99bd66da39dcdd1d Mon Sep 17 00:00:00 2001 @@ -4,0 +5,2 @@ + +[ upstream commit 272f94e58b01a904b5d8cf66649512b0d62f1a8c ]