From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC632A0093 for ; Fri, 11 Mar 2022 08:49:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3D9E40042; Fri, 11 Mar 2022 08:49:47 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2089.outbound.protection.outlook.com [40.107.223.89]) by mails.dpdk.org (Postfix) with ESMTP id D0BCF40F35 for ; Fri, 11 Mar 2022 08:49:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jlB+Bz8W1WYPyszps93FgHahemFCWQ+MOak0+I5yj978gokESgcYxdJW4NLqKGElonpWPclf4+c5X5xSN0jzh6WeUa+kZVb6Too+8JfZ2kwxE3tMu0wpyJlotuXY6nBLfV+zctu/GmCUtwbj8n0V2ypRRFMpHcW5eaVU+7n+B9nN4V6EnoiHzq1NbsSG9OQVhu1Lwr3EbY4tsHzZ8AmzIHKDItOTE5pFvgV6cZswvPszYnqBXF2zfdujN+5B9B1tQyz8VcYu4PNdavuM+fKSw83uC0Fa8qxPvdavC+vzJqgPrlfhsxZZE4QVUasvdro8nmP2zn3XIn48NTnGUSrwPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r1TmhhIFZjzlxjykFEspAtK9rEKQlt46ktGjDN+xFHc=; b=Li0OYYlrVEkdvhSR8Bf0+LLnWPlCDKNvIcSv466GWcUXG7runf4C56uYUDM3bmNqHot9FnLPZqq5a7ILxt0azCyQML3bg1we/+ny4xG/6f62aITmtiSaYw+lPtAna2hWMVvL/sOV4WCVuuhtNtISlLUk/9+TXvXTQ3UCPHX0nOjPmZlYzTwdnI5iEQJWt1glnLmAG+Y8KLkuv6SgjeMCAI9trGUSlA8CLa2HfsWE19ND4oLDIukqbUNMy8Sbm6F6he6DEPK51gGg5+nT3mNAL2o489J8XyKYRT5Av5XE72x95kyBzy86oa5kewq6Lh6pRCuTT3g6lb/1SIne5zqpbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.234) smtp.rcpttodomain=debian.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r1TmhhIFZjzlxjykFEspAtK9rEKQlt46ktGjDN+xFHc=; b=l+dyhCrbAdHeR6x0IrVovgWKHtxJsS9A6XqV76neULfvsq9ERxl5Q+bEQYNgag52I44PfRAHFUQ1WiYQHDSbZQJ6aXh+QPbgLAiD/st+v7LLrhGqoK148m/v4xglrs/PAuy295Ffx8X4+ro0XGCNt6zkSJqO/xvlL9J7qqjEFm/dpp7s7RxyawNNS233HkG9RBuE0ZUnxCftTGe4zXc+8O+MvvLduYOYnHapPBA2akrqIHJLpEq3HZ8e1Kbw2aM/NuzIKP/+pnFrFk/q38/XOh0hRuisc2LoX3FQGE1eDl69nceuJGmMfuq+3PnjgdSTgtYreLQlcunZY0vFw1r8yg== Received: from CO2PR04CA0169.namprd04.prod.outlook.com (2603:10b6:104:4::23) by MW2PR12MB2522.namprd12.prod.outlook.com (2603:10b6:907:f::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Fri, 11 Mar 2022 07:49:42 +0000 Received: from CO1NAM11FT049.eop-nam11.prod.protection.outlook.com (2603:10b6:104:4:cafe::33) by CO2PR04CA0169.outlook.office365.com (2603:10b6:104:4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22 via Frontend Transport; Fri, 11 Mar 2022 07:49:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.234) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.234 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.234; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.234) by CO1NAM11FT049.mail.protection.outlook.com (10.13.175.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5061.22 via Frontend Transport; Fri, 11 Mar 2022 07:49:42 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by DRHQMAIL101.nvidia.com (10.27.9.10) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Fri, 11 Mar 2022 07:49:41 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 10 Mar 2022 23:49:40 -0800 Received: from nvidia.com (10.127.8.11) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.986.22 via Frontend Transport; Thu, 10 Mar 2022 23:49:39 -0800 From: Dmitry Kozlyuk To: CC: Luca Boccassi Subject: [PATCH 20.11 3/3] net/mlx5: fix initial link status detection Date: Fri, 11 Mar 2022 09:49:33 +0200 Message-ID: <20220311074933.1194679-4-dkozlyuk@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220311074933.1194679-1-dkozlyuk@nvidia.com> References: <20220311074933.1194679-1-dkozlyuk@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f7679a8b-74a6-4c54-c366-08da0333b41c X-MS-TrafficTypeDiagnostic: MW2PR12MB2522:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HXuqhKUcYBM9nF/vjbNjeO4Nwu3LCaskYkQ4Jnc1AST2pfjZVUDboZ57OVWx5keb0ybJ69iVq0BP3IZuNhYjLaA495bL43I0YFlq8Mqp6pCIe3rrILVHCs+C1M99lyfePBXoZPiWnO/nM9I24rz+UVruiiwlGiwnNw2r5PLiZEhmpIGCB0hOr7/JskN/JGK6EXheUuT6GsGOTB7hjYouDhhVUwD8+wVFN1Hkw1dBASwwPhwszClvUN7ZtDKdPdtI9okKVqutZO7YfULaP+Ybxvvbp8RhEQ3StwsLCCHxja/KtP+UPjxwXh9TxKhEbzpXxJ5T1Yk6Zunsg/3+Hl3/aWe7My152iSvki5gmzAFtPswYri7TRXMCYrsl4pCmpBVXzaHpJkCqNOfM/alTxuobk80tY/78RJWSfzyTAu2hc2VWgnOFv2GJAqPuBHZNGFdd/sa2jxiJwTY46rQs1I9umSb0nJv0otqZ1tzGF+tg2XF62z5PSehE0r9Rf1FlrzkWdEFDsLN8HAt1MQqYVcKIg8SLIBBf8bKHj/bcP9YW2rYy8pQLRFyYinywk83XvXtxVuoyrOw3AbMXxyIc7K1OupU/d0SZQrcdsf4iOZ5x1b9nTaqTXK0TC+IUt8yHmpX6FyGxPuV2wiLRP3/5iCnp24Z6Qvy1LA9cPxG8/Jv7uAtNoe3xltNUXV9bzvZGre8CZ4V6Jb8msOJ+qCGq5s1hQ== X-Forefront-Antispam-Report: CIP:12.22.5.234; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(2616005)(83380400001)(6286002)(6916009)(82310400004)(47076005)(26005)(336012)(55016003)(426003)(40460700003)(316002)(508600001)(86362001)(7696005)(6666004)(186003)(8936002)(8676002)(4326008)(36756003)(5660300002)(81166007)(356005)(36860700001)(70586007)(2906002)(70206006)(1076003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 07:49:42.5095 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f7679a8b-74a6-4c54-c366-08da0333b41c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.234]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT049.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2522 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [ upstream commit 655c3c26c11e7a6f1b5421afe40b06d580b8f2dd ] Link status change takes time that depends on the HW and the kernel. It was checked immediately after the change was issued at probing. If the port had beed down before probing, a "down" state may be read, while the port would be "up" imminently. After that, DPDK reported the port as "down" mistakenly and "ifconfig $DEV up" did not trigger an LSC event, because from the system's perspective the port was "up" already. Install Netlink event handler at port probe before requesting the port to come up in order to receive LSC event even if it comes up between probe and start. Fixes: b6499434b83e ("net/mlx5: fix link status initialization") Signed-off-by: Dmitry Kozlyuk --- drivers/net/mlx5/linux/mlx5_os.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index 0e738d4a59..f98cf90dd8 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -1519,13 +1519,11 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, /* Bring Ethernet device up. */ DRV_LOG(DEBUG, "port %u forcing Ethernet interface up", eth_dev->data->port_id); - mlx5_set_link_up(eth_dev); - /* - * Even though the interrupt handler is not installed yet, - * interrupts will still trigger on the async_fd from - * Verbs context returned by ibv_open_device(). - */ mlx5_link_update(eth_dev, 0); + /* Watch LSC interrupts between port probe and port start. */ + priv->sh->port[priv->dev_port - 1].nl_ih_port_id = + eth_dev->data->port_id; + mlx5_set_link_up(eth_dev); /* Detect minimal data bytes to inline. */ mlx5_set_min_inline(spawn, config); /* Store device configuration on private structure. */ -- 2.25.1