From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FFD5A00BE for ; Tue, 15 Mar 2022 12:37:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A2864014F; Tue, 15 Mar 2022 12:37:14 +0100 (CET) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by mails.dpdk.org (Postfix) with ESMTP id 108D840150 for ; Mon, 14 Mar 2022 15:47:10 +0100 (CET) Received: by mail-lj1-f172.google.com with SMTP id 17so20140906lji.1 for ; Mon, 14 Mar 2022 07:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+6Q+9DDZh439aEJwFmvP9Otbn1uUPELBDF9S0qY7Tok=; b=vTBmS23bZG3fx4HeI7LPByywG6JAJ4VJS1bfvk4ojPFFioBfaHWJVarQKYR5I8KjVG +upBByIqS8oiTz0NzMtq2826RGqH+WtLNseSwPG7wQSRY1GDV6YpBn8E86xOy6xkzfJP kWD358l9PIy2OIOfFgqIwu2ZfPMpEfUsqZiVoI/GVUi3hKR9bvur953a2sM58hJ9L+Nw /xs8LIcqwh6Hgm9HGDjAKBzoAKhcIGQC0/A3xMML9SJp+m1V+1v68AbXoXMXKvpxM2Nf 3KhJgena/SniooKOheahceI1n3UdxsbXB0Zwv8eqy0T9SD71VXPkyH36zBhXoXF6ORgQ JAsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+6Q+9DDZh439aEJwFmvP9Otbn1uUPELBDF9S0qY7Tok=; b=g54cD7HHL6jF+jH9l7eQY22vx1R0m67kiE9XCxkaO6DSrpF/X/2DVsJXl99zFnU4O3 CveG2awbTnvH8GZrfZcQ8Tget5v5eX+dSmKLXOpIkC5DQ0ifPEiuii/TgP5TS/r9FiII 3unE4eFeDN0S45s4JKwJaUttIV2UfiDtVJVJPi6nZt7FZhzc84jn7RZTAOLSLOuTCUBN rQXyrMvzrPFHs/stpOqVKjAThIgbnH57g2cvh5dZhKrYWi79R0sdPm1pXHO0vYjbpGgx AkFNEY5h8GSv9CwZc8wO8BgEdJAW1eTgAnJwFDWt248X4l8SCbCX63kzIdcxJw7IMXaU kjzA== X-Gm-Message-State: AOAM532ZtxdBQSQiQNGhzaD3gTlDRfh46/eh4lQFihe8tHNi4IZg+2pU f2n/yBdnlD7bMK+rgD8uWeVE4fx2JE/Oyw== X-Google-Smtp-Source: ABdhPJwDpPqnBHDlvzRjVfa40wRO7aZ2whIDIcmn+01d1I9fgu0Ag2plfI1htlTt37pseHFBc0Ufjg== X-Received: by 2002:a05:651c:1543:b0:249:218f:2228 with SMTP id y3-20020a05651c154300b00249218f2228mr9340876ljp.492.1647269229155; Mon, 14 Mar 2022 07:47:09 -0700 (PDT) Received: from dgr-desktop.office.semihalf.net ([83.142.187.84]) by smtp.gmail.com with ESMTPSA id j15-20020a2e3c0f000000b00247e9bafa20sm4003518lja.99.2022.03.14.07.47.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Mar 2022 07:47:08 -0700 (PDT) From: Dawid Gorecki To: stable@dpdk.org Cc: Dawid Gorecki , Michal Krawczyk , Shai Brandes Subject: [PATCH 19.11 1/2] net/ena: check memory BAR before initializing LLQ Date: Mon, 14 Mar 2022 15:42:34 +0100 Message-Id: <20220314144228.2475-1-dgr@semihalf.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Tue, 15 Mar 2022 12:37:12 +0100 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [ upstream commit 9ae7a13f8247319f63402107c8304ba57c3f4308 ] The ena_com_config_dev_mode() performs many calculations related to LLQ and then performs an admin queue call to configure LLQ in the device. All of the operations performed by ena_com_config_dev_mode() are unnecessary if membar hasn't been found. Move the dev_mem_base check before ena_com_config_dev_mode() call. This prevents the unnecessary operations from being performed. Fixes: 2fca2a98c0d1 ("net/ena: support LLQv2") Cc: stable@dpdk.org Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 7601d2fa25..dc30370a8f 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1637,6 +1637,13 @@ ena_set_queues_placement_policy(struct ena_adapter *adapter, return 0; } + if (adapter->dev_mem_base == NULL) { + PMD_DRV_LOG(ERR, + "LLQ is advertised as supported, but device doesn't expose mem bar\n"); + ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST; + return 0; + } + rc = ena_com_config_dev_mode(ena_dev, llq, llq_default_configurations); if (unlikely(rc)) { PMD_INIT_LOG(WARNING, "Failed to config dev mode. " @@ -1649,13 +1656,6 @@ ena_set_queues_placement_policy(struct ena_adapter *adapter, if (ena_dev->tx_mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_HOST) return 0; - if (!adapter->dev_mem_base) { - PMD_DRV_LOG(ERR, "Unable to access LLQ bar resource. " - "Fallback to host mode policy.\n."); - ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST; - return 0; - } - ena_dev->mem_bar = adapter->dev_mem_base; return 0; -- 2.35.1