From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0F66A00BE for ; Tue, 15 Mar 2022 14:32:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA40D4014F; Tue, 15 Mar 2022 14:32:44 +0100 (CET) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by mails.dpdk.org (Postfix) with ESMTP id 9211F4014F for ; Tue, 15 Mar 2022 14:32:43 +0100 (CET) Received: by mail-ej1-f52.google.com with SMTP id gb39so40883896ejc.1 for ; Tue, 15 Mar 2022 06:32:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=byGLkzHGceZojZyi/NPimHcmvUfOUEyZS+fxgYgsSdQ=; b=KDBir0kcFtNQPOYxM/ATpyX9nUjE3mCz4VnoedGwzplydRAw7fj0l1BfmUI0C5gKAs Eq4zd1lYbYxvO2fX3Ho4POnHAz9ZjxAXqJBlvnbucG0vad242EpKdOk8H248p8FAMwL/ ZNuTRFIYdY/Jv5htTF98JFEUggFw3ZD5KRCNRfVTTVJZtS44cQ++uEzIBo6ivQGf/QC/ Rz1/D8pXnevMDHKKOLselbeSKiT9koAYgbNoGpmRxwqi4Jrggu1rBJw+4za27POn2gsZ icviTawLyl2XaQQK8ouiQalWxkiFZzfgNQ82p164ZvW65JZlJYoIHeerJRq6Ea53FGEs lC0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=byGLkzHGceZojZyi/NPimHcmvUfOUEyZS+fxgYgsSdQ=; b=6nsaL7OMgTEWAG9BgWN6OdtXMaw9KDZvt3BqQQwmHGF2R6GEf7337Q/mOg5ClgVXQA dtslvJGc3dIIMOxP1uqPUpKmm+RGDRI0h6VHuL9JyJerhtbBq4hFVLqSE3y31peyDJSU f01SXPPe9VfQbbxfnsnVY3b9Eep7BCGirEOJC6Myj7qxTFsHgPM6PBRrcAYYGkOBRscx LUEMWy6CmY1lH1uQE2R2LfeaIBYeZBf43MV2ljtKAYzv+2821s1MMLsaJ5PdHgPFXZ/x ujQyjckd/cqm0+jYRZgoPChS3mp6E+pT5dnYjx7HZQJ+H76NHmbv8COt8LLD8ST4LRp9 hN9g== X-Gm-Message-State: AOAM533HpnKuMXCuLLLZ50d9a1Am7pa0VZuJ6u/ht+RCI9jTp18cBI08 N1AzxEQqBFYFr0Ye4LbzeE7nIWrqtVs= X-Google-Smtp-Source: ABdhPJz9CssLA0dtkmTpwVg9FeTRVXq5KHXRQrXz9VhYw8/Vfjxws4OgQ9wvIfcyHL0Gne1egpI92w== X-Received: by 2002:a17:906:dc89:b0:6db:a789:7563 with SMTP id cs9-20020a170906dc8900b006dba7897563mr3749955ejc.471.1647351160015; Tue, 15 Mar 2022 06:32:40 -0700 (PDT) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id n4-20020a056402060400b00415a1f9a4dasm9540753edv.91.2022.03.15.06.32.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 06:32:39 -0700 (PDT) From: luca.boccassi@gmail.com To: Adham Masarwah Cc: Aman Singh , dpdk stable Subject: patch 'app/testpmd: fix show RSS RETA on Windows' has been queued to stable release 20.11.5 Date: Tue, 15 Mar 2022 13:32:28 +0000 Message-Id: <20220315133233.635559-5-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220315133233.635559-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-1-luca.boccassi@gmail.com> <20220315133233.635559-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/17/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/63f7788b203edea7dd970bcf2bb21f82267eb306 Thanks. Luca Boccassi --- >From 63f7788b203edea7dd970bcf2bb21f82267eb306 Mon Sep 17 00:00:00 2001 From: Adham Masarwah Date: Sun, 13 Mar 2022 14:57:02 +0200 Subject: [PATCH] app/testpmd: fix show RSS RETA on Windows [ upstream commit 5aae2723cddba81b179162b5e7e4f6bd429eaac5 ] Replaced using strtoul with strtoull when converting to 64-bit mask field. In Windows strtoul returns 32-bit values which cause an issue with show RSS RETA. Fixes: 66c594904ac ("ethdev: support multiple sizes of redirection table") Signed-off-by: Adham Masarwah Acked-by: Aman Singh --- app/test-pmd/cmdline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 9dfd0dcfab..1741d00ba8 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -3021,7 +3021,7 @@ showport_parse_reta_config(struct rte_eth_rss_reta_entry64 *conf, return -1; } for (i = 0; i < ret; i++) - conf[i].mask = (uint64_t)strtoul(str_fld[i], &end, 0); + conf[i].mask = (uint64_t)strtoull(str_fld[i], &end, 0); return 0; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-15 12:13:39.267218737 +0000 +++ 0005-app-testpmd-fix-show-RSS-RETA-on-Windows.patch 2022-03-15 12:13:39.072181080 +0000 @@ -1 +1 @@ -From 5aae2723cddba81b179162b5e7e4f6bd429eaac5 Mon Sep 17 00:00:00 2001 +From 63f7788b203edea7dd970bcf2bb21f82267eb306 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5aae2723cddba81b179162b5e7e4f6bd429eaac5 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 7ab0575e64..6ffea8e21a 100644 +index 9dfd0dcfab..1741d00ba8 100644 @@ -24 +25 @@ -@@ -3127,7 +3127,7 @@ showport_parse_reta_config(struct rte_eth_rss_reta_entry64 *conf, +@@ -3021,7 +3021,7 @@ showport_parse_reta_config(struct rte_eth_rss_reta_entry64 *conf,