From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C8F9A00BE for ; Tue, 15 Mar 2022 14:32:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 56C594014F; Tue, 15 Mar 2022 14:32:55 +0100 (CET) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by mails.dpdk.org (Postfix) with ESMTP id A068E410EF for ; Tue, 15 Mar 2022 14:32:53 +0100 (CET) Received: by mail-ej1-f47.google.com with SMTP id yy13so41384668ejb.2 for ; Tue, 15 Mar 2022 06:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=csi0/Tjm5hI131G0ST8++xawRC5RakO0FlUWjrSprp8=; b=JQRgyUkj+kp+JCNIyDedunJ6iOh1Zb6lW1tATg2OhIcHSmDv05FzMyeU3+g7JOqSfY m5GU6YK+arX3gTfbUmnC5fUF2Xw37SPLbe6x623tlUlTcm+KMhbGtsMY2Q+1RoupQAuv ew9sZDtXM0WkzcvrQKLhChv191wkD2Bj+ZeI9tOIfCFBPKdwNav4GCeGOneVCcGXe7Yd RDDTHp3OItRmjsF+KVrY/6e8zI84jQzGd1DeKIv6j4LpXB6lL6fUTqOShSweG1R5P7KA u3vQ65Umn924qddR7vStrEhrMkxjHcKXs8LmFWCOyPwFf8IGXpEizupzNsAPQWRxN3Kp elTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=csi0/Tjm5hI131G0ST8++xawRC5RakO0FlUWjrSprp8=; b=LNVLjGv+zWJJa3CFqYuDZXgaNNlXD/6X2Iifg0EF6KROGdTc6EMhDUaWu1Ij5DUMe7 3+Figx4nah7ENqFSspFIa9KLku65ddOcDRMBDWrhhvmcqytjUlK6/eEYjyZsW3QzBEfk pl392CdI7O5LWmAHMU/n0LfLpef1o4PX9RTygCPYbvvP5/L8b5UQ+7G1uZtm1p5F5Ixp kUWG2Thu8OnFPDarNoWAMA6fWH4wAHhYyhuk3eOP8t7Ooy5frJxKmYZ5nOp3s02xuz3G rvVAQad5kHswUQs/nMQC8o3mbRzR1DV3BaJiREQ9uMxufLvvMI8k2A4oGi1zKvdaN5iB YkHA== X-Gm-Message-State: AOAM530sY+Qf5DHP3aS/fBa8wrXWKkPVxRL7UtsBnbF3IEoTyzp1VCn8 ZBHeTWYAsMejn0XkVdmMlOzcAqjc81c= X-Google-Smtp-Source: ABdhPJw81hK4PciXMTrzgqLzHGzSJqS1XnuaCUq1NLzOq6QBnktMGLkluXIfGCHaHnUTUq8qBBerWA== X-Received: by 2002:a17:907:2dac:b0:6db:e1e8:c66f with SMTP id gt44-20020a1709072dac00b006dbe1e8c66fmr5671709ejc.382.1647351173346; Tue, 15 Mar 2022 06:32:53 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id n4-20020a056402060400b00415a1f9a4dasm9540995edv.91.2022.03.15.06.32.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 06:32:52 -0700 (PDT) From: luca.boccassi@gmail.com To: Bruce Richardson Cc: dpdk stable Subject: patch 'compressdev: fix missing space in log macro' has been queued to stable release 20.11.5 Date: Tue, 15 Mar 2022 13:32:31 +0000 Message-Id: <20220315133233.635559-8-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220315133233.635559-1-luca.boccassi@gmail.com> References: <20220218123931.1749595-1-luca.boccassi@gmail.com> <20220315133233.635559-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/17/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/b16e4220e96caef4843c1006fc1e9bc25fbc794a Thanks. Luca Boccassi --- >From b16e4220e96caef4843c1006fc1e9bc25fbc794a Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 11 Mar 2022 20:05:21 +0000 Subject: [PATCH] compressdev: fix missing space in log macro [ upstream commit dfb90fbe6b2b11ecf3535286c8d418ba8cc5485c ] Building with clang on FreeBSD with chkincs enabled, we get the following error about a missing space: lib/compressdev/rte_compressdev_internal.h:25:58: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal] rte_log(RTE_LOG_ ## level, compressdev_logtype, "%s(): "fmt "\n", \ Adding in a space between the '"' and 'fmt' removes the error. Fixes: ed7dd94f7f66 ("compressdev: add basic device management") Signed-off-by: Bruce Richardson --- lib/librte_compressdev/rte_compressdev_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_compressdev/rte_compressdev_internal.h b/lib/librte_compressdev/rte_compressdev_internal.h index 25d8afbfb9..b3b193e3ee 100644 --- a/lib/librte_compressdev/rte_compressdev_internal.h +++ b/lib/librte_compressdev/rte_compressdev_internal.h @@ -22,7 +22,7 @@ extern "C" { /* Logging Macros */ extern int compressdev_logtype; #define COMPRESSDEV_LOG(level, fmt, args...) \ - rte_log(RTE_LOG_ ## level, compressdev_logtype, "%s(): "fmt "\n", \ + rte_log(RTE_LOG_ ## level, compressdev_logtype, "%s(): " fmt "\n", \ __func__, ##args) /** -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-15 12:13:39.385931703 +0000 +++ 0008-compressdev-fix-missing-space-in-log-macro.patch 2022-03-15 12:13:39.072181080 +0000 @@ -1 +1 @@ -From dfb90fbe6b2b11ecf3535286c8d418ba8cc5485c Mon Sep 17 00:00:00 2001 +From b16e4220e96caef4843c1006fc1e9bc25fbc794a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit dfb90fbe6b2b11ecf3535286c8d418ba8cc5485c ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ - lib/compressdev/rte_compressdev_internal.h | 2 +- + lib/librte_compressdev/rte_compressdev_internal.h | 2 +- @@ -24 +25 @@ -diff --git a/lib/compressdev/rte_compressdev_internal.h b/lib/compressdev/rte_compressdev_internal.h +diff --git a/lib/librte_compressdev/rte_compressdev_internal.h b/lib/librte_compressdev/rte_compressdev_internal.h @@ -26,2 +27,2 @@ ---- a/lib/compressdev/rte_compressdev_internal.h -+++ b/lib/compressdev/rte_compressdev_internal.h +--- a/lib/librte_compressdev/rte_compressdev_internal.h ++++ b/lib/librte_compressdev/rte_compressdev_internal.h