From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 110A1A0032 for ; Wed, 16 Mar 2022 16:15:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C22A41158; Wed, 16 Mar 2022 16:15:59 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6E38F40395 for ; Wed, 16 Mar 2022 16:15:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647443757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eZUBdqbO57EfozIzwiXVYvVGiQL8Z1W48dPYQt1Z4O0=; b=MZiJrVQitFXq1KVwnSktMxcwtbchMikUdOQDgnCmEMp9JMKLg2TCyGah6+EtDReMb6c6wN 2Qw4gmr8j4UmiRjCCpJPmFHn5VNAfX7xF9r+pVGAsfeL5s0cs5XnkTNszGY3tXPgiFKGek E7QWjtnxy1QSjXGSTJkdnjtAM1tm9H8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-513-Szz-dwsmNlevDwSsHfaHkw-1; Wed, 16 Mar 2022 11:15:53 -0400 X-MC-Unique: Szz-dwsmNlevDwSsHfaHkw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 60F533800E8F; Wed, 16 Mar 2022 15:15:53 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.195.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id 60CF0401053; Wed, 16 Mar 2022 15:15:52 +0000 (UTC) From: Kevin Traynor To: Adham Masarwah Cc: Aman Singh , dpdk stable Subject: patch 'app/testpmd: fix show RSS RETA on Windows' has been queued to stable release 21.11.1 Date: Wed, 16 Mar 2022 15:15:14 +0000 Message-Id: <20220316151524.1242199-13-ktraynor@redhat.com> In-Reply-To: <20220316151524.1242199-1-ktraynor@redhat.com> References: <20220316151524.1242199-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/21/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/73fd3c8736bb9f9b98e4ea6afb4754256e8ce218 Thanks. Kevin --- >From 73fd3c8736bb9f9b98e4ea6afb4754256e8ce218 Mon Sep 17 00:00:00 2001 From: Adham Masarwah Date: Sun, 13 Mar 2022 14:57:02 +0200 Subject: [PATCH] app/testpmd: fix show RSS RETA on Windows [ upstream commit 5aae2723cddba81b179162b5e7e4f6bd429eaac5 ] Replaced using strtoul with strtoull when converting to 64-bit mask field. In Windows strtoul returns 32-bit values which cause an issue with show RSS RETA. Fixes: 66c594904ac ("ethdev: support multiple sizes of redirection table") Signed-off-by: Adham Masarwah Acked-by: Aman Singh --- app/test-pmd/cmdline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 69501d0deb..6f995905f6 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -3121,5 +3121,5 @@ showport_parse_reta_config(struct rte_eth_rss_reta_entry64 *conf, } for (i = 0; i < ret; i++) - conf[i].mask = (uint64_t)strtoul(str_fld[i], &end, 0); + conf[i].mask = (uint64_t)strtoull(str_fld[i], &end, 0); return 0; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-16 15:14:12.449868564 +0000 +++ 0013-app-testpmd-fix-show-RSS-RETA-on-Windows.patch 2022-03-16 15:14:12.122847649 +0000 @@ -1 +1 @@ -From 5aae2723cddba81b179162b5e7e4f6bd429eaac5 Mon Sep 17 00:00:00 2001 +From 73fd3c8736bb9f9b98e4ea6afb4754256e8ce218 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5aae2723cddba81b179162b5e7e4f6bd429eaac5 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 7ab0575e64..6ffea8e21a 100644 +index 69501d0deb..6f995905f6 100644 @@ -24 +25 @@ -@@ -3128,5 +3128,5 @@ showport_parse_reta_config(struct rte_eth_rss_reta_entry64 *conf, +@@ -3121,5 +3121,5 @@ showport_parse_reta_config(struct rte_eth_rss_reta_entry64 *conf,