From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2980EA0032 for ; Wed, 16 Mar 2022 16:16:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 247CA40395; Wed, 16 Mar 2022 16:16:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 12ABC4115B for ; Wed, 16 Mar 2022 16:15:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647443758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dJJucBxuFP0LGnKjM7GkEZ2FcNmKm2COwHl71ZLak8g=; b=R/5sM8aHG8K1Bz0QDk3xvvSOnNj6kGawt+8FE1p8c0T4iThyN7wL9ZCMM4aWAvardpI4N/ LzyVJjVYWkiGG//x6oAYAJE+vjy3uC/75o7w3TRkxBOjTu99WiSSG8pUfm3ReI26OJ63Fu iATGycHnd7gB3qgtYRvAW0J9qXxQGP8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-60-577r6POkMV63wZfrjqu65Q-1; Wed, 16 Mar 2022 11:15:55 -0400 X-MC-Unique: 577r6POkMV63wZfrjqu65Q-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EA55B802A5E; Wed, 16 Mar 2022 15:15:54 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.195.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id C81B24B8D43; Wed, 16 Mar 2022 15:15:53 +0000 (UTC) From: Kevin Traynor To: Gregory Etelson Cc: Aman Singh , dpdk stable Subject: patch 'app/testpmd: fix GTP header parsing in checksum engine' has been queued to stable release 21.11.1 Date: Wed, 16 Mar 2022 15:15:15 +0000 Message-Id: <20220316151524.1242199-14-ktraynor@redhat.com> In-Reply-To: <20220316151524.1242199-1-ktraynor@redhat.com> References: <20220316151524.1242199-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/21/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/7affb1a4a417f2b3a0aeba0991f72e063092f905 Thanks. Kevin --- >From 7affb1a4a417f2b3a0aeba0991f72e063092f905 Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Sun, 13 Mar 2022 11:01:23 +0200 Subject: [PATCH] app/testpmd: fix GTP header parsing in checksum engine [ upstream commit a058de216ceb6581dac213d7a37d9fb9fad05a9b ] GTP header can be followed by an optional 32 bits extension. GTP notifies about the extension presence through the E, S or PN header bits. Csum GTP header parser did not check the extension bits value. The patch updates GTP header length if at-least one of the extension bits is set. Fixes: d8e5e69f3a9b ("app/testpmd: add GTP parsing and Tx checksum offload") Signed-off-by: Gregory Etelson Acked-by: Aman Singh --- app/test-pmd/csumonly.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index fb559e4ac2..f0c69c5d16 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -223,5 +223,6 @@ parse_gtp(struct rte_udp_hdr *udp_hdr, gtp_hdr = (struct rte_gtp_hdr *)((char *)udp_hdr + sizeof(struct rte_udp_hdr)); - + if (gtp_hdr->e || gtp_hdr->s || gtp_hdr->pn) + gtp_len += sizeof(struct rte_gtp_hdr_ext_word); /* * Check message type. If message type is 0xff, it is @@ -229,7 +230,5 @@ parse_gtp(struct rte_udp_hdr *udp_hdr, */ if (gtp_hdr->msg_type == 0xff) { - ip_ver = *(uint8_t *)((char *)udp_hdr + - sizeof(struct rte_udp_hdr) + - sizeof(struct rte_gtp_hdr)); + ip_ver = *(uint8_t *)((char *)gtp_hdr + gtp_len); ip_ver = (ip_ver) & 0xf0; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-16 15:14:12.481661559 +0000 +++ 0014-app-testpmd-fix-GTP-header-parsing-in-checksum-engin.patch 2022-03-16 15:14:12.123847653 +0000 @@ -1 +1 @@ -From a058de216ceb6581dac213d7a37d9fb9fad05a9b Mon Sep 17 00:00:00 2001 +From 7affb1a4a417f2b3a0aeba0991f72e063092f905 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a058de216ceb6581dac213d7a37d9fb9fad05a9b ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index dbddd20a07..cdb1920763 100644 +index fb559e4ac2..f0c69c5d16 100644 @@ -28 +29 @@ -@@ -224,5 +224,6 @@ parse_gtp(struct rte_udp_hdr *udp_hdr, +@@ -223,5 +223,6 @@ parse_gtp(struct rte_udp_hdr *udp_hdr, @@ -36 +37 @@ -@@ -230,7 +231,5 @@ parse_gtp(struct rte_udp_hdr *udp_hdr, +@@ -229,7 +230,5 @@ parse_gtp(struct rte_udp_hdr *udp_hdr,