From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D9FAA0093 for ; Thu, 17 Mar 2022 15:18:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 889924067B; Thu, 17 Mar 2022 15:18:08 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 24CFA4067B for ; Thu, 17 Mar 2022 15:18:07 +0100 (CET) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 016923F1B7 for ; Thu, 17 Mar 2022 14:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647526687; bh=EZmhu9AqcHoq6uw93xaBwsANvBNxoinVsUhRYfsaG8g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YsAUeYHiny/KxUO4zXnyfUuKPsrUCU2uhUCs/3m7NmCH0HvM69gJBHsaY6yckTM1E 20dUhJJ3aKYWsnafG1PD8o4xNoUgHd9XOlGeMUvIKwupCOgXrphEls21WUgv26QBnB NnWuRygJozHunftu7b5bswJae9+WPxh8zPhPiDqFoNdoig9N+0lF2zK6Ha3EEfLpOc 1PT+trAWZEiiEOaHea0VgsaqXe/TEVBFXslGW6wjA4u0Qorob+x9o5qZpuwYMdEVR8 +uFb7UyM8xdovaAAGH+qrh9YTls0Rw5AFe6UjowYtdPOjwflJ1/1cu55PDzhHlJLA9 IvTLoYM1Lbrcw== Received: by mail-ed1-f72.google.com with SMTP id x1-20020a50f181000000b00418f6d4bccbso1487743edl.12 for ; Thu, 17 Mar 2022 07:18:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EZmhu9AqcHoq6uw93xaBwsANvBNxoinVsUhRYfsaG8g=; b=pYIFCJ9J2j5zWP8ySpgOa8BK7GrPaIV7vbwJCXBJ5cunngOOZipGxQtgXeL4Km3c6C 4WP/1q3ux8465FnvUkz0sSDaLmj+Gj0Qlq3VHbRZs2MiBrChIVS9JwIvtu8JcNssozNe 4HTqnqWAayIXsbx5OrXclYr+ZckckbjqQMbBVqnPlKLf/cu5Tgjc1n5spN3ZBIFwlNAL xzD2/K2WQ6tb8vvtL4ePfoFr3NZh74mzoUKSxvgH5D9H67yBUba2KEZVp2th//dIV6/B /uv1TAyMvMO6GLTE25Pjdz9u6MhmzAz61O9+yLJlB3zSEcSZI4JrdAL+wpGHglzX+DWq Mc8Q== X-Gm-Message-State: AOAM532iX4JBm2zqURQHnK8bZ4j7R/EzZHKyxWpEFSZV5KfaOv3bZpLt MVWMeTqevePfIOWl5d9CNQ9ORpK7cxePuNEznuwOn2BzhlLJ2r+8gUOW6sGSxxLPICOzX+cmtW8 NuQjSk7/K+VNaqOge9h3s9jBP X-Received: by 2002:aa7:c55a:0:b0:418:681a:d65c with SMTP id s26-20020aa7c55a000000b00418681ad65cmr4730815edr.145.1647526686660; Thu, 17 Mar 2022 07:18:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz89k2SCKP+CuwTprt+CQI+WtGsQcS/s5873BmTk9z8OJM/mMJCOzGjHFlfYKK/Io7yaMbj8A== X-Received: by 2002:aa7:c55a:0:b0:418:681a:d65c with SMTP id s26-20020aa7c55a000000b00418681ad65cmr4730784edr.145.1647526686388; Thu, 17 Mar 2022 07:18:06 -0700 (PDT) Received: from localhost.localdomain (068-133-067-156.ip-addr.inexio.net. [156.67.133.68]) by smtp.gmail.com with ESMTPSA id p22-20020a17090664d600b006df6790a519sm2525197ejn.116.2022.03.17.07.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 07:18:06 -0700 (PDT) From: christian.ehrhardt@canonical.com To: Bruce Richardson Cc: dpdk stable Subject: patch 'compressdev: fix missing space in log macro' has been queued to stable release 19.11.12 Date: Thu, 17 Mar 2022 15:17:44 +0100 Message-Id: <20220317141747.1955930-6-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220317141747.1955930-1-christian.ehrhardt@canonical.com> References: <20220317141747.1955930-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.12 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/19/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/8174ed2b2f88d9a7c2966d26426fb423cd37c902 Thanks. Christian Ehrhardt --- >From 8174ed2b2f88d9a7c2966d26426fb423cd37c902 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 11 Mar 2022 20:05:21 +0000 Subject: [PATCH] compressdev: fix missing space in log macro [ upstream commit dfb90fbe6b2b11ecf3535286c8d418ba8cc5485c ] Building with clang on FreeBSD with chkincs enabled, we get the following error about a missing space: lib/compressdev/rte_compressdev_internal.h:25:58: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal] rte_log(RTE_LOG_ ## level, compressdev_logtype, "%s(): "fmt "\n", \ Adding in a space between the '"' and 'fmt' removes the error. Fixes: ed7dd94f7f66 ("compressdev: add basic device management") Signed-off-by: Bruce Richardson --- lib/librte_compressdev/rte_compressdev_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_compressdev/rte_compressdev_internal.h b/lib/librte_compressdev/rte_compressdev_internal.h index 25d8afbfb9..b3b193e3ee 100644 --- a/lib/librte_compressdev/rte_compressdev_internal.h +++ b/lib/librte_compressdev/rte_compressdev_internal.h @@ -22,7 +22,7 @@ extern "C" { /* Logging Macros */ extern int compressdev_logtype; #define COMPRESSDEV_LOG(level, fmt, args...) \ - rte_log(RTE_LOG_ ## level, compressdev_logtype, "%s(): "fmt "\n", \ + rte_log(RTE_LOG_ ## level, compressdev_logtype, "%s(): " fmt "\n", \ __func__, ##args) /** -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-03-17 14:33:42.273314367 +0100 +++ 0006-compressdev-fix-missing-space-in-log-macro.patch 2022-03-17 14:33:41.872623036 +0100 @@ -1 +1 @@ -From dfb90fbe6b2b11ecf3535286c8d418ba8cc5485c Mon Sep 17 00:00:00 2001 +From 8174ed2b2f88d9a7c2966d26426fb423cd37c902 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit dfb90fbe6b2b11ecf3535286c8d418ba8cc5485c ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ - lib/compressdev/rte_compressdev_internal.h | 2 +- + lib/librte_compressdev/rte_compressdev_internal.h | 2 +- @@ -24 +25 @@ -diff --git a/lib/compressdev/rte_compressdev_internal.h b/lib/compressdev/rte_compressdev_internal.h +diff --git a/lib/librte_compressdev/rte_compressdev_internal.h b/lib/librte_compressdev/rte_compressdev_internal.h @@ -26,2 +27,2 @@ ---- a/lib/compressdev/rte_compressdev_internal.h -+++ b/lib/compressdev/rte_compressdev_internal.h +--- a/lib/librte_compressdev/rte_compressdev_internal.h ++++ b/lib/librte_compressdev/rte_compressdev_internal.h