From: Stephen Hemminger <stephen@networkplumber.org>
To: Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com>
Cc: david.hunt@intel.com, dev@dpdk.org, alan.carew@intel.com,
stable@dpdk.org
Subject: Re: [PATCH v2] examples/vm_power: add support for list_foreach_safe
Date: Mon, 21 Mar 2022 09:16:59 -0700 [thread overview]
Message-ID: <20220321091659.43e6eb99@hermes.local> (raw)
In-Reply-To: <20220321093342.1223208-1-shibin.koikkara.reeny@intel.com>
On Mon, 21 Mar 2022 09:33:42 +0000
Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com> wrote:
> diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c
> index 838465ab4b..d297b28114 100644
> --- a/examples/vm_power_manager/channel_manager.c
> +++ b/examples/vm_power_manager/channel_manager.c
> @@ -66,8 +66,8 @@ LIST_HEAD(, virtual_machine_info) vm_list_head;
> static struct virtual_machine_info *
> find_domain_by_name(const char *name)
> {
> - struct virtual_machine_info *info;
> - LIST_FOREACH(info, &vm_list_head, vms_info) {
> + struct virtual_machine_info *info, *t_info;
> + RTE_LIST_FOREACH_SAFE(info, &vm_list_head, vms_info, t_info) {
> if (!strncmp(info->name, name, CHANNEL_MGR_MAX_NAME_LEN-1))
Please add blank line after declarations. It didn't have it before but
is better style.
next prev parent reply other threads:[~2022-03-21 16:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 14:53 [PATCH] examples/vm_power: replace list foreach with while loop Shibin Koikkara Reeny
2022-03-08 13:26 ` Thomas Monjalon
2022-03-10 9:32 ` Koikkara Reeny, Shibin
2022-03-10 9:39 ` Thomas Monjalon
2022-03-10 17:21 ` Stephen Hemminger
2022-03-21 9:33 ` [PATCH v2] examples/vm_power: add support for list_foreach_safe Shibin Koikkara Reeny
2022-03-21 16:16 ` Stephen Hemminger [this message]
2022-03-22 14:43 ` [PATCH v3] " Shibin Koikkara Reeny
2022-03-25 14:02 ` David Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220321091659.43e6eb99@hermes.local \
--to=stephen@networkplumber.org \
--cc=alan.carew@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=shibin.koikkara.reeny@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).