Re: [PATCH] test/bpf: skip test if libpcap is unavailable

[Tyler Retzlaff <roretzla@linux.microsoft.com>]

On Mon, Mar 21, 2022 at 02:42:39PM +0000, Ananyev, Konstantin wrote:
> 
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
> >  app/test/test_bpf.c | 14 ++++++++++++--
> >  1 file changed, 12 insertions(+), 2 deletions(-)
> > 
> > diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c
> > index 805cce6..de1fa87 100644
> > --- a/app/test/test_bpf.c
> > +++ b/app/test/test_bpf.c
> > @@ -3264,7 +3264,16 @@ struct bpf_test {
> > 
> >  REGISTER_TEST_COMMAND(bpf_autotest, test_bpf);
> > 
> > -#ifdef RTE_HAS_LIBPCAP
> > +#ifndef RTE_HAS_LIBPCAP
> > +
> > +static int
> > +test_bpf_convert(void)
> > +{
> > +	printf("BPF not supported, skipping test\n");
> 
> One nit: the message above seems a bit misleading...
> Probably "LIBPCAP is not supported" or so?
> With that fixed:
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

yeah, i cut and paste the other skip function. i agree i'll tweak the
message to talk about libpcap.

> 
> 
> > +	return TEST_SKIPPED;
> > +}
> > +
> > +#else
> >  #include <pcap/pcap.h>
> > 
> >  static void
> > @@ -3462,5 +3471,6 @@ struct bpf_test {
> >  	return rc;
> >  }
> > 
> > -REGISTER_TEST_COMMAND(bpf_convert_autotest, test_bpf_convert);
> >  #endif /* RTE_HAS_LIBPCAP */
> > +
> > +REGISTER_TEST_COMMAND(bpf_convert_autotest, test_bpf_convert);
> > --
> > 1.8.3.1