[PATCH 19.11] net/mlx5: fix netlink header path

[PATCH 19.11] net/mlx5: fix netlink header path

[Ali Alnubani]

Use netlink.h provided by the kernel headers instead
of adding a dependency on the headers provided by the libnl package,
which weren't being found in some cases, even with libnl-3 and
libnl-route-3 libs installed via the package manager.
Also see usage in netlink(3).

Resolves the build error:
  drivers/net/mlx5/mlx5.h:15:10:
    fatal error: netlink/netlink.h: No such file or directory
The error reproduces on Ubuntu 16.04/18.04/20.04, openSUSE Leap 15.3,
and CentOS 7/8. It reproduces with Make and Meson.

Fixes: 7bd18f45ed47 ("common/mlx5: add Netlink event helpers")
Cc: dkozlyuk@nvidia.com

Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
---
 drivers/net/mlx5/mlx5.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index 1cf5f41689..9f6b355182 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -12,7 +12,7 @@
 #include <limits.h>
 #include <net/if.h>
 #include <netinet/in.h>
-#include <netlink/netlink.h>
+#include <linux/netlink.h>
 #include <sys/queue.h>
 
 /* Verbs header. */
-- 
2.25.1

Re: [PATCH 19.11] net/mlx5: fix netlink header path

[Christian Ehrhardt]

[-- Attachment #1: Type: text/plain, Size: 1675 bytes --]

On Tue, Mar 29, 2022 at 3:01 PM Ali Alnubani <alialnu@nvidia.com> wrote:

> Use netlink.h provided by the kernel headers instead
> of adding a dependency on the headers provided by the libnl package,
> which weren't being found in some cases, even with libnl-3 and
> libnl-route-3 libs installed via the package manager.
> Also see usage in netlink(3).
>

Thank you, indeed various other includers of netlink.h already use the
kernel headers and this makes this consistent.
Applied to the WIP 19.11.12

Since it is only a build fix - unless someone is totally blocked on
verifying 19.11.12 - this isn't forcing a new round with an -rc2.

I'll do a cross arch/distro rebuild test to be sure it has no unexpected
side effects ...

Resolves the build error:
>   drivers/net/mlx5/mlx5.h:15:10:
>     fatal error: netlink/netlink.h: No such file or directory
> The error reproduces on Ubuntu 16.04/18.04/20.04, openSUSE Leap 15.3,
> and CentOS 7/8. It reproduces with Make and Meson.
>
> Fixes: 7bd18f45ed47 ("common/mlx5: add Netlink event helpers")
> Cc: dkozlyuk@nvidia.com
>
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> ---
>  drivers/net/mlx5/mlx5.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
> index 1cf5f41689..9f6b355182 100644
> --- a/drivers/net/mlx5/mlx5.h
> +++ b/drivers/net/mlx5/mlx5.h
> @@ -12,7 +12,7 @@
>  #include <limits.h>
>  #include <net/if.h>
>  #include <netinet/in.h>
> -#include <netlink/netlink.h>
> +#include <linux/netlink.h>
>  #include <sys/queue.h>
>
>  /* Verbs header. */
> --
> 2.25.1
>
>

-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

[-- Attachment #2: Type: text/html, Size: 2591 bytes --]