* [PATCH] eal/windows: add missing C++ include guards
@ 2022-04-05 13:48 David Marchand
2022-04-07 11:20 ` Tyler Retzlaff
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2022-04-05 13:48 UTC (permalink / raw)
To: dev; +Cc: stable
Add missing 'extern "C"' to file.
Fixes: 1db72630da0c ("eal/windows: do not expose private facilities")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
Caught by cross compiling with mingw + enabling the headers check.
---
lib/eal/windows/include/rte_windows.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/lib/eal/windows/include/rte_windows.h b/lib/eal/windows/include/rte_windows.h
index 0063b5d78c..83730c3d2e 100644
--- a/lib/eal/windows/include/rte_windows.h
+++ b/lib/eal/windows/include/rte_windows.h
@@ -5,6 +5,10 @@
#ifndef _RTE_WINDOWS_H_
#define _RTE_WINDOWS_H_
+#ifdef __cplusplus
+extern "C" {
+#endif
+
/**
* @file Windows-specific facilities
*
@@ -48,4 +52,8 @@
RTE_FMT_HEAD(__VA_ARGS__,) "\n", GetLastError(), \
RTE_FMT_TAIL(__VA_ARGS__,)))
+#ifdef __cplusplus
+}
+#endif
+
#endif /* _RTE_WINDOWS_H_ */
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] eal/windows: add missing C++ include guards
2022-04-05 13:48 [PATCH] eal/windows: add missing C++ include guards David Marchand
@ 2022-04-07 11:20 ` Tyler Retzlaff
2022-04-08 9:18 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Tyler Retzlaff @ 2022-04-07 11:20 UTC (permalink / raw)
To: David Marchand; +Cc: dev, stable
On Tue, Apr 05, 2022 at 03:48:58PM +0200, David Marchand wrote:
> Add missing 'extern "C"' to file.
>
> Fixes: 1db72630da0c ("eal/windows: do not expose private facilities")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] eal/windows: add missing C++ include guards
2022-04-07 11:20 ` Tyler Retzlaff
@ 2022-04-08 9:18 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2022-04-08 9:18 UTC (permalink / raw)
To: David Marchand; +Cc: dev, dpdk stable, Tyler Retzlaff
On Thu, Apr 7, 2022 at 1:20 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
> On Tue, Apr 05, 2022 at 03:48:58PM +0200, David Marchand wrote:
> > Add missing 'extern "C"' to file.
> >
> > Fixes: 1db72630da0c ("eal/windows: do not expose private facilities")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-08 9:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-05 13:48 [PATCH] eal/windows: add missing C++ include guards David Marchand
2022-04-07 11:20 ` Tyler Retzlaff
2022-04-08 9:18 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).