* [PATCH] net/vhost: fix TSO feature default disablement
@ 2022-04-22 9:35 Maxime Coquelin
2022-05-02 11:28 ` David Marchand
2022-05-05 19:56 ` Maxime Coquelin
0 siblings, 2 replies; 3+ messages in thread
From: Maxime Coquelin @ 2022-04-22 9:35 UTC (permalink / raw)
To: dev, chenbo.xia, david.marchand; +Cc: Maxime Coquelin, stable
By default, TSO feature should be disabled because it requires
application's support to be functionnal as mentionned in the
documentation.
However, if "tso" devarg was not specified, the feature did
not get disabled.
This patch fixes this issue, so that TSO is disabled, even if
"tso=0" is not passed as devarg.
Fixes: e289400669d5 ("net/vhost: support TSO disabling")
Cc: stable@dpdk.org
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
drivers/net/vhost/rte_eth_vhost.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index 070f0e6dfd..19c80044c8 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -1643,11 +1643,11 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)
&open_int, &tso);
if (ret < 0)
goto out_free;
+ }
- if (tso == 0) {
- disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO4);
- disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO6);
- }
+ if (tso == 0) {
+ disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO4);
+ disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO6);
}
if (rte_kvargs_count(kvlist, ETH_VHOST_LINEAR_BUF) == 1) {
--
2.35.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net/vhost: fix TSO feature default disablement
2022-04-22 9:35 [PATCH] net/vhost: fix TSO feature default disablement Maxime Coquelin
@ 2022-05-02 11:28 ` David Marchand
2022-05-05 19:56 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: David Marchand @ 2022-05-02 11:28 UTC (permalink / raw)
To: Maxime Coquelin; +Cc: dev, Xia, Chenbo, dpdk stable
On Fri, Apr 22, 2022 at 11:35 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> By default, TSO feature should be disabled because it requires
> application's support to be functionnal as mentionned in the
> documentation.
>
> However, if "tso" devarg was not specified, the feature did
> not get disabled.
>
> This patch fixes this issue, so that TSO is disabled, even if
> "tso=0" is not passed as devarg.
>
> Fixes: e289400669d5 ("net/vhost: support TSO disabling")
> Cc: stable@dpdk.org
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
LGTM.
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net/vhost: fix TSO feature default disablement
2022-04-22 9:35 [PATCH] net/vhost: fix TSO feature default disablement Maxime Coquelin
2022-05-02 11:28 ` David Marchand
@ 2022-05-05 19:56 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2022-05-05 19:56 UTC (permalink / raw)
To: dev, chenbo.xia, david.marchand; +Cc: stable
On 4/22/22 11:35, Maxime Coquelin wrote:
> By default, TSO feature should be disabled because it requires
> application's support to be functionnal as mentionned in the
> documentation.
>
> However, if "tso" devarg was not specified, the feature did
> not get disabled.
>
> This patch fixes this issue, so that TSO is disabled, even if
> "tso=0" is not passed as devarg.
>
> Fixes: e289400669d5 ("net/vhost: support TSO disabling")
> Cc: stable@dpdk.org
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> drivers/net/vhost/rte_eth_vhost.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Applied to dpdk-next-virtio/main.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-05 19:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-22 9:35 [PATCH] net/vhost: fix TSO feature default disablement Maxime Coquelin
2022-05-02 11:28 ` David Marchand
2022-05-05 19:56 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).