From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DCABDA034C
	for <public@inbox.dpdk.org>; Tue, 26 Apr 2022 09:47:22 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D497E4113F;
	Tue, 26 Apr 2022 09:47:22 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id C09A640691;
 Tue, 26 Apr 2022 09:47:20 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 1E78120E8FB5; Tue, 26 Apr 2022 00:47:20 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1E78120E8FB5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1650959240;
 bh=fcPqrtNU9pjOUfhsBea/ARLkinqgMg2T+mk5E6KycKU=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=ERsq6l8GB43NYMrWWmRO/jXh8xQaWLrNBsnMnGFV/yB3vcNZt79GHpk32xBSn2ZRU
 OtINZjCyiM0MZ56YkBhSQHqAtzaAZLOMtdr8wXKgKuT6ieqL6KllhClowrcjMYWDIH
 8biWkJA/gpXbLstFkArG9w2fZK7xD6XhTlLGId2Q=
Date: Tue, 26 Apr 2022 00:47:20 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Stephen Hemminger <stephen@networkplumber.org>,
 "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 dpdk stable <stable@dpdk.org>
Subject: Re: [PATCH v2] test/bpf: skip test if libpcap is unavailable
Message-ID: <20220426074720.GA28735@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1647868407-4467-1-git-send-email-roretzla@linux.microsoft.com>
 <1647933155-30745-1-git-send-email-roretzla@linux.microsoft.com>
 <CAJFAV8wZ9EHfXbikJESOY1BJBm+VCErL=fVWxkLb3gbD1i3WvA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8wZ9EHfXbikJESOY1BJBm+VCErL=fVWxkLb3gbD1i3WvA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org

On Tue, Apr 26, 2022 at 09:41:08AM +0200, David Marchand wrote:
> On Tue, Mar 22, 2022 at 8:12 AM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > test_bpf_convert is being conditionally registered depending on the
> > presence of RTE_HAS_LIBPCAP except the UT unconditionally lists it as a
> > test to run.
> >
> > when the UT runs test_bpf_convert test-dpdk can't find the registration
> > and assumes the DPDK_TEST environment variable hasn't been defined
> > resulting in test-dpdk dropping to interactive mode and subsequently
> > waiting for the remainder of the UT fast-test timeout period before
> > reporting the test as having timed out.
> >
> > * unconditionally register test_bpf_convert
> > * if ! RTE_HAS_LIBPCAP provide a stub test_bpf_convert that reports the
> >   test is skipped similar to that done with the test_bpf test.
> >
> > Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BPF")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 
> Applied, thanks.

thanks mate!

> 
> 
> -- 
> David Marchand