From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@xilinx.com>
Cc: <longli@linuxonhyperv.com>, <dev@dpdk.org>,
Stephen Hemminger <sthemmin@microsoft.com>,
Long Li <longli@microsoft.com>, <stable@dpdk.org>
Subject: Re: [Patch v2] net/netvsc: report correct stats values
Date: Tue, 26 Apr 2022 15:45:24 -0700 [thread overview]
Message-ID: <20220426154524.49502217@hermes.local> (raw)
In-Reply-To: <7f51e773-6ded-b736-fb02-5e3b391353b9@xilinx.com>
On Tue, 26 Apr 2022 22:56:14 +0100
Ferruh Yigit <ferruh.yigit@xilinx.com> wrote:
> > if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
> > - stats->q_opackets[i] = txq->stats.packets;
> > - stats->q_obytes[i] = txq->stats.bytes;
> > + stats->q_opackets[i] += txq->stats.packets;
> > + stats->q_obytes[i] += txq->stats.bytes;
>
> This is per queue stats, 'stats->q_opackets[i]', in next iteration of
> the loop, 'i' will be increased and 'txq' will be updated, so as far as
> I can see the above change has no affect.
Agree, that is why it was just assignment originally.
next prev parent reply other threads:[~2022-04-26 22:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 17:45 longli
2022-04-26 21:56 ` Ferruh Yigit
2022-04-26 22:45 ` Stephen Hemminger [this message]
2022-05-03 18:18 ` Long Li
2022-05-03 19:03 ` Ferruh Yigit
2022-05-03 19:14 ` Long Li
2022-05-03 19:55 ` Ferruh Yigit
2022-05-03 20:48 ` Long Li
2022-05-04 12:33 ` Ferruh Yigit
2022-05-04 18:38 ` Long Li
2022-05-05 16:28 ` Ferruh Yigit
2022-05-05 16:40 ` Stephen Hemminger
2022-05-05 16:57 ` Ferruh Yigit
2022-05-10 5:33 ` Long Li
2022-05-10 11:29 ` Ferruh Yigit
2022-05-10 18:03 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220426154524.49502217@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=stable@dpdk.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).