From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 198FCA0093 for ; Tue, 10 May 2022 14:30:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14DA042831; Tue, 10 May 2022 14:30:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6372942831 for ; Tue, 10 May 2022 14:30:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652185855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+gCyjYDcmjVW2Zx8mf71o/3sMeyidod2UcGJei0MnZg=; b=EfJouKfJt5nbZTNkUaJl5SfstfMjffUCINaGZIvu/DQ8ApCgFHA7QYZPWVByRc2XI5+uHK Nyuy12Vkutc19p6bQz4/dCtRATvL9rqDX4vcMFA6a1bpDdXXk20rklB03p0w0Tqrv9vONz HkZF+1tH8QcMPvtbdTMUoFVhWZa6Cv4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-390-yHlGWmf9OJGuHTE9hOn-lw-1; Tue, 10 May 2022 08:30:52 -0400 X-MC-Unique: yHlGWmf9OJGuHTE9hOn-lw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8855C100BAA8; Tue, 10 May 2022 12:30:52 +0000 (UTC) Received: from rh.Home (unknown [10.39.195.199]) by smtp.corp.redhat.com (Postfix) with ESMTP id 97B7540CFD06; Tue, 10 May 2022 12:30:51 +0000 (UTC) From: Kevin Traynor To: Raja Zidane Cc: Matan Azrad , dpdk stable Subject: patch 'crypto/mlx5: fix login cleanup' has been queued to stable release 21.11.2 Date: Tue, 10 May 2022 13:30:01 +0100 Message-Id: <20220510123010.159523-24-ktraynor@redhat.com> In-Reply-To: <20220510123010.159523-1-ktraynor@redhat.com> References: <20220510123010.159523-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/15/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/8bad3a05f1b36f84717072dcf483fe11b705ac7d Thanks. Kevin --- >From 8bad3a05f1b36f84717072dcf483fe11b705ac7d Mon Sep 17 00:00:00 2001 From: Raja Zidane Date: Mon, 18 Apr 2022 14:05:16 +0300 Subject: [PATCH] crypto/mlx5: fix login cleanup [ upstream commit 146fe289de25cc3553894ed451066da6bc8b2789 ] In case of a probing failure caused by wrong devarg provided, login isn't destroyed when exiting. Destroy login on failure. Fixes: ba707cdb6da2 ("crypto/mlx5: fix queue size configuration") Signed-off-by: Raja Zidane Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c index 421c23748a..36db31aae5 100644 --- a/drivers/crypto/mlx5/mlx5_crypto.c +++ b/drivers/crypto/mlx5/mlx5_crypto.c @@ -953,4 +953,5 @@ mlx5_crypto_dev_probe(struct mlx5_common_device *cdev) cdev->config.hca_attr.max_wqe_sz_sq, devarg_prms.max_segs_num); if (ret) { + claim_zero(mlx5_devx_cmd_destroy(priv->login_obj)); mlx5_devx_uar_release(&priv->uar); rte_cryptodev_pmd_destroy(priv->crypto_dev); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-05-10 13:24:22.231360583 +0100 +++ 0024-crypto-mlx5-fix-login-cleanup.patch 2022-05-10 13:24:21.614646374 +0100 @@ -1 +1 @@ -From 146fe289de25cc3553894ed451066da6bc8b2789 Mon Sep 17 00:00:00 2001 +From 8bad3a05f1b36f84717072dcf483fe11b705ac7d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 146fe289de25cc3553894ed451066da6bc8b2789 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index e14f867797..d0901f3b7c 100644 +index 421c23748a..36db31aae5 100644 @@ -24 +25 @@ -@@ -948,4 +948,5 @@ mlx5_crypto_dev_probe(struct mlx5_common_device *cdev, +@@ -953,4 +953,5 @@ mlx5_crypto_dev_probe(struct mlx5_common_device *cdev)