From: Michael Baum <michaelba@nvidia.com>
To: <stable@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Kevin Traynor <ktraynor@redhat.com>
Subject: [PATCH 21.11 1/2] net/mlx5: fix LRO validation in Rx setup
Date: Sun, 15 May 2022 16:18:25 +0300 [thread overview]
Message-ID: <20220515131826.763915-2-michaelba@nvidia.com> (raw)
In-Reply-To: <20220515131826.763915-1-michaelba@nvidia.com>
[ upstream commit a213b8682117711c8e92475c5bbb321a3d8428dd ]
The mlx5_rx_queue_setup() get LRO offload from user.
When LRO is configured, the LRO flag in rxq_data is set to 1.
This patch adds validation to make sure the LRO is supported.
Fixes: 17ed314 ("net/mlx5: allow LRO per Rx queue")
Signed-off-by: Michael Baum <michaelba@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
drivers/net/mlx5/mlx5_rxq.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index a5a96c9a60..4f32ae3b8d 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -841,6 +841,14 @@ mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
uint64_t offloads = conf->offloads |
dev->data->dev_conf.rxmode.offloads;
+ if ((offloads & RTE_ETH_RX_OFFLOAD_TCP_LRO) &&
+ !priv->config.lro.supported) {
+ DRV_LOG(ERR,
+ "Port %u queue %u LRO is configured but not supported.",
+ dev->data->port_id, idx);
+ rte_errno = EINVAL;
+ return -rte_errno;
+ }
if (mp) {
/*
* The parameters should be checked on rte_eth_dev layer.
--
2.25.1
next prev parent reply other threads:[~2022-05-15 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-15 13:18 [PATCH 21.11 0/2] net/mlx5: LRO fixes Michael Baum
2022-05-15 13:18 ` Michael Baum [this message]
2022-05-15 13:18 ` [PATCH 21.11 2/2] net/mlx5: fix LRO configuration in drop Rx queue Michael Baum
2022-05-19 13:59 ` [PATCH 21.11 0/2] net/mlx5: LRO fixes Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220515131826.763915-2-michaelba@nvidia.com \
--to=michaelba@nvidia.com \
--cc=ktraynor@redhat.com \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).