From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15B1AA00BE for ; Sun, 15 May 2022 15:18:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DA9940143; Sun, 15 May 2022 15:18:42 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2088.outbound.protection.outlook.com [40.107.223.88]) by mails.dpdk.org (Postfix) with ESMTP id 7347A40A7B for ; Sun, 15 May 2022 15:18:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aPt9UXZxq+MWzZOvAKEDiqEEXNU4anwFCJspwaR1Y1SKWjA3epVexHvq4at1V6Ae8hnPjQXqcp3BdG6cvRFiQKhELcGtWhQx8MzElqvI9mR35ezDAXNbgvcmbCVElmhImCMm6WFhwAhPfD+6gdi1k85Qo/ZPJq/LUgrmKXtritWEzd53txpgIttLVqd7eN9Jdhl3l4io8+Zwb+YP2ajdNqZBbyLQxeoq5TU5KzCTMNwWbV2vbjjkN4n51OPdzqHGByIUVDokRDJJCxzw3xShFIqW73Xal2q15s+90R0k+wsOibeI8k3Sp6CKlQcgq5tMQGKLQFNfjqA2kcQQidydxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y6Fb15+M9XXU7WITUYNJgPScDUEp29hMqEjukW9DIJU=; b=KUZRJc0BwcQ0ah6HWSlVhckX1pgD1a7ggGc3qm5Sh0sCRSBAMtnc9nYfrFHMOPxpDnHUn5g+P/0mI//5BrCdUS896PiWVKogBFrA6HwsSmtLXe3G3W7006veMUtWsUcY8c83hJpImlLN8X8RF/6XLoz/C1um9cP1u2tiAeCCtui1ln9oFOxWdFP6bCA2B8ft3chZC4EHQCd6aVRtw/I15MZnxqU4Nh7dB1esvNEu8VDFtFI/ZWeGwZL1vWA8YfrTWqr0yrZQL7Z4PSg+VbsT+ZxbaVZcTRQPbdNMwNT1S6eB6LZ2LezzhrUzNa8MaKJV3ZQazuNoWwO4f/WGnqp79g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.234) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y6Fb15+M9XXU7WITUYNJgPScDUEp29hMqEjukW9DIJU=; b=t9Qh2IesIg10JwVrKVIplR35cTwtb6TFeo79h5ChJ6Sl2s/36WhZlqTyWgRkzDr3TeMCEaXyOiXW3zg3apKrtjJk2dzdGh+DuO2EsMjDWK0ZKPUb9nZNpR6Vj5fWhhPQ2dFc6G0ns9c378YLTsN/K15L5Npghy9QR5uM6CuCyeZQGmLhSqhLE9s6IM+Mo6eJrzbL3Mq6t5xQos0H5ngEQ7A/YIpbzvL/UTBZ2yXY2sQZze7Y0CEk3ds4Bkh6ND+6I3r2GH58UvVvc7ddYYJoqliw9L+D5qZcXECEjf6Qj7pNTfU9aLca3nNUY+2fud22H8FgBEae5FPoY2k/+d2Pyw== Received: from BN1PR14CA0008.namprd14.prod.outlook.com (2603:10b6:408:e3::13) by SN1PR12MB2366.namprd12.prod.outlook.com (2603:10b6:802:25::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Sun, 15 May 2022 13:18:38 +0000 Received: from BN8NAM11FT014.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e3:cafe::25) by BN1PR14CA0008.outlook.office365.com (2603:10b6:408:e3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.16 via Frontend Transport; Sun, 15 May 2022 13:18:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.234) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.234 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.234; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.234) by BN8NAM11FT014.mail.protection.outlook.com (10.13.177.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5250.13 via Frontend Transport; Sun, 15 May 2022 13:18:37 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by DRHQMAIL101.nvidia.com (10.27.9.10) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Sun, 15 May 2022 13:18:37 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sun, 15 May 2022 06:18:36 -0700 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22 via Frontend Transport; Sun, 15 May 2022 06:18:35 -0700 From: Michael Baum To: CC: Matan Azrad , Viacheslav Ovsiienko , Kevin Traynor Subject: [PATCH 21.11 1/2] net/mlx5: fix LRO validation in Rx setup Date: Sun, 15 May 2022 16:18:25 +0300 Message-ID: <20220515131826.763915-2-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220515131826.763915-1-michaelba@nvidia.com> References: <20220515131826.763915-1-michaelba@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b8ce936e-6284-4557-9941-08da36756c44 X-MS-TrafficTypeDiagnostic: SN1PR12MB2366:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eA7Blsphf3wgoQ23BW8XxGjWPmWaCKEiIHkTFDW/xpyExZddLxXXFSAepFwq1q9qTdf2rjIMVHJNrmyGKUYSjckwYj/m3cNid4pFKxlQ5i6d4PL1X0XZTbGOmRHVAxhdLkZaM576xYhnGgPO191X7yjqxy84BsyaF1gyl4ElrPGuTGWhjD07Pt6vA4+sr9sWqejIL4s1VU9+zsGbZUy8uMUhPVccF0pQiQ36Idh3S4j8T0UHXzQ+OFSEKiboOSx7Dm36bfD7GHEALlrzajPqsVucxHvOFwY1SriZtZPxqfwbzX7u7Na6q1KSYd+6n8BzYROTzPTo6FD2rOFQ5Rq3mJdyLKg7Jfx5EacGXaxRn7MA+Rabpavwbu4J/8Qw8d6b5VlbZeZ6PNClucsD6gN4pjz5na7wfAjK93rENmXEigvrWR+jS4gMD7ofum5R11E3zLBJQIpotPzlMz1Z+xKkcosNghzBuSSr4pnOyr6yDooNKPvSSWv7Q0+tLVu0KamlJ6Qoo23ItOnn7NeYMCeef/cCSqFxWfjGVgxBxgvTTxUCC5is/7Y7hI/mUlBvFgwTt2TuvXfkbIK3FQwUghbDII1HGrjL9TZU4t9lew5orzA9DJvgbnJ23uQnXiKubv6OP62N64I6Mp5KoITEO7JcE16HgsQty0IORR1niAcpR1gLJuge012DC3NEXe721hneLtG2y+ifKqzP06geuRglcQ== X-Forefront-Antispam-Report: CIP:12.22.5.234; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(1076003)(2906002)(508600001)(186003)(2616005)(7696005)(6666004)(26005)(40460700003)(356005)(6286002)(55016003)(86362001)(6916009)(82310400005)(336012)(36860700001)(47076005)(426003)(70206006)(4326008)(8676002)(54906003)(8936002)(316002)(70586007)(5660300002)(81166007)(36756003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2022 13:18:37.9667 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b8ce936e-6284-4557-9941-08da36756c44 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.234]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT014.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2366 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [ upstream commit a213b8682117711c8e92475c5bbb321a3d8428dd ] The mlx5_rx_queue_setup() get LRO offload from user. When LRO is configured, the LRO flag in rxq_data is set to 1. This patch adds validation to make sure the LRO is supported. Fixes: 17ed314 ("net/mlx5: allow LRO per Rx queue") Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxq.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index a5a96c9a60..4f32ae3b8d 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -841,6 +841,14 @@ mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc, uint64_t offloads = conf->offloads | dev->data->dev_conf.rxmode.offloads; + if ((offloads & RTE_ETH_RX_OFFLOAD_TCP_LRO) && + !priv->config.lro.supported) { + DRV_LOG(ERR, + "Port %u queue %u LRO is configured but not supported.", + dev->data->port_id, idx); + rte_errno = EINVAL; + return -rte_errno; + } if (mp) { /* * The parameters should be checked on rte_eth_dev layer. -- 2.25.1