From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31984A00BE for ; Sun, 15 May 2022 15:18:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C34540143; Sun, 15 May 2022 15:18:44 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2072.outbound.protection.outlook.com [40.107.220.72]) by mails.dpdk.org (Postfix) with ESMTP id 9CB6D40A7D for ; Sun, 15 May 2022 15:18:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ab8dFcE/dsZf3qc1tlzzdew3aKMgTotPKGeNxjGg/gEFmiyJtgQjIi4nuOyy96XffBqoeTf0y6D2P6M4aoivCK2dbiliIGo4vSNeI8m3vHYE+y4XHuXGSTP2AfWFwXpoM9ZrK5sq67Fm4+aaziM1EDKEzftFPXMgBHbWlMI9vMPnksDCmnCQPq9J80XqzQpHOceyfXZ8kfH6GuFNfsSln8iPk2FUzEZPNdIQRK0yRw0BdXSDOz6inogRuRKPVsLoHSIlZTBE1SbNfncBNHmmqbU3cxC9c2a2EjGqTmMETcbNU8YioqRdmWIPppvfehXozF8GPwajfac8ZSfj1I7phQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9rkwIvis2rE5pm38uoIgi9/uzBcSs0gez0Hskq33l9E=; b=e/aywMShqACUQqAJUzhWhnwy4jdPaV0+F1swce0G3/jxB4SNAHiTna6cE9woQe71gJoCmZu7RWjkHc73oATiEIU4wppP21M0P2YE3Kvwv2ktMq9YIxVu1pc5m1ANUVvRGadB/zw1696Ye+L/PmFhalCyOrCeFt21nG6lVCzULrMZAUeGXcLzw/Zj6J17sJNcCS9Hsa1ol9u6VWS/ZRydEyW2Wvl7SrwbI1+dNTgHXlWxaqWukk37grwXciPhHGnLoNJ0fQWiXlWnigfgMIboyazkAGIexjlZPiDDy2H6W5OEbPumfb3DBL7JtwAoSn41SOwxxpXNA6+ZhbFTuGQzLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.236) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9rkwIvis2rE5pm38uoIgi9/uzBcSs0gez0Hskq33l9E=; b=Z1ZHvUZ3Se+n5dSeNHlUJZp2MgksR9Q19bEIfjsYpf58rVoe0cmmCt8z4DfyGVLMIsixp5p6n+B3DhvjKweUL2CEy66pPnvZqdPW6xcIWt7kR2kcO0+9dmGNqZIXbyoHGgg9pKqYrQ8p5BlOA43/HZML9FmC7ymJtWy//38H9eYIZewW8b9umdJfhtKJmBxFvdm6vWf80e4i69EDoCsgQsfBQtU9qB6VTBZTdpCngH9OF94RafTF7wLr+OurZ5l9tMUGy4n00i37XWbrhkv3ij9flP1fmA9XkTN6oM70/K5m1DLCt78aE/dt4G0X8TU2NKpAh2Q/YBKCIycGA+Lk1A== Received: from DM6PR07CA0046.namprd07.prod.outlook.com (2603:10b6:5:74::23) by BN8PR12MB3345.namprd12.prod.outlook.com (2603:10b6:408:64::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Sun, 15 May 2022 13:18:39 +0000 Received: from DM6NAM11FT040.eop-nam11.prod.protection.outlook.com (2603:10b6:5:74:cafe::3c) by DM6PR07CA0046.outlook.office365.com (2603:10b6:5:74::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18 via Frontend Transport; Sun, 15 May 2022 13:18:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.236) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.236 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.236; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.236) by DM6NAM11FT040.mail.protection.outlook.com (10.13.173.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5250.13 via Frontend Transport; Sun, 15 May 2022 13:18:39 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by DRHQMAIL109.nvidia.com (10.27.9.19) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Sun, 15 May 2022 13:18:38 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sun, 15 May 2022 06:18:38 -0700 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22 via Frontend Transport; Sun, 15 May 2022 06:18:37 -0700 From: Michael Baum To: CC: Matan Azrad , Viacheslav Ovsiienko , Kevin Traynor Subject: [PATCH 21.11 2/2] net/mlx5: fix LRO configuration in drop Rx queue Date: Sun, 15 May 2022 16:18:26 +0300 Message-ID: <20220515131826.763915-3-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220515131826.763915-1-michaelba@nvidia.com> References: <20220515131826.763915-1-michaelba@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4a51e39c-83c8-4d3c-5cb8-08da36756d1b X-MS-TrafficTypeDiagnostic: BN8PR12MB3345:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xHLmbrNvEIr32uFI8fXXQzdYlgxUcjeVtFG6stO2xbHsL4WuqBW/t34FlBfnfeHVyl8VVx8g9SNOHsMeeJHJD1OI2uFl7Wf5yHvpI1uCj6PjRv5jkdjtxA2QMkZhnA3x7+IFngxcJRIcUFN6Rht4H33JVw9RwfdWZ4kbJzCYxi/10/huxtw+6Hq5p/8uu/J80NdnXi/tulgkvUAI1u1mLqRlt3hTi9jQL0D6u7lUJo19ZvkbaurPGsIRklEuBO02acZyMR+t7scnRmD7qzXI0mKioQYggP93rGQI/Sl8LhDGBk4doqPw6GwX0mt7Wl5eejHAhoGdfE+hnvjmXasIVkm+qen8GCOd9JTm4PUvl38jMD4xU8KJYVSiKu7EJvsr1AhZMq5IxwKjs4evap9SFSXHIPQD9Gu3W0kYapb0VffnNCme1uHm8iBN+twUDwQcbo/2uHzB5Z90BCOFYfL4e4Vf2QJQmq4jMoY8cdcr2vAk+ChuMyHwCzsOZMsLaNKFRu+dN6qIjP3YHx3Zj+z/o8ecEz1ZwYZrPZFqt/gZwPBbvo7SQVpyjYqCLB36RpTgsuqZuzUM+AsuoMCoyDlGqab1sPDqtM/NP1ORPBA+WUWDBx6nUWlu7Hv7CDEGmaLQkpdibmArYxDKn92CQI19UtDZLeQN/M+lzoSa0g7NwAAtEOgKPeJnrGY5ae/e64VM+3C/5cxXo6X3mKh+sbWKEA== X-Forefront-Antispam-Report: CIP:12.22.5.236; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(8676002)(6286002)(186003)(82310400005)(2616005)(4326008)(36860700001)(70206006)(86362001)(1076003)(5660300002)(8936002)(26005)(36756003)(70586007)(55016003)(316002)(83380400001)(40460700003)(47076005)(426003)(336012)(6666004)(356005)(54906003)(508600001)(7696005)(2906002)(81166007)(6916009)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2022 13:18:39.4836 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4a51e39c-83c8-4d3c-5cb8-08da36756d1b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.236]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT040.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3345 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [ upstream commit 7a9933686574f33ec3444abbc800ac50286510f8 ] The driver wrongly set the LRO configurations to the TIR of the DevX drop queue even when LRO is not supported. Actually, the LRO configuration is not relevant to the drop queue at all. This causes failure in the initialization of the device, which doesn't support LRO where the drop queue is created. Probably, the drop queue creation by DevX missed the fact that LRO is set by default in the TIR creation function and didn't unset it in the drop queue case like other cases that unset LRO. Move the default LRO configuration to unset it and set it only in the case of all the TIR queues configured with LRO. Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX") Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_devx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c index abf6a48086..44c439bb55 100644 --- a/drivers/net/mlx5/mlx5_devx.c +++ b/drivers/net/mlx5/mlx5_devx.c @@ -706,7 +706,7 @@ mlx5_devx_tir_attr_set(struct rte_eth_dev *dev, const uint8_t *rss_key, { struct mlx5_priv *priv = dev->data->dev_private; enum mlx5_rxq_type rxq_obj_type; - bool lro = true; + bool lro = false; uint32_t i; /* NULL queues designate drop queue. */ @@ -715,6 +715,7 @@ mlx5_devx_tir_attr_set(struct rte_eth_dev *dev, const uint8_t *rss_key, mlx5_rxq_ctrl_get(dev, ind_tbl->queues[0]); rxq_obj_type = rxq_ctrl != NULL ? rxq_ctrl->type : MLX5_RXQ_TYPE_STANDARD; + lro = true; /* Enable TIR LRO only if all the queues were configured for. */ for (i = 0; i < ind_tbl->queues_n; ++i) { @@ -768,6 +769,7 @@ mlx5_devx_tir_attr_set(struct rte_eth_dev *dev, const uint8_t *rss_key, tir_attr->self_lb_block = MLX5_TIRC_SELF_LB_BLOCK_BLOCK_UNICAST; if (lro) { + MLX5_ASSERT(priv->config.lro.supported); tir_attr->lro_timeout_period_usecs = priv->config.lro.timeout; tir_attr->lro_max_msg_sz = priv->max_lro_msg_size; tir_attr->lro_enable_mask = -- 2.25.1